-
Notifications
You must be signed in to change notification settings - Fork 423
Rebase to kubernetes 1.34.2 #3742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Mangirdas Judeikis <[email protected]>
|
/retest |
f5d33a7 to
a0f8619
Compare
| apiVersion: apis.kcp.io/v1alpha2 | ||
| kind: APIExport | ||
| metadata: | ||
| creationTimestamp: null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was an artifact of some old synctarget related code I removed from the fork.
|
/retest |
3d50ae4 to
f74a488
Compare
|
/retest |
1 similar comment
|
/retest |
Signed-off-by: Mangirdas Judeikis <[email protected]> On-behalf-of: @SAP [email protected]
f74a488 to
18375fb
Compare
|
/retest |
xrstf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/hold in case @ntnn has more questions
|
LGTM label has been added. Git tree hash: a96370b1d2cc90bff9a23377bee745b926d49dcf
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ntnn, xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
This PR bring in k/k 1.34.2 into kcp.
few main changes:
What Type of PR Is This?
/kind feature
Related Issue(s)
Fixes #3740
Diff for k/k kcp-dev/kubernetes#182
Release Notes