add cross-workspace implementation for ValidatingAdmissionPolicy #3743
+333
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcp-ci-bot
added
release-note
kcp-ci-bot
added
the
size/L
olamilekan000
force-pushed
the
implement-crossworskapce-validating-admission-policy
branch
3 times, most recently
from
2d86b89 to
70c4885
Compare
Contributor
Author
|
/retest |
5 similar comments
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
mjudeikis
reviewed
Dec 9, 2025
mjudeikis
reviewed
Dec 9, 2025
Contributor
mjudeikis
left a comment
mjudeikis
left a comment
There was a problem hiding this comment.
Few questions. Mostrly why do we need to change delegate keys?
pkg/admission/validatingadmissionpolicy/validating_admission_policy.go
Outdated
Show resolved
Hide resolved
pkg/admission/validatingadmissionpolicy/validating_admission_policy.go
Outdated
Show resolved
Hide resolved
pkg/admission/validatingadmissionpolicy/validating_admission_policy.go
Outdated
Show resolved
Hide resolved
mjudeikis
reviewed
Dec 9, 2025
olamilekan000
force-pushed
the
implement-crossworskapce-validating-admission-policy
branch
2 times, most recently
from
b6b1a86 to
e6d3d6d
Compare
Contributor
|
/retest |
Signed-off-by: olalekan odukoya <[email protected]>
olamilekan000
force-pushed
the
implement-crossworskapce-validating-admission-policy
branch
from
e6d3d6d to
65cc18f
Compare
Contributor
|
LGTM label has been added. Git tree hash: e4eaf0518563864113f582b6d0a3597c023f3e4e
|
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mjudeikis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
Contributor
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What Type of PR Is This?
/kind feature
Related Issue(s)
Fixes 3733
Release Notes