Generation number doesn't seem correctly set on cached builtin resources.

When completing the `replication_test.go` e2e cache test with replication scenarios of rbac resources (CR / CRB objects), the generation is not equal when comparing original and cached objects.

I added a TODO in the completed test: https://github.com/kcp-dev/kcp/blob/cf8a625b0266f761e70e0eb5dcde0817b6ac89e8/test/e2e/reconciler/cache/replication_test.go#L706-L716

Maybe the work done for CRD-backed resources in [this PR](https://github.com/kcp-dev/kubernetes/pull/106) should also be done for built-in  resources that support replication ?



	// TODO(davidfestal): find out why the generation is not the same especially for rbacv1. Is it a characteristic of all
	// internal KCP resources (which are not backed by CRDs) ?
	if b.gvr.Group == rbacv1.SchemeGroupVersion.Group {
	unstructured.RemoveNestedField(originalResource.Object, "metadata", "generation")
	unstructured.RemoveNestedField(cachedResource.Object, "metadata", "generation")
	}

	unstructured.RemoveNestedField(cachedResource.Object, "metadata", "annotations", genericapirequest.AnnotationKey)
	if cachedStatus, ok := cachedResource.Object["status"]; ok && cachedStatus == nil \|\| (cachedStatus != nil && len(cachedStatus.(map[string]interface{})) == 0) {
	// TODO: worth investigating:

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Generation number doesn't seem correctly set on cached builtin resources. #2935

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Generation number doesn't seem correctly set on cached builtin resources. #2935

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions