Skip to content

Conversation

@mjudeikis
Copy link

@mjudeikis mjudeikis commented Dec 9, 2025

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Commit high level status:

clean 246c6d5cf35 UPSTREAM: 120920: Revert: Revert: Clean up CRD conversion code structure
clean 6b4d3c8d661 README
clean 5b44d100d04 UPSTREAM: <carry>: controlplane/apiserver: add miniaggregator
clean 71be679605d UPSTREAM: <carry>: clusterize controllers

moved to bottom & squashed -  b347c910c0d UPSTREAM: <carry>: re-add GC worker locks
moved to bottom & squashed - 609006f7e8e UPSTREAM: <carry>: re-generated pkg/controller/resourcequota/resource_quota_controller_patch.go
moved to bottom & squashed - 8b97931629c UPSTREAM: <carry>: re-generated pkg/controller/garbagecollector/garbagecollector_patch.go

clean c6f0436b78b UPSTREAM: <carry>: storage: etcd cluster key computation
clean 6b814bc0a89 UPSTREAM: <carry>: clusterize serviceaccounts
clean 89bd6299389 UPSTREAM: <carry>: registry/core/serviceaccount: do not crash without pods
clean 9ecd9a8b7fe UPSTREAM: <carry>: INTERESTING: clusterize admission
clean 875e4efc01e UPSTREAM: <carry>: Clusterize ValidatingAdmissionPolicy admission plugin and policy plugin framework
clean 8313437608c UPSTREAM: <carry>: clusterize storage hash
clean 1b61d3203a7 UPSTREAM: <carry>: endpoints: add Cluster struct for ctx
clean c92b5b11c9e UPSTREAM: <carry>: endpoints/patch: wire openapi for CRD strategic merge patch
semi clean - 4301063ba65 UPSTREAM: <carry>: storage/etcd3: clusterize
semi clean - 74199ed75b9 UPSTREAM: <carry>: apiserver: partial wildcard metadata request accross identities
clean 3e108eefbf2 UPSTREAM: <carry>: endpoints: set kcp.io/original-api-version on wildcard partial metadata requests
VERY INTERESTING UPSTREAM: <carry>: watch(er/cache): clusterize
Might need !utilfeature.DefaultFeatureGate.Enabled(features.WatchList) by default
clean aed464aa805 UPSTREAM: <carry>: apiserver: split chain into pre and post authz
clean 8489d629a43 UPSTREAM: <carry>: apiserver: clusterize listed paths
clean 47ed6f8bc41 UPSTREAM: <carry>: apiserver: clusterize OpenAPI v2
clean a349232bd86 UPSTREAM: <carry>: clusterize BuiltInAuthenticationOptions
clean 024ea68aa3e UPSTREAM: <carry>: storage: add UseResourceAsPrefixDefault for legacy storage paths
semi clean. Has some syncer code. we might want to clean f2784002fea UPSTREAM: <carry>: apiextensions-apiserver
dirty with etcd changes 4fe8fd52e9b UPSTREAM: <carry>: cache-server: wire shard name into storage
move to bottom - 5f41e15e5da UPSTREAM: <carry>: add client and informer hacks
clean d1a48d599a1 UPSTREAM: <carry>: controlplane: wire informers and clients
clean 4e6c1b943d8 UPSTREAM: <carry>: generic cleanup
squashed to new commit 77287d47441 UPSTREAM: <carry>: controlplane/apiserver: disable protobuf for loopback
clean bce382ac726 UPSTREAM: <carry>: pass system:admin clients and informers in generic control plane
clean a72d1afd768 UPSTREAM: <carry>: remove REST mapper from admission plugins
clean b2cbed7310f UPSTREAM: <carry>: provide supportedMediaTypes for custom resoure handler patch
clean ae501df22a5 UPSTREAM: <carry>: prevent NPE if no authorization is set
clean 6913c31825f UPSTREAM: <carry>: wrap CRD group into packagePrefix for OpenAPIV3 builder
clean dfd1b5ed920 UPSTREAM: <CARRY>: clusterize validatingadmissionpolicystatus controller
clean 4cfa8c7e4d3 UPSTREAM: <carry>: apiserver cleaning
clean 8c0f900dbae UPSTREAM: <carry>: include cluster name in authz SubjectAccessReview in webhooks
clean bab517d7eac UPSTREAM: <carry>: split auth/authz chains even more
clean 69732f7df58 UPSTREAM: <carry>: authz: add scoping to default rule resolver
clean 51246346350 UPSTREAM: <carry>: authz: add warrants to default rule resolver
DROP. might be an issue 024d97ba2f1 UPSTREAM: <carry>: endpoints: wire in ctx to watchListTransformer
clean 7e6aca69a5a UPSTREAM: <carry>: Clusterize MutatingAdmissionPolicy admission plugin and policy plugin framework
squashed 0c76bb33ef4 UPSTREAM: <carry>: don't use --prefers-protobuf with client-gen
clean cae17c2c87c UPSTREAM: <carry>: Add kube feature gate for global service account
clean a3ba416b6df UPSTREAM: <carry>: Allow pin-dependency to add redirects to local paths
clean b2d60d8f362 UPSTREAM: <carry>: Drop validation-gen
clean 61289df7ae3 UPSTREAM: <carry>: Drop merge and replace in x-kubernetes-list/map-type
clean e18696ce725 UPSTREAM: <carry>: Keep system:cluster:* groups
clean ed68b68c507 UPSTREAM: <carry>: Rename authentication.{kubernetes=>kcp}.io/cluster-name
clean 955c09ccd62 UPSTREAM: <carry>: Tie global service account test result to feature gate it relies on
clean ddb6d2f4631 UPSTREAM: <carry>: Add authentication.kcp.io/scopes to service accounts
clean c42ced9a991 UPSTREAM: <carry>: Add system:cluster:<cluster> group to effective users
clean de7dee8ff27 UPSTREAM: <carry>: Update pkg/registry/rbac/validation/kcp_test.go
clean 92e07c2466d UPSTREAM: <carry>: Add authorization.kcp.io/cluster-name extra to webhook requests
clean 9c03f0e66d2 UPSTREAM: <fixup>: Remove redundant failsafe
cleandcdcf2dab05 UPSTREAM: <carry>: forward current cluster context in TokenReviews

clean - 8828a4d03c6 UPSTREAM: <carry>: kube-aggregator

done - b6c2c1ccb48 UPSTREAM: <carry>: Add kcp patchers

sttts and others added 30 commits December 8, 2025 09:39
Previous PRs: 113151 117301

Signed-off-by: Dr. Stefan Schimanski <[email protected]>

Co-authored-by: Mangirdas Judeikis <[email protected]>
Co-authored-by: Dr. Stefan Schimanski <[email protected]>
Signed-off-by: Mangirdas Judeikis <[email protected]>
Signed-off-by: Nelo-T. Wallus <[email protected]>
Signed-off-by: Nelo-T. Wallus <[email protected]>
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
Co-authored-by: Marvin Beckers <[email protected]>
Signed-off-by: Marvin Beckers <[email protected]>
Signed-off-by: Nelo-T. Wallus <[email protected]>
Signed-off-by: Nelo-T. Wallus <[email protected]>
Co-authored-by: Marvin Beckers <[email protected]>
Signed-off-by: Marvin Beckers <[email protected]>
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
Signed-off-by: Nelo-T. Wallus <[email protected]>
Signed-off-by: Nelo-T. Wallus <[email protected]>
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
Co-authored-by: Marvin Beckers <[email protected]>
Signed-off-by: Marvin Beckers <[email protected]>
Co-authored-by: Robert Vasek <[email protected]>
Signed-off-by: Robert Vasek <[email protected]>
…gin and policy plugin framework

Signed-off-by: Marvin Beckers <[email protected]>
Co-authored-by: Marvin Beckers <[email protected]>
Signed-off-by: Marvin Beckers <[email protected]>
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
Signed-off-by: Nelo-T. Wallus <[email protected]>
Signed-off-by: Nelo-T. Wallus <[email protected]>
…card partial metadata requests

Signed-off-by: Dr. Stefan Schimanski <[email protected]>
Co-authored-by: Marvin Beckers <[email protected]>
Signed-off-by: Marvin Beckers <[email protected]>
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
Signed-off-by: Nelo-T. Wallus <[email protected]>
Signed-off-by: Nelo-T. Wallus <[email protected]>
Co-authored-by: Marvin Beckers <[email protected]>
Signed-off-by: Marvin Beckers <[email protected]>
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
Co-authored-by: Marvin Beckers <[email protected]>
Signed-off-by: Marvin Beckers <[email protected]>
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
Signed-off-by: Nelo-T. Wallus <[email protected]>
Signed-off-by: Nelo-T. Wallus <[email protected]>
Co-authored-by: Marvin Beckers <[email protected]>
Signed-off-by: Marvin Beckers <[email protected]>
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
Signed-off-by: Nelo-T. Wallus <[email protected]>
Signed-off-by: Nelo-T. Wallus <[email protected]>
Co-authored-by: Marvin Beckers <[email protected]>
Signed-off-by: Marvin Beckers <[email protected]>
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
Signed-off-by: Nelo-T. Wallus <[email protected]>
Signed-off-by: Nelo-T. Wallus <[email protected]>
… control plane

Signed-off-by: Marvin Beckers <[email protected]>
Signed-off-by: Nelo-T. Wallus <[email protected]>
Signed-off-by: Nelo-T. Wallus <[email protected]>
embik and others added 26 commits December 9, 2025 09:33
…n and policy plugin framework

On-behalf-of: SAP [email protected]
Signed-off-by: Robert Vasek <[email protected]>
TODO: this commit may be dropped once kcp-dev/kcp#3274 and related issues are done

Signed-off-by: Karol Szwaj <[email protected]>

On-behalf-of: @SAP [email protected]
Signed-off-by: Nelo-T. Wallus <[email protected]>
In kubernetes#130349 for KEP-5073
validation-gen was added to `gen_helpers`.

KCP is currently not using validation-gen, but it is causing errors as
validation-gen directly imports k8s.io/apimachinery, which is rewritten
in the go.mod to `../apimachinery`.

This is working fine locally and in go workspaces, but breaks as soon as
`k8s.io/code-generator` is used from the kcp-dev/kubernetes fork, as
then the rewrite still exists but points to nothing.

Upstream the rewrites are resolved to the respective commit in the
module when publishing the changes to their repositories.

Signed-off-by: Nelo-T. Wallus <[email protected]>
Signed-off-by: Nelo-T. Wallus <[email protected]>
Signed-off-by: Nelo-T. Wallus <[email protected]>
…-name

Signed-off-by: Nelo-T. Wallus <[email protected]>
Signed-off-by: Nelo-T. Wallus <[email protected]>
…gate it relies on

Signed-off-by: Nelo-T. Wallus <[email protected]>
Signed-off-by: Nelo-T. Wallus <[email protected]>
…hook requests

Signed-off-by: Nelo-T. Wallus <[email protected]>
Signed-off-by: Nelo-T. Wallus <[email protected]>
Signed-off-by: Nelo-T. Wallus <[email protected]>
Signed-off-by: Nelo-T. Wallus <[email protected]>
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
Signed-off-by: Marvin Beckers <[email protected]>
@kcp-ci-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign deads2k, logicalhan, sttts for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants