Skip to content

Commit e2d858c

Browse files
committed
test/e2e: eliminate last data race
On-behalf-of: SAP <[email protected]> Signed-off-by: Marvin Beckers <[email protected]>
1 parent 75abe3b commit e2d858c

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

test/e2e/initializingworkspaces_test.go

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -211,17 +211,23 @@ var _ = Describe("InitializingWorkspaces Provider", Ordered, func() {
211211
})
212212
})
213213
It("engages both Logical Clusters with initializers", func() {
214+
list := func() []string {
215+
lock.RLock()
216+
defer lock.RUnlock()
217+
return engaged.List()
218+
}
219+
214220
envtest.Eventually(GinkgoT(), func() (bool, string) {
215221
lock.RLock()
216222
defer lock.RUnlock()
217223
return engaged.Has(ws1.Spec.Cluster), fmt.Sprintf("failed to see workspace %q engaged as a cluster: %v", ws1.Spec.Cluster, engaged.List())
218-
}, wait.ForeverTestTimeout, time.Millisecond*100, "failed to see workspace %q engaged as a cluster: %v", ws1.Spec.Cluster, engaged.List())
224+
}, wait.ForeverTestTimeout, time.Millisecond*100, "failed to see workspace %q engaged as a cluster: %v", ws1.Spec.Cluster, list())
219225

220226
envtest.Eventually(GinkgoT(), func() (bool, string) {
221227
lock.RLock()
222228
defer lock.RUnlock()
223229
return engaged.Has(ws2.Spec.Cluster), fmt.Sprintf("failed to see workspace %q engaged as a cluster: %v", ws2.Spec.Cluster, engaged.List())
224-
}, wait.ForeverTestTimeout, time.Millisecond*100, "failed to see workspace %q engaged as a cluster: %v", ws2.Spec.Cluster, engaged.List())
230+
}, wait.ForeverTestTimeout, time.Millisecond*100, "failed to see workspace %q engaged as a cluster: %v", ws2.Spec.Cluster, list())
225231
})
226232

227233
It("removes initializers from the both clusters after engaging", func() {

0 commit comments

Comments
 (0)