Fix 32 mypy errors in test files

Resolve type-checking failures caught by lint.yaml's "Lint types" job:

- test_matrix: suppress arg-type/list-item on intentional negative tests,
  widen tuple type after prune() to avoid false unreachable from length
  narrowing
- test_metadata: annotate expected dict as dict[str, Any] to prevent
  narrowing cascade, suppress StrEnum arg-type on Dialect members
- test_help: replace click.BaseCommand (not recognized by mypy) with
  click.Group | click.Command
- test_git_ops: suppress arg-type on intentional invalid "patch" argument
- test_binary: annotate empty dict for mypy inference
- test_checksums: assert binary_spec.binary is not None before access
- test_init_project: assert isinstance for ToolConfigComponent narrowing,
  annotate mixed-type dict for _serialize_array_entries

Co-Authored-By: Claude <noreply@anthropic.com>

Author: kdeldycke

tests/test_binary.py

@@ -125,7 +125,7 @@ def test_missing_field(tmp_path):
     binary.touch()
 
     # Return empty metadata.
-    mock_output = {}
+    mock_output: dict[str, str] = {}
     with (
         patch("repomatic.binary.run_exiftool", return_value=mock_output),
         pytest.raises(AssertionError, match="Binary architecture mismatch"),

tests/test_checksums.py

@@ -136,6 +136,7 @@ def test_update_registry_checksums_replaces_stale_hash(tmp_path):
             binary_spec = spec
             break
     assert binary_spec is not None
+    assert binary_spec.binary is not None
 
     old_hash = next(iter(binary_spec.binary.checksums.values()))
 

tests/test_git_ops.py

@@ -236,7 +236,7 @@ def test_is_version_bump_allowed_returns_bool():
 def test_is_version_bump_allowed_invalid_part():
     """Test that is_version_bump_allowed raises for invalid parts."""
     with pytest.raises(ValueError, match="Invalid version part"):
-        is_version_bump_allowed("patch")
+        is_version_bump_allowed("patch")  # type: ignore[arg-type]
 
 
 def test_is_version_bump_allowed_current_repo():

tests/test_help.py

@@ -26,7 +26,7 @@
 
 
 def _collect_commands(
-    group: click.BaseCommand,
+    group: click.Group | click.Command,
     prefix: tuple[str, ...] = (),
 ) -> list[tuple[str, ...]]:
     """Recursively collect all command paths from a Click group."""

tests/test_init_project.py

@@ -1075,7 +1075,9 @@ def test_skips_already_dev_version(tmp_path: Path) -> None:
     pyproject = tmp_path / "pyproject.toml"
     pyproject.write_text(content, encoding="UTF-8")
 
-    result = _update_tool_config(content, _BY_NAME["bumpversion"], pyproject)
+    bv = _BY_NAME["bumpversion"]
+    assert isinstance(bv, ToolConfigComponent)
+    result = _update_tool_config(content, bv, pyproject)
 
     assert result is not None
     # Version should not be double-suffixed.
@@ -1136,7 +1138,9 @@ def test_preserves_local_array_entries(tmp_path: Path) -> None:
     pyproject = tmp_path / "pyproject.toml"
     pyproject.write_text(content, encoding="UTF-8")
 
-    result = _update_tool_config(content, _BY_NAME["bumpversion"], pyproject)
+    bv = _BY_NAME["bumpversion"]
+    assert isinstance(bv, ToolConfigComponent)
+    result = _update_tool_config(content, bv, pyproject)
 
     assert result is not None
     parsed = tomllib.loads(result)
@@ -1164,6 +1168,7 @@ def test_ongoing_sync_idempotent_with_local_entries(tmp_path: Path) -> None:
         'replace = "example.com/v{new_version}/"\n'
     )
     bv_comp = _BY_NAME["bumpversion"]
+    assert isinstance(bv_comp, ToolConfigComponent)
     pyproject = tmp_path / "pyproject.toml"
     pyproject.write_text(content, encoding="UTF-8")
 
@@ -1212,7 +1217,7 @@ def test_local_array_entries_detection() -> None:
 
 def test_serialize_array_entries_roundtrip() -> None:
     """Verify serialized entries produce valid TOML that parses back."""
-    entries = [
+    entries: list[dict] = [
         {"filename": "./readme.md", "ignore_missing_version": True, "search": "a"},
         {"filename": "./docs/tutorial.md", "search": 'has "quotes"'},
     ]

tests/test_matrix.py

@@ -54,13 +54,13 @@ def test_matrix():
     assert repr(matrix) == "<Matrix: FrozenDict({'foo': ('a', 'b', 'c', 'd')})>"
 
     with pytest.raises(ValueError):
-        matrix.add_variation("variation_1", None)
+        matrix.add_variation("variation_1", None)  # type: ignore[arg-type]
 
     with pytest.raises(ValueError):
         matrix.add_variation("variation_1", [])
 
     with pytest.raises(ValueError):
-        matrix.add_variation("variation_1", [None])
+        matrix.add_variation("variation_1", [None])  # type: ignore[list-item]
 
     with pytest.raises(ValueError):
         matrix.add_variation("include", ["a", "b", "c"])
@@ -140,9 +140,15 @@ def test_prune(caplog):
     matrix.prune()
 
     # Only the effective exclude and the non-axis-key exclude remain.
-    assert len(matrix.exclude) == 2
-    assert {"os": "macos-26", "version": "3.10"} in matrix.exclude
-    assert {"state": "unstable"} in matrix.exclude
+    # Reassign with an explicit annotation to widen the type back to a
+    # variable-length tuple.  The ``assert len(...) == 4`` above narrows
+    # ``matrix.exclude`` to a fixed-length 4-tuple; mypy cannot track the
+    # mutation performed by ``prune()``, so without this it considers the
+    # ``len(...) == 2`` assert unreachable.
+    exclude: tuple[dict[str, str], ...] = matrix.exclude
+    assert len(exclude) == 2
+    assert {"os": "macos-26", "version": "3.10"} in exclude
+    assert {"state": "unstable"} in exclude
 
     assert "Dropping no-op exclude" in caplog.text
     assert "'windows-11-arm'" in caplog.text

tests/test_metadata.py

@@ -383,7 +383,7 @@ def iter_checks(metadata: Any, expected: Any, context: Any) -> None:
         assert type(metadata) is type(expected)
 
 
-expected = {
+expected: dict[str, Any] = {
     "is_bot": AnyBool(),
     # skip_binary_build depends on the event type and changed files. In CI push events
     # where only non-binary-affecting files changed, it is True.
@@ -917,7 +917,7 @@ def iter_checks(metadata: Any, expected: Any, context: Any) -> None:
 
 
 def test_metadata_github_json_format():
-    raw = Metadata().dump(Dialect.github_json)
+    raw = Metadata().dump(Dialect.github_json)  # type: ignore[arg-type]
     assert isinstance(raw, str)
 
     # Output must be a single line starting with "metadata=".
@@ -956,7 +956,8 @@ def test_metadata_github_json_format():
 
 def test_metadata_github_json_format_key_filtering():
     raw = Metadata().dump(
-        Dialect.github_json, keys=("is_python_project", "current_version")
+        Dialect.github_json,  # type: ignore[arg-type]
+        keys=("is_python_project", "current_version"),
     )
     json_str = raw.strip().removeprefix("metadata=")
     metadata = json.loads(json_str)
@@ -965,7 +966,7 @@ def test_metadata_github_json_format_key_filtering():
 
 
 def test_metadata_json_format():
-    metadata = Metadata().dump(Dialect.json)
+    metadata = Metadata().dump(Dialect.json)  # type: ignore[arg-type]
     assert isinstance(metadata, str)
 
     iter_checks(json.loads(metadata), expected, metadata)
@@ -1703,7 +1704,7 @@ def test_config_reference():
     for f in dc_fields(Config):
         default = f.default_factory() if f.default_factory is not MISSING else f.default
         if hasattr(default, "__dataclass_fields__"):
-            expected_rows += len(dc_fields(type(default)))
+            expected_rows += len(dc_fields(type(default)))  # type: ignore[arg-type]
         else:
             expected_rows += 1
     assert len(rows) == expected_rows