Skip to content

Commit 22d7163

Browse files
author
Jorge Turrado Ferrero
authored
Revert GH action change and fix makefile (#2350)
Signed-off-by: Jorge Turrado <[email protected]>
1 parent cff3a44 commit 22d7163

File tree

2 files changed

+8
-11
lines changed

2 files changed

+8
-11
lines changed

.github/workflows/release-build.yml

+7-10
Original file line numberDiff line numberDiff line change
@@ -52,26 +52,23 @@ jobs:
5252
run: echo $DOCKER_HUB_ACCESS_TOKEN | docker login -u $DOCKER_HUB_USERNAME --password-stdin
5353

5454
- name: Get the version
55-
uses: little-core-labs/[email protected]
5655
id: get_version
57-
with:
58-
tagRegex: "v(.*)"
59-
tagRegexGroup: 1
56+
run: echo ::set-output name=VERSION::${GITHUB_REF#refs/tags/v}
6057

6158
- name: Release Deployment YAML file
6259
run: make release
6360
env:
64-
VERSION: ${{ steps.get_version.outputs.tag }}
61+
VERSION: ${{ steps.get_version.outputs.VERSION }}
6562

6663
- name: Publish KEDA images on GitHub Container Registry
6764
run: make publish
6865
env:
69-
VERSION: ${{ steps.get_version.outputs.tag }}
66+
VERSION: ${{ steps.get_version.outputs.VERSION }}
7067

7168
- name: Publish KEDA images on Docker Hub
7269
run: make publish-dockerhub
7370
env:
74-
VERSION: ${{ steps.get_version.outputs.tag }}
71+
VERSION: ${{ steps.get_version.outputs.VERSION }}
7572

7673
# Get release information to determine id of the current release
7774
- name: Get Release
@@ -87,7 +84,7 @@ jobs:
8784
env:
8885
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
8986
with:
90-
upload_url: https://uploads.github.com/repos/kedacore/keda/releases/${{ steps.get-release-info.outputs.id }}/assets?name=keda-${{ steps.get_version.outputs.tag }}.yaml
91-
asset_path: keda-${{ steps.get_version.outputs.tag }}.yaml
92-
asset_name: keda-${{ steps.get_version.outputs.tag }}.yaml
87+
upload_url: https://uploads.github.com/repos/kedacore/keda/releases/${{ steps.get-release-info.outputs.id }}/assets?name=keda-${{ steps.get_version.outputs.VERSION }}.yaml
88+
asset_path: keda-${{ steps.get_version.outputs.VERSION }}.yaml
89+
asset_name: keda-${{ steps.get_version.outputs.VERSION }}.yaml
9390
asset_content_type: application/x-yaml

Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ SHELL = /bin/bash
55

66
# If E2E_IMAGE_TAG is defined, we are on pr e2e test and we have to use the new tag and append -test to the repository
77
ifeq '${E2E_IMAGE_TAG}' ''
8-
VERSION = main
8+
VERSION ?= main
99
# SUFIX here is intentional empty to not append nothing to the repository
1010
SUFFIX =
1111
endif

0 commit comments

Comments
 (0)