Skip to content

Commit 481cc80

Browse files
authored
fix: add default Operation in Azure Service Bus scaler (#6731)
Signed-off-by: Rick Brouwer <[email protected]>
1 parent b05b703 commit 481cc80

File tree

3 files changed

+3
-1
lines changed

3 files changed

+3
-1
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ To learn more about active deprecations, we recommend checking [GitHub Discussio
7474

7575
- **General**: Admission Webhook blocks ScaledObject without metricType with fallback ([#6696](https://github.com/kedacore/keda/issues/6696))
7676
- **AWS SQS Queue Scaler**: Fix AWS SQS Queue queueURLFromEnv not working ([#6712](https://github.com/kedacore/keda/issues/6712))
77+
- **Azure Service Bus scaler**: Fix Azure Service Bus scaler add default Operation ([#6730](https://github.com/kedacore/keda/issues/6730))
7778
- **Temporal Scaler**: Fix Temporal Scaler does not work properly with API Key authentication against Temporal Cloud as TLS is not enabled on the client ([#6703](https://github.com/kedacore/keda/issues/6703))
7879

7980
### Deprecations

pkg/scalers/azure_servicebus_scaler.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ type azureServiceBusMetadata struct {
6767
FullyQualifiedNamespace string
6868
UseRegex bool `keda:"name=useRegex, order=triggerMetadata, optional"`
6969
EntityNameRegex *regexp.Regexp
70-
Operation string `keda:"name=operation, order=triggerMetadata, enum=sum;max;avg, optional"`
70+
Operation string `keda:"name=operation, order=triggerMetadata, enum=sum;max;avg, default=sum"`
7171
triggerIndex int
7272
timeout time.Duration
7373
}

pkg/scalers/azure_servicebus_scaler_test.go

+1
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,7 @@ var parseServiceBusMetadataDataset = []parseServiceBusMetadataTestData{
108108
{map[string]string{"queueName": queueName, "connectionFromEnv": connectionSetting, "useRegex": "true", "operation": avgOperation}, false, queue, defaultSuffix, map[string]string{}, ""},
109109
{map[string]string{"queueName": queueName, "connectionFromEnv": connectionSetting, "useRegex": "true", "operation": sumOperation}, false, queue, defaultSuffix, map[string]string{}, ""},
110110
{map[string]string{"queueName": queueName, "connectionFromEnv": connectionSetting, "useRegex": "true", "operation": maxOperation}, false, queue, defaultSuffix, map[string]string{}, ""},
111+
{map[string]string{"queueName": queueName, "connectionFromEnv": connectionSetting, "useRegex": "true"}, false, queue, defaultSuffix, map[string]string{}, ""},
111112
{map[string]string{"queueName": queueName, "connectionFromEnv": connectionSetting, "useRegex": "true", "operation": "random"}, true, queue, defaultSuffix, map[string]string{}, ""},
112113
// queue with invalid regex string
113114
{map[string]string{"queueName": "*", "connectionFromEnv": connectionSetting, "useRegex": "true", "operation": "avg"}, true, queue, defaultSuffix, map[string]string{}, ""},

0 commit comments

Comments
 (0)