Skip to content

Commit 9503900

Browse files
fira42073fira42073
authored
Merge branch 'kedacore:main' into gitlab-runner-scaler
2 parents b650bc3 + 295659d commit 9503900

File tree

411 files changed

+187223
-496
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

411 files changed

+187223
-496
lines changed

‎.devcontainer/Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Licensed under the MIT License. See https://go.microsoft.com/fwlink/?linkid=2090316 for license information.
44
#-------------------------------------------------------------------------------------------------------------
55

6-
FROM golang:1.23.4
6+
FROM golang:1.23.6
77

88
# Avoid warnings by switching to noninteractive
99
ENV DEBIAN_FRONTEND=noninteractive

‎.github/ISSUE_TEMPLATE/3_bug_report.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -76,10 +76,10 @@ body:
7676
label: Kubernetes Version
7777
description: What version of Kubernetes that are you running?
7878
options:
79+
- "1.32"
80+
- "1.31"
7981
- "1.30"
80-
- "1.29"
81-
- "1.28"
82-
- "< 1.28"
82+
- "< 1.29"
8383
- "Other"
8484
validations:
8585
required: false

‎.github/workflows/main-build.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
id-token: write # needed for signing the images with GitHub OIDC Token **not production ready**
1717

1818
# keda-tools is built from github.com/test-tools/tools/Dockerfile
19-
container: ghcr.io/kedacore/keda-tools:1.23.3
19+
container: ghcr.io/kedacore/keda-tools:1.23.6
2020
steps:
2121
- name: Check out code
2222
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
@@ -32,13 +32,13 @@ jobs:
3232
echo "build_cache=$(go env GOCACHE)" >> $GITHUB_OUTPUT
3333
3434
- name: Go modules cache
35-
uses: actions/cache@1bd1e32a3bdc45362d1e726936510720a7c30a57 # v4.2.0
35+
uses: actions/cache@d4323d4df104b026a6aa633fdb11d772146be0bf # v4.2.2
3636
with:
3737
path: ${{ steps.go-paths.outputs.mod_cache }}
3838
key: ${{ runner.os }}-go-mod-${{ hashFiles('**/go.sum') }}
3939

4040
- name: Go build cache
41-
uses: actions/cache@1bd1e32a3bdc45362d1e726936510720a7c30a57 # v4.2.0
41+
uses: actions/cache@d4323d4df104b026a6aa633fdb11d772146be0bf # v4.2.2
4242
with:
4343
path: ${{ steps.go-paths.outputs.build_cache }}
4444
key: ${{ runner.os }}-go-build-cache-${{ hashFiles('**/go.sum') }}

‎.github/workflows/pr-e2e.yml

+4-4
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
triage:
1111
runs-on: ubuntu-latest
1212
name: Comment evaluate
13-
container: ghcr.io/kedacore/keda-tools:1.23.3
13+
container: ghcr.io/kedacore/keda-tools:1.23.6
1414
outputs:
1515
run-e2e: ${{ startsWith(github.event.comment.body,'/run-e2e') && steps.checkUserMember.outputs.isTeamMember == 'true' }}
1616
pr_num: ${{ steps.parser.outputs.pr_num }}
@@ -69,7 +69,7 @@ jobs:
6969
needs: triage
7070
runs-on: ubuntu-latest
7171
name: Build images
72-
container: ghcr.io/kedacore/keda-tools:1.23.3
72+
container: ghcr.io/kedacore/keda-tools:1.23.6
7373
if: needs.triage.outputs.run-e2e == 'true'
7474
steps:
7575
- name: Set status in-progress
@@ -149,7 +149,7 @@ jobs:
149149
needs: [triage, build-test-images]
150150
runs-on: e2e
151151
name: Execute e2e tests
152-
container: ghcr.io/kedacore/keda-tools:1.23.3
152+
container: ghcr.io/kedacore/keda-tools:1.23.6
153153
if: needs.triage.outputs.run-e2e == 'true'
154154
steps:
155155
- name: Set status in-progress
@@ -255,7 +255,7 @@ jobs:
255255
details_url: https://github.com/${{github.repository}}/actions/runs/${{github.run_id}}
256256

257257
- name: Upload test logs
258-
uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4
258+
uses: actions/upload-artifact@4cec3d8aa04e39d1a68397de0c4cd6fb9dce8ec1 # v4
259259
with:
260260
name: e2e-test-logs
261261
path: "${{ github.workspace }}/**/*.log"

‎.github/workflows/pr-validation.yml

+6-8
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
validate:
1111
name: validate - ${{ matrix.name }}
1212
runs-on: ${{ matrix.runner }}
13-
container: ghcr.io/kedacore/keda-tools:1.23.3
13+
container: ghcr.io/kedacore/keda-tools:1.23.6
1414
strategy:
1515
matrix:
1616
include:
@@ -42,13 +42,13 @@ jobs:
4242
echo "build_cache=$(go env GOCACHE)" >> $GITHUB_OUTPUT
4343
4444
- name: Go modules cache
45-
uses: actions/cache@1bd1e32a3bdc45362d1e726936510720a7c30a57 # v4.2.0
45+
uses: actions/cache@d4323d4df104b026a6aa633fdb11d772146be0bf # v4.2.2
4646
with:
4747
path: ${{ steps.go-paths.outputs.mod_cache }}
4848
key: ${{ runner.os }}-go-mod-${{ hashFiles('**/go.sum') }}
4949

5050
- name: Go build cache
51-
uses: actions/cache@1bd1e32a3bdc45362d1e726936510720a7c30a57 # v4.2.0
51+
uses: actions/cache@d4323d4df104b026a6aa633fdb11d772146be0bf # v4.2.2
5252
with:
5353
path: ${{ steps.go-paths.outputs.build_cache }}
5454
key: ${{ runner.os }}-go-build-cache-${{ hashFiles('**/go.sum') }}
@@ -80,7 +80,7 @@ jobs:
8080
pull-requests: read # for dorny/paths-filter to read pull requests
8181
name: validate-dockerfiles - ${{ matrix.name }}
8282
runs-on: ${{ matrix.runner }}
83-
container: ghcr.io/kedacore/keda-tools:1.23.3
83+
container: ghcr.io/kedacore/keda-tools:1.23.6
8484
strategy:
8585
matrix:
8686
include:
@@ -114,7 +114,7 @@ jobs:
114114
pull-requests: read # for dorny/paths-filter to read pull requests
115115
name: Validate dev-container - ${{ matrix.name }}
116116
runs-on: ${{ matrix.runner }}
117-
container: ghcr.io/kedacore/keda-tools:1.23.3
117+
container: ghcr.io/kedacore/keda-tools:1.23.6
118118
strategy:
119119
matrix:
120120
include:
@@ -144,14 +144,12 @@ jobs:
144144
runs-on: ubuntu-latest
145145
steps:
146146
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
147-
- uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0
147+
- uses: actions/setup-python@42375524e23c412d93fb67b49958b491fce71c38 # v5.4.0
148148
with:
149149
python-version: 3.x
150150
- uses: actions/setup-go@f111f3307d8850f501ac008e886eec1fd1932a34 # v5
151151
with:
152152
go-version: "1.23"
153-
- name: Get golangci
154-
run: curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.61.0
155153
- uses: pre-commit/action@2c7b3805fd2a0fd8c1884dcaebf91fc102a13ecd # v3.0.1
156154

157155
trivy-scan:

‎.github/workflows/release-build.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
id-token: write # needed for signing the images with GitHub OIDC Token **not production ready**
1818

1919
# keda-tools is built from github.com/test-tools/tools/Dockerfile
20-
container: ghcr.io/kedacore/keda-tools:1.23.3
20+
container: ghcr.io/kedacore/keda-tools:1.23.6
2121
steps:
2222
- name: Check out code
2323
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
@@ -33,13 +33,13 @@ jobs:
3333
echo "build_cache=$(go env GOCACHE)" >> $GITHUB_OUTPUT
3434
3535
- name: Go modules cache
36-
uses: actions/cache@1bd1e32a3bdc45362d1e726936510720a7c30a57 # v4.2.0
36+
uses: actions/cache@d4323d4df104b026a6aa633fdb11d772146be0bf # v4.2.2
3737
with:
3838
path: ${{ steps.go-paths.outputs.mod_cache }}
3939
key: ${{ runner.os }}-go-mod-${{ hashFiles('**/go.sum') }}
4040

4141
- name: Go build cache
42-
uses: actions/cache@1bd1e32a3bdc45362d1e726936510720a7c30a57 # v4.2.0
42+
uses: actions/cache@d4323d4df104b026a6aa633fdb11d772146be0bf # v4.2.2
4343
with:
4444
path: ${{ steps.go-paths.outputs.build_cache }}
4545
key: ${{ runner.os }}-go-build-cache-${{ hashFiles('**/go.sum') }}

‎.github/workflows/scorecards.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ jobs:
5555
# Upload the results as artifacts (optional). Commenting out will disable uploads of run results in SARIF
5656
# format to the repository Actions tab.
5757
- name: "Upload artifact"
58-
uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4.pre.node20
58+
uses: actions/upload-artifact@4cec3d8aa04e39d1a68397de0c4cd6fb9dce8ec1 # v4.pre.node20
5959
with:
6060
name: SARIF file
6161
path: results.sarif

‎.github/workflows/static-analysis-codeql.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
codeQl:
1818
name: Analyze CodeQL Go
1919
runs-on: ubuntu-latest
20-
container: ghcr.io/kedacore/keda-tools:1.23.3
20+
container: ghcr.io/kedacore/keda-tools:1.23.6
2121
if: (github.actor != 'dependabot[bot]')
2222
steps:
2323
- name: Checkout repository

‎.github/workflows/template-arm64-smoke-tests.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,5 @@ jobs:
1010
uses: kedacore/keda/.github/workflows/template-smoke-tests.yml@main
1111
with:
1212
runs-on: ARM64
13-
kubernetesVersion: v1.30
14-
kindImage: kindest/node:v1.30.0@sha256:047357ac0cfea04663786a612ba1eaba9702bef25227a794b52890dd8bcd692e
13+
kubernetesVersion: v1.32
14+
kindImage: kindest/node:v1.32.0@sha256:c48c62eac5da28cdadcf560d1d8616cfa6783b58f0d94cf63ad1bf49600cb027

‎.github/workflows/template-main-e2e-test.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ jobs:
88
name: Run e2e test
99
runs-on: ARM64
1010
# keda-tools is built from github.com/test-tools/tools/Dockerfile
11-
container: ghcr.io/kedacore/keda-tools:1.23.3
11+
container: ghcr.io/kedacore/keda-tools:1.23.6
1212
concurrency: e2e-tests
1313
steps:
1414
- name: Check out code
@@ -47,7 +47,7 @@ jobs:
4747
NODE_POOL_SIZE: 1
4848

4949
- name: Upload test logs
50-
uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4
50+
uses: actions/upload-artifact@4cec3d8aa04e39d1a68397de0c4cd6fb9dce8ec1 # v4
5151
if: ${{ always() }}
5252
with:
5353
name: e2e-test-logs

‎.github/workflows/template-smoke-tests.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ jobs:
4545
run: make smoke-test
4646

4747
- name: Upload test logs
48-
uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4
48+
uses: actions/upload-artifact@4cec3d8aa04e39d1a68397de0c4cd6fb9dce8ec1 # v4
4949
if: ${{ always() }}
5050
with:
5151
name: smoke-test-logs ${{ inputs.runs-on }}-${{ inputs.kubernetesVersion }}

‎.github/workflows/template-versions-smoke-tests.yml

+6-6
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,14 @@ jobs:
99
strategy:
1010
fail-fast: false
1111
matrix:
12-
kubernetesVersion: [v1.30, v1.29, v1.28]
12+
kubernetesVersion: [v1.32, v1.31, v1.30]
1313
include:
14+
- kubernetesVersion: v1.32
15+
kindImage: kindest/node:v1.32.0@sha256:c48c62eac5da28cdadcf560d1d8616cfa6783b58f0d94cf63ad1bf49600cb027
16+
- kubernetesVersion: v1.31
17+
kindImage: kindest/node:v1.31.4@sha256:2cb39f7295fe7eafee0842b1052a599a4fb0f8bcf3f83d96c7f4864c357c6c30
1418
- kubernetesVersion: v1.30
15-
kindImage: kindest/node:v1.30.0@sha256:047357ac0cfea04663786a612ba1eaba9702bef25227a794b52890dd8bcd692e
16-
- kubernetesVersion: v1.29
17-
kindImage: kindest/node:v1.29.4@sha256:3abb816a5b1061fb15c6e9e60856ec40d56b7b52bcea5f5f1350bc6e2320b6f8
18-
- kubernetesVersion: v1.28
19-
kindImage: kindest/node:v1.28.9@sha256:dca54bc6a6079dd34699d53d7d4ffa2e853e46a20cd12d619a09207e35300bd0
19+
kindImage: kindest/node:v1.30.8@sha256:17cd608b3971338d9180b00776cb766c50d0a0b6b904ab4ff52fd3fc5c6369bf
2020
uses: kedacore/keda/.github/workflows/template-smoke-tests.yml@main
2121
with:
2222
runs-on: ubuntu-latest

‎.github/workflows/v1-build.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
fetch-depth: 1
2020

2121
- name: Go modules cache
22-
uses: actions/cache@1bd1e32a3bdc45362d1e726936510720a7c30a57 # v4.2.0
22+
uses: actions/cache@d4323d4df104b026a6aa633fdb11d772146be0bf # v4.2.2
2323
with:
2424
path: /go/pkg
2525
key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}

‎.golangci.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ linters:
2727
- unconvert
2828
- ineffassign
2929
- staticcheck
30-
- exportloopref
30+
- copyloopvar
3131
- depguard
3232
- dogsled
3333
- errcheck

‎.pre-commit-config.yaml

+2-3
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,7 @@ repos:
4444
entry: "bash hack/validate-changelog.sh"
4545
pass_filenames: false
4646
- id: golangci-lint
47-
language: golang
47+
language: system
4848
name: Run golangci against the code
49-
entry: golangci-lint run
50-
types: [go]
49+
entry: make golangci
5150
pass_filenames: false

‎CHANGELOG.md

+17
Original file line numberDiff line numberDiff line change
@@ -57,12 +57,18 @@ To learn more about active deprecations, we recommend checking [GitHub Discussio
5757

5858
## Unreleased
5959

60+
- **General**: Fix the check whether Fallback is enabled when using ScalingModifiers ([#6521](https://github.com/kedacore/keda/pull/6521))
61+
- **General**: Fix waiting to reach `failureThreshold` before fallback ([#6520](https://github.com/kedacore/keda/pull/6520))
62+
- **General**: Introduce new Temporal scaler ([#4724](https://github.com/kedacore/keda/issues/4724))
63+
6064
### New
6165

66+
- **General**: Add Fallback option `behavior` for dynamic fallback calculation ([#6450](https://github.com/kedacore/keda/issues/6450))
6267
- **General**: Enable OpenSSF Scorecard to enhance security practices across the project ([#5913](https://github.com/kedacore/keda/issues/5913))
6368
- **General**: Introduce new GitLab Runner Scaler. ([#5616](https://github.com/kedacore/keda/issues/5616))
6469
- **General**: Introduce new NSQ scaler ([#3281](https://github.com/kedacore/keda/issues/3281))
6570
- **General**: Operator flag to control patching of webhook resources certificates ([#6184](https://github.com/kedacore/keda/issues/6184))
71+
- **Azure Pipelines Scaler**: Introduce requireAllDemandsAndIgnoreOthers to match job demands while ignoring extras ([#5579](https://github.com/kedacore/keda/issues/5579))
6672

6773
#### Experimental
6874

@@ -72,11 +78,19 @@ Here is an overview of all new **experimental** features:
7278

7379
### Improvements
7480

81+
- **General**: Add SecretKey to AWS SecretsManager TriggerAuthentication to allow parsing JSON / Key/Value Pairs in secrets ([#5940](https://github.com/kedacore/keda/issues/5940))
82+
- **GitHub Scaler**: Add support to use ETag for conditional requests against the Github API ([#6503](https://github.com/kedacore/keda/issues/6503))
83+
- **GitHub Scaler**: Filter workflows via query parameter for improved queue count accuracy ([#6519](https://github.com/kedacore/keda/pull/6519))
7584
- **IBMMQ Scaler**: Handling StatusNotFound in IBMMQ scaler ([#6472](https://github.com/kedacore/keda/pull/6472))
85+
- **RabbitMQ Scaler**: Support use of the ‘vhostName’ parameter in the ‘TriggerAuthentication’ resource ([#6369](https://github.com/kedacore/keda/issues/6369))
86+
- **Selenium Grid**: Add trigger param to set custom capabilities for matching specific Nodes ([#6536](https://github.com/kedacore/keda/issues/6536))
7687

7788
### Fixes
7889

90+
- **General**: Centralize and improve automaxprocs configuration with proper structured logging ([#5970](https://github.com/kedacore/keda/issues/5970))
7991
- **General**: Fix event text when deactivation fails ([#6469](https://github.com/kedacore/keda/issues/6469))
92+
- **General**: Paused ScaledObject count is reported correctly after operator restart ([#6321](https://github.com/kedacore/keda/issues/6321))
93+
- **General**: ScaledJobs ready status set to true when recoverred problem ([#6329](https://github.com/kedacore/keda/pull/6329))
8094
- **AWS Scalers**: Add AWS region to the AWS Config Cache key ([#6128](https://github.com/kedacore/keda/issues/6128))
8195
- **Redis Streams**: Allow default value of 0 for activationLagCount ([#6478](https://github.com/kedacore/keda/issues/6478))
8296
- **Selenium Grid**: Scaler logic on platformName is set empty or `any` ([#6477](https://github.com/kedacore/keda/issues/6477))
@@ -97,7 +111,10 @@ New deprecation(s):
97111

98112
### Other
99113

114+
- **General**: Add debug logs tracking validation of ScaledObjects on webhook ([#6498](https://github.com/kedacore/keda/pull/6498))
115+
- **General**: Fix fallback validation check bug ([#6407](https://github.com/kedacore/keda/pull/6407))
100116
- **General**: New eventreason KEDAScalersInfo to display important information ([#6328](https://github.com/kedacore/keda/issues/6328))
117+
- **External Scalers**: Allow `float64` values in externalmetrics' `MetricValue` & `TargetSize`. The old fields are still there because of backward compatibility. ([#5159](https://github.com/kedacore/keda/issues/5159))
101118

102119
## v2.16.1
103120

‎CONTRIBUTING.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ For more installation options visit the [pre-commits](https://pre-commit.com).
164164

165165
Before running pre-commit, you must install the [golangci-lint](https://golangci-lint.run/) tool as a static check tool for golang code (contains a series of linter)
166166
```shell script
167-
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.59.1
167+
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.63.4
168168
# or
169169
brew install golangci/tap/golangci-lint
170170
```

‎Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Build the manager binary
2-
FROM --platform=$BUILDPLATFORM ghcr.io/kedacore/keda-tools:1.23.4 AS builder
2+
FROM --platform=$BUILDPLATFORM ghcr.io/kedacore/keda-tools:1.23.6 AS builder
33

44
ARG BUILD_VERSION=main
55
ARG GIT_COMMIT=HEAD

‎Dockerfile.adapter

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Build the adapter binary
2-
FROM --platform=$BUILDPLATFORM ghcr.io/kedacore/keda-tools:1.23.4 AS builder
2+
FROM --platform=$BUILDPLATFORM ghcr.io/kedacore/keda-tools:1.23.6 AS builder
33

44
ARG BUILD_VERSION=main
55
ARG GIT_COMMIT=HEAD

‎Dockerfile.webhooks

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Build the manager binary
2-
FROM --platform=$BUILDPLATFORM ghcr.io/kedacore/keda-tools:1.23.4 AS builder
2+
FROM --platform=$BUILDPLATFORM ghcr.io/kedacore/keda-tools:1.23.6 AS builder
33

44
ARG BUILD_VERSION=main
55
ARG GIT_COMMIT=HEAD

‎Makefile

+10-1
Original file line numberDiff line numberDiff line change
@@ -46,13 +46,17 @@ else
4646
GOBIN=$(shell go env GOBIN)
4747
endif
4848

49+
GOPATH:=$(shell go env GOPATH)
50+
4951
GO_BUILD_VARS= GO111MODULE=on CGO_ENABLED=$(CGO) GOOS=$(TARGET_OS) GOARCH=$(ARCH)
5052
GO_LDFLAGS="-X=github.com/kedacore/keda/v2/version.GitCommit=$(GIT_COMMIT) -X=github.com/kedacore/keda/v2/version.Version=$(VERSION)"
5153

5254
COSIGN_FLAGS ?= -y -a GIT_HASH=${GIT_COMMIT} -a GIT_VERSION=${VERSION} -a BUILD_DATE=${DATE}
5355

5456
# ENVTEST_K8S_VERSION refers to the version of kubebuilder assets to be downloaded by envtest binary.
55-
ENVTEST_K8S_VERSION = 1.31
57+
ENVTEST_K8S_VERSION = 1.32
58+
59+
GOLANGCI_VERSION:=1.63.4
5660

5761
# Setting SHELL to bash allows bash commands to be executed by recipes.
5862
# This is a requirement for 'setup-envtest.sh' in the test target.
@@ -146,7 +150,12 @@ fmt: ## Run go fmt against code.
146150
vet: ## Run go vet against code.
147151
go vet ./...
148152

153+
HAS_GOLANGCI_VERSION:=$(shell $(GOPATH)/bin/golangci-lint version --format=short)
154+
.PHONY: golangci
149155
golangci: ## Run golangci against code.
156+
ifneq ($(HAS_GOLANGCI_VERSION), $(GOLANGCI_VERSION))
157+
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(GOPATH)/bin v$(GOLANGCI_VERSION)
158+
endif
150159
golangci-lint run
151160

152161
verify-manifests: ## Verify manifests are up to date.

‎ROADMAP.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ Here is an overview of our current release estimations:
1414

1515
| Version | Estimated Release Date |
1616
|:--------|:-----------------------------------------------------|
17-
| v2.17 | Jan 30th, 2025 |
17+
| v2.17 | Feb 19th, 2025 |
1818
| v2.18 | Apr 30th, 2025 |
1919
| v2.19 | July 30th, 2025 |
2020

‎apis/keda/v1alpha1/scaledjob_types_test.go

-1
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@ func TestScaledJob(t *testing.T) {
7373
}
7474

7575
for _, test := range tests {
76-
test := test
7776
t.Run(test.name, func(t *testing.T) {
7877
scaledJob := &ScaledJob{
7978
Spec: ScaledJobSpec{

0 commit comments

Comments
 (0)