(feat): pre-commit changes + add tests

Signed-off-by: mittalvaibhav1 <[email protected]>

Author: mittalvaibhav1

pkg/scalers/sumologic/metrics.go

@@ -64,9 +64,9 @@ func (c *Client) createMetricsQuery(query string, quantization time.Duration, fr
 
 func (c *Client) createMultiMetricsQuery(queries map[string]string, quantization time.Duration, from, to, rollup string) ([]byte, error) {
 	metricsQueries := make([]MetricsQuery, 0)
-	for rowId, query := range queries {
+	for rowID, query := range queries {
 		metricsQuery := MetricsQuery{
-			RowID:        rowId,
+			RowID:        rowID,
 			Query:        query,
 			Quantization: int64(quantization / time.Millisecond),
 			Rollup:       rollup,

pkg/scalers/sumologic/sumologic.go

@@ -233,7 +233,7 @@ func (c *Client) GetMetricsSearchResult(
 
 func (c *Client) GetMultiMetricsSearchResult(
 	queries map[string]string,
-	resultQueryRowId string,
+	resultQueryRowID string,
 	quantization time.Duration,
 	rollup string,
 	timerange time.Duration,
@@ -262,14 +262,14 @@ func (c *Client) GetMultiMetricsSearchResult(
 	var selectedResultSet QueryResult
 
 	for _, queryResult := range parsedResp.QueryResult {
-		if queryResult.RowID == resultQueryRowId {
+		if queryResult.RowID == resultQueryRowID {
 			selectedResultSet = queryResult
 			break
 		}
 	}
 
 	if selectedResultSet.RowID == "" {
-		return nil, fmt.Errorf("no query result with matching resultQueryRowId %s found in metrics query response", resultQueryRowId)
+		return nil, fmt.Errorf("no query result with matching resultQueryRowID %s found in metrics query response", resultQueryRowID)
 	}
 
 	if len(selectedResultSet.TimeSeriesList.TimeSeries) == 0 {
@@ -304,7 +304,7 @@ func (c *Client) GetQueryResult(
 	queryType string,
 	query string,
 	queries map[string]string,
-	resultQueryRowId string,
+	resultQueryRowID string,
 	quantization time.Duration,
 	rollup string,
 	resultField string,
@@ -336,15 +336,14 @@ func (c *Client) GetQueryResult(
 		} else {
 			result, err = c.GetMultiMetricsSearchResult(
 				queries,
-				resultQueryRowId,
+				resultQueryRowID,
 				quantization,
 				rollup,
 				timerange,
 				timezone,
 				queryAggregator,
 			)
 		}
-
 	}
 
 	if err != nil {

pkg/scalers/sumologic/sumologic_test.go

@@ -403,7 +403,7 @@ func TestGetMultiMetricsSearchResult(t *testing.T) {
 		name             string
 		config           *Config
 		queries          map[string]string
-		resultQueryRowId string
+		resultQueryRowID string
 		quantization     time.Duration
 		rollup           string
 		timerange        time.Duration
@@ -426,7 +426,7 @@ func TestGetMultiMetricsSearchResult(t *testing.T) {
 				"A": "query1",
 				"B": "query2",
 			},
-			resultQueryRowId: "A",
+			resultQueryRowID: "A",
 			quantization:     1 * time.Minute,
 			rollup:           "Avg",
 			timerange:        10 * time.Minute,
@@ -477,7 +477,7 @@ func TestGetMultiMetricsSearchResult(t *testing.T) {
 				"A": "query1",
 				"B": "query2",
 			},
-			resultQueryRowId: "C",
+			resultQueryRowID: "C",
 			quantization:     1 * time.Minute,
 			rollup:           "Avg",
 			timerange:        10 * time.Minute,
@@ -514,7 +514,7 @@ func TestGetMultiMetricsSearchResult(t *testing.T) {
 			queries: map[string]string{
 				"A": "query1",
 			},
-			resultQueryRowId: "A",
+			resultQueryRowID: "A",
 			quantization:     1 * time.Minute,
 			rollup:           "Avg",
 			timerange:        10 * time.Minute,
@@ -551,7 +551,7 @@ func TestGetMultiMetricsSearchResult(t *testing.T) {
 
 			result, err := client.GetMultiMetricsSearchResult(
 				test.queries,
-				test.resultQueryRowId,
+				test.resultQueryRowID,
 				test.quantization,
 				test.rollup,
 				test.timerange,

pkg/scalers/sumologic_scaler_test.go

@@ -29,7 +29,6 @@ var validSumologicMetadata = map[string]string{
 	"unsafeSsl":           "false",
 	"query":               "fakeQuery",
 	"queryType":           "logs",
-	"dimension":           "fakeDimension",
 	"timerange":           "5",
 	"resultField":         "fakeResultField",
 	"timezone":            "UTC",
@@ -44,7 +43,6 @@ var validSumologicMetricsMetadata = map[string]string{
 	"unsafeSsl":           "false",
 	"query":               "fakeQuery",
 	"queryType":           "metrics",
-	"dimension":           "fakeDimension",
 	"timerange":           "5",
 	"timezone":            "UTC",
 	"quantization":        "1",
@@ -54,11 +52,30 @@ var validSumologicMetricsMetadata = map[string]string{
 	"rollup":              "Sum",
 }
 
+var validSumologicMultiMetricsMetadata = map[string]string{
+	"host":                "https://api.sumologic.com",
+	"unsafeSsl":           "false",
+	"queryType":           "metrics",
+	"timerange":           "5",
+	"timezone":            "UTC",
+	"quantization":        "1",
+	"activationThreshold": "5",
+	"threshold":           "1",
+	"queryAggregator":     "Avg",
+	"rollup":              "Sum",
+	"query.A":             "fakeQueryA",
+	"query.B":             "fakeQueryB",
+	"query.C":             "fakeQueryC",
+	"resultQueryRowId":    "C",
+}
+
 var testSumologicMetadata = []parseSumologicMetadataTestData{
 	// Valid metadata, pass.
 	{validSumologicMetadata, validSumologicAuthParams, false},
 	// Valid metrics metadata with rollup, pass.
 	{validSumologicMetricsMetadata, validSumologicAuthParams, false},
+	// Valid multi-metrics metadata, pass.
+	{validSumologicMultiMetricsMetadata, validSumologicAuthParams, false},
 	// Missing host, fail.
 	{map[string]string{"query": "fakeQuery"}, validSumologicAuthParams, true},
 	// Missing accessID, fail.
@@ -69,8 +86,6 @@ var testSumologicMetadata = []parseSumologicMetadataTestData{
 	{map[string]string{"host": "https://api.sumologic.com", "query": "fakeQuery", "queryType": "invalid"}, validSumologicAuthParams, true},
 	// Missing query, fail.
 	{map[string]string{"host": "https://api.sumologic.com", "queryType": "logs"}, validSumologicAuthParams, true},
-	// Missing query, fail.
-	{map[string]string{"host": "https://api.sumologic.com", "queryType": "metrics"}, validSumologicAuthParams, true},
 	// Missing timerange, fail.
 	{map[string]string{"host": "https://api.sumologic.com", "query": "fakeQuery", "queryType": "logs"}, validSumologicAuthParams, true},
 	// Invalid timerange, fail.
@@ -86,13 +101,14 @@ var testSumologicMetadata = []parseSumologicMetadataTestData{
 var sumologicMetricIdentifiers = []sumologicMetricIdentifier{
 	{&testSumologicMetadata[0], 0, "s0-sumologic-logs"},
 	{&testSumologicMetadata[1], 0, "s0-sumologic-metrics"},
+	{&testSumologicMetadata[2], 0, "s0-sumologic-metrics"},
 }
 
 func TestSumologicParseMetadata(t *testing.T) {
 	for _, testData := range testSumologicMetadata {
 		_, err := parseSumoMetadata(&scalersconfig.ScalerConfig{TriggerMetadata: testData.metadata, AuthParams: testData.authParams})
 		if err != nil && !testData.isError {
-			t.Error("Expected success but got error", err)
+			t.Errorf("Expected success but got error: %v", err)
 		} else if testData.isError && err == nil {
 			t.Error("Expected error but got success")
 		}
@@ -104,7 +120,7 @@ func TestSumologicGetMetricSpecForScaling(t *testing.T) {
 		ctx := context.Background()
 		meta, err := parseSumoMetadata(&scalersconfig.ScalerConfig{TriggerMetadata: testData.metadataTestData.metadata, AuthParams: validSumologicAuthParams, TriggerIndex: testData.triggerIndex})
 		if err != nil {
-			t.Fatal("Could not parse metadata:", err)
+			t.Fatalf("Could not parse metadata: %v", err)
 		}
 		mockSumologicScaler := sumologicScaler{
 			metadata: meta,
@@ -113,7 +129,7 @@ func TestSumologicGetMetricSpecForScaling(t *testing.T) {
 		metricSpec := mockSumologicScaler.GetMetricSpecForScaling(ctx)
 		metricName := metricSpec[0].External.Metric.Name
 		if metricName != testData.name {
-			t.Error("Wrong External metric source name:", metricName)
+			t.Errorf("Wrong External metric source name: got %s, expected %s", metricName, testData.name)
 		}
 	}
 }