From 499624a1cba54576e0657de6a1f056786bf928a7 Mon Sep 17 00:00:00 2001 From: Rick Brouwer Date: Fri, 25 Apr 2025 16:03:20 +0200 Subject: [PATCH] fix: add default Operation in Azure Service Bus scaler Signed-off-by: Rick Brouwer --- CHANGELOG.md | 1 + pkg/scalers/azure_servicebus_scaler.go | 2 +- pkg/scalers/azure_servicebus_scaler_test.go | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1f79ae44723..98fee641cd6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -74,6 +74,7 @@ To learn more about active deprecations, we recommend checking [GitHub Discussio - **General**: Admission Webhook blocks ScaledObject without metricType with fallback ([#6696](https://github.com/kedacore/keda/issues/6696)) - **AWS SQS Queue Scaler**: Fix AWS SQS Queue queueURLFromEnv not working ([#6712](https://github.com/kedacore/keda/issues/6712)) +- **Azure Service Bus scaler**: Fix Azure Service Bus scaler add default Operation ([#6730](https://github.com/kedacore/keda/issues/6730)) ### Deprecations diff --git a/pkg/scalers/azure_servicebus_scaler.go b/pkg/scalers/azure_servicebus_scaler.go index f660196d65d..d16f80e7660 100755 --- a/pkg/scalers/azure_servicebus_scaler.go +++ b/pkg/scalers/azure_servicebus_scaler.go @@ -67,7 +67,7 @@ type azureServiceBusMetadata struct { FullyQualifiedNamespace string UseRegex bool `keda:"name=useRegex, order=triggerMetadata, optional"` EntityNameRegex *regexp.Regexp - Operation string `keda:"name=operation, order=triggerMetadata, enum=sum;max;avg, optional"` + Operation string `keda:"name=operation, order=triggerMetadata, enum=sum;max;avg, default=sum"` triggerIndex int timeout time.Duration } diff --git a/pkg/scalers/azure_servicebus_scaler_test.go b/pkg/scalers/azure_servicebus_scaler_test.go index 56865177622..99e13999e17 100755 --- a/pkg/scalers/azure_servicebus_scaler_test.go +++ b/pkg/scalers/azure_servicebus_scaler_test.go @@ -108,6 +108,7 @@ var parseServiceBusMetadataDataset = []parseServiceBusMetadataTestData{ {map[string]string{"queueName": queueName, "connectionFromEnv": connectionSetting, "useRegex": "true", "operation": avgOperation}, false, queue, defaultSuffix, map[string]string{}, ""}, {map[string]string{"queueName": queueName, "connectionFromEnv": connectionSetting, "useRegex": "true", "operation": sumOperation}, false, queue, defaultSuffix, map[string]string{}, ""}, {map[string]string{"queueName": queueName, "connectionFromEnv": connectionSetting, "useRegex": "true", "operation": maxOperation}, false, queue, defaultSuffix, map[string]string{}, ""}, + {map[string]string{"queueName": queueName, "connectionFromEnv": connectionSetting, "useRegex": "true"}, false, queue, defaultSuffix, map[string]string{}, ""}, {map[string]string{"queueName": queueName, "connectionFromEnv": connectionSetting, "useRegex": "true", "operation": "random"}, true, queue, defaultSuffix, map[string]string{}, ""}, // queue with invalid regex string {map[string]string{"queueName": "*", "connectionFromEnv": connectionSetting, "useRegex": "true", "operation": "avg"}, true, queue, defaultSuffix, map[string]string{}, ""},