Skip to content

Commit 27cd97a

Browse files
Fix delete plugin menu action placement
Make comment clearer.
1 parent 6036e7f commit 27cd97a

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

src/gui/reports/ReportsWidgetBase.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ QMenu* ReportsWidgetBase::customMenuRequestedBase()
143143

144144
// If we are including entries (checked is false) but a group is excluded, ask the user if they
145145
// would like to include the rest of the group as well (or keep it excluded).
146-
// If they exclude it, we need to include the whole group, and then exclude
146+
// If they choose "No", we need to include the whole group, and then exclude
147147
// the entries that aren't selected here.
148148
if (!checked) {
149149
for (const auto index : selected) {

src/gui/reports/ReportsWidgetBrowserStatistics.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,8 @@ void ReportsWidgetBrowserStatistics::customMenuRequested(QPoint pos)
245245
// Create the "delete plugin data" menu item
246246
const auto deletePluginData =
247247
new QAction(icons()->icon("entry-delete"), tr("Delete plugin data from Entry(s)…", "", selected.size()), this);
248-
menu->addAction(deletePluginData);
248+
menu->insertAction(menu->actions().at(3),
249+
deletePluginData); // Index 3 is the one after "Delete Entry" so place "Delete plugin" before it
249250
connect(deletePluginData,
250251
&QAction::triggered,
251252
this,

0 commit comments

Comments
 (0)