Several ui fixes #11967

xboxones1 · 2025-03-31T14:20:35Z

Fixes Background color when setting the shortcut for auto-type #11757
Fixes Irregular alignment of options in Settings - General - tab Autofill #11749
Fix contrast for splitter handle
Fixes Font size is reset after switching theme #11983
Clean up after 6084b69

Screenshots

Testing strategy

Manual

Type of change

✅ Bug fix (non-breaking change that fixes an issue)

droidmonkey · 2025-04-13T12:56:00Z

Can you add the font size reset on theme change fix?

xboxones1 · 2025-04-14T01:53:17Z

@droidmonkey,

keepassxc/src/gui/MainWindow.cpp

Lines 1991 to 1997 in a6e92c9

    
           connect(themeActions, &QActionGroup::triggered, this, [this, theme](QAction* action) { 
        
               config()->set(Config::GUI_ApplicationTheme, action->data()); 
        
               if ((action->data() == "classic" || theme == "classic") && action->data() != theme) { 
        
                   restartApp(tr("You must restart the application to apply this setting. Would you like to restart now?")); 
        
               } else { 
        
                   kpxcApp->applyTheme(); 
        
               }

I think that it can be fixed like this

    connect(themeActions, &QActionGroup::triggered, this, [this, theme](QAction* action) {
        config()->set(Config::GUI_ApplicationTheme, action->data());
        if ((action->data() == "classic" || theme == "classic") && action->data() != theme) {
            restartApp(tr("You must restart the application to apply this setting. Would you like to restart now?"));
        } else {
            kpxcApp->applyTheme();
            kpxcApp->applyFontSize();
        }

Copilot

Pull Request Overview

This PR centralizes UI styling fixes by migrating splitter handle colors into code, refines various widget styles, and ensures dynamic font sizing with theme changes.

Migrate splitter handle styling from dark QSS into BaseStyle code and fix its contrast.
Update error highlighting in ApplicationSettingsWidget to use StateColorPalette, align a settings label, and remove an obsolete tab stop.
Apply font size changes immediately when the theme is toggled in MainWindow.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/gui/styles/dark/darkstyle.qss	Removed `QSplitterHandle` rule as splitter styling is now handled in code
src/gui/styles/base/BaseStyle.cpp	Added `S_splitterHandle` color entry and updated `drawControl` splitter logic
src/gui/dbsettings/DatabaseSettingsWidgetEncryption.ui	Removed `advancedSettingsButton` from the tab order
src/gui/MainWindow.cpp	Invoke `applyFontSize()` after theme application
src/gui/ApplicationSettingsWidgetGeneral.ui	Right-align "Remember last typed entry for:" label
src/gui/ApplicationSettingsWidget.cpp	Replace hardcoded error CSS with `StateColorPalette` for shortcut widget

Comments suppressed due to low confidence (2)

src/gui/styles/dark/darkstyle.qss:32

[nitpick] With splitter styling now in code, consider adding a comment or consolidating other QSS selectors (e.g., QSplitter::handle) to clarify where and how splitter handles are styled.

QSplitterHandle {

src/gui/MainWindow.cpp:1997

[nitpick] Consider adding a unit or integration test to verify that font size changes are applied correctly when the view menu setting is toggled.

kpxcApp->applyFontSize();

Copilot · 2025-05-18T12:56:57Z

src/gui/styles/base/BaseStyle.cpp

-        painter->fillRect(filledRect, swatch.color(S_button_specular));
-        Ph::fillRectOutline(painter, filledRect.adjusted(-1, 0, 1, 0), 1, swatch.color(S_window_divider));
+        painter->fillRect(filledRect, swatch.color(S_splitterHandle));
+        Ph::fillRectOutline(painter, filledRect.adjusted(-1, -1, 1, 1), 1, swatch.color(S_splitterHandle));


Outline is drawn with the same S_splitterHandle color, making the border invisible. Consider using a contrasting color (e.g., S_window_divider) for the outline to improve visibility.

Suggested change

Ph::fillRectOutline(painter, filledRect.adjusted(-1, -1, 1, 1), 1, swatch.color(S_splitterHandle));

Ph::fillRectOutline(painter, filledRect.adjusted(-1, -1, 1, 1), 1, swatch.color(S_window_divider));

Copilot · 2025-05-18T12:56:57Z

src/gui/ApplicationSettingsWidget.cpp

-                m_generalUi->autoTypeShortcutWidget->setStyleSheet("background-color: #FF9696;");
+                StateColorPalette statePalette;
+                auto color = statePalette.color(StateColorPalette::ColorRole::Error);
+                m_generalUi->autoTypeShortcutWidget->setStyleSheet(QString("QLineEdit { background: %1; }").arg(color.name()));


[nitpick] Use the background-color property in the style sheet rather than the background shorthand for clarity, e.g., QLineEdit { background-color: %1; }.

Suggested change

m_generalUi->autoTypeShortcutWidget->setStyleSheet(QString("QLineEdit { background: %1; }").arg(color.name()));

m_generalUi->autoTypeShortcutWidget->setStyleSheet(QString("QLineEdit { background-color: %1; }").arg(color.name()));

xboxones1 added 2 commits March 31, 2025 13:47

Fix background color error for invalid autotype shortcut

9a47616

Fix alignment in autotype settings

9c75a8c

xboxones1 changed the title ~~Fix background color error for invalid autotype shortcut~~ Several ui fixes Apr 13, 2025

xboxones1 added 3 commits May 15, 2025 08:06

Fix contrast for splitter handle

5b43020

Fix font size reset when changing theme

b46670c

Clean up after refactor database settings

7d7476d

xboxones1 force-pushed the fix/color-shortcut-autotype branch from 56ca23e to 7d7476d Compare May 15, 2025 08:07

droidmonkey added this to the v2.7.11 milestone May 18, 2025

droidmonkey added the user interface label May 18, 2025

droidmonkey requested review from droidmonkey and Copilot May 18, 2025 12:55

Copilot AI reviewed May 18, 2025

View reviewed changes

Code format

2162b85

droidmonkey mentioned this pull request Jun 24, 2025

Changing language resets font size #12227

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Several ui fixes #11967

Several ui fixes #11967

xboxones1 commented Mar 31, 2025 •

edited

Loading

Uh oh!

droidmonkey commented Apr 13, 2025

Uh oh!

xboxones1 commented Apr 14, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI May 18, 2025

Uh oh!

Copilot AI May 18, 2025

Uh oh!

Uh oh!

	Ph::fillRectOutline(painter, filledRect.adjusted(-1, -1, 1, 1), 1, swatch.color(S_splitterHandle));
	Ph::fillRectOutline(painter, filledRect.adjusted(-1, -1, 1, 1), 1, swatch.color(S_window_divider));

	m_generalUi->autoTypeShortcutWidget->setStyleSheet(QString("QLineEdit { background: %1; }").arg(color.name()));
	m_generalUi->autoTypeShortcutWidget->setStyleSheet(QString("QLineEdit { background-color: %1; }").arg(color.name()));

Uh oh!

Several ui fixes #11967

Are you sure you want to change the base?

Several ui fixes #11967

Conversation

xboxones1 commented Mar 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Screenshots

Testing strategy

Type of change

Uh oh!

droidmonkey commented Apr 13, 2025

Uh oh!

xboxones1 commented Apr 14, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI May 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

xboxones1 commented Mar 31, 2025 •

edited

Loading