Skip to content

Several ui fixes #11967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

xboxones1
Copy link
Contributor

@xboxones1 xboxones1 commented Mar 31, 2025

  1. Fixes Background color when setting the shortcut for auto-type #11757
  2. Fixes Irregular alignment of options in Settings - General - tab Autofill #11749
  3. Fix contrast for splitter handle
  4. Fixes Font size is reset after switching theme #11983
  5. Clean up after 6084b69

Screenshots

1
2
3
1
2

Testing strategy

Manual

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@xboxones1 xboxones1 changed the title Fix background color error for invalid autotype shortcut Several ui fixes Apr 13, 2025
@droidmonkey
Copy link
Member

Can you add the font size reset on theme change fix?

@xboxones1
Copy link
Contributor Author

@droidmonkey,

connect(themeActions, &QActionGroup::triggered, this, [this, theme](QAction* action) {
config()->set(Config::GUI_ApplicationTheme, action->data());
if ((action->data() == "classic" || theme == "classic") && action->data() != theme) {
restartApp(tr("You must restart the application to apply this setting. Would you like to restart now?"));
} else {
kpxcApp->applyTheme();
}

I think that it can be fixed like this

    connect(themeActions, &QActionGroup::triggered, this, [this, theme](QAction* action) {
        config()->set(Config::GUI_ApplicationTheme, action->data());
        if ((action->data() == "classic" || theme == "classic") && action->data() != theme) {
            restartApp(tr("You must restart the application to apply this setting. Would you like to restart now?"));
        } else {
            kpxcApp->applyTheme();
            kpxcApp->applyFontSize();
        }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants