Don't pre-select hardware key slot when adding/changing database security

[mpas97]

Have you searched for an existing issue?

• Yes, I tried searching and reviewed the pinned issues

Brief Summary

The challenge response dropdown setting does not preselect the currently configured slot, insead it takes the first (?) one. So without touching the dropdown in settings, you will end up with a different slot, if you initially had eg. slot 2 configured. This should be doable, especially as the exact slot is known for saving and remembered for the unlock dialog.

Steps to Reproduce

1. Have a DB with challenge response set up (slot 2)
2. open database settings -> security -> show challenge response dropdown (where slot 1 is preselected)
3. click OK (without having done any modification: shown dropdown was not touched)
4. see that you now need slot 1 instead of 2 to unlock DB

Expected Versus Actual Behavior

If slot 2 was used, preselect 2. Clicking OK does not change anything.

KeePassXC Debug Information

2.7.10

Operating System

macOS

Linux Desktop Environment

None

Linux Windowing System

None

[droidmonkey]

But if you are in database security and changing (or adding) hardware key then you are telling us you WANT to change it. Otherwise don't click to change or add hardware key.

[mpas97]

To be honest, I just wanted to check which slot is actually configured for use. That's why I went to DB settings. As this is something I setup years ago and I coud not remember if it was 1 or 2. This is how you would probably do for any other setting, you want to check. But after the "lookup" I failed to unlock again, until I figured out that I have to change to an other slot in the unlock form, which until today worked without modification (as hardware key/slot is remembered).

I get your point, but a change typically involves a user action / decision. If I want I new passphrase, let me choose it, not just set a new one because I mentioned the intention to maybe do so.

To make it consistent with the password and keyfile fields above, leave it empty (also if they have been set previously). Leaving eg. the keyfile empty, throws then an error until you set one again or press the cancel button. That makes it friendly and expected, it also does not regenerate a keyfile directly. You have to manually start the process.

[droidmonkey]

Ok I agree, a better option is to not choose anything by default so the user has to choose or cancel.