Skip to content

Inaccurate taint flag documentation #73

Open
@luisdavim

Description

@luisdavim

Is this a BUG REPORT or FEATURE REQUEST?:

Bug report

What happened:

The documentation on --reap-tainted doesn't seem to be correct

What you expected to happen:

The documentation should be accurate

How to reproduce it (as minimally and precisely as possible):

the documentation says:

"marks nodes with a given taint reapable, must be in format of comma separated taints key=value:effect, key:effect or key"

But this flag seems to be using StringArrayVar that means we need to pass the flag multiple times instead of a comma separated string, see: https://pkg.go.dev/github.com/spf13/pflag#StringArrayVar

StringArrayVar defines a string flag with specified name, default value, and usage string. The argument p points to a []string variable in which to store the value of the flag. The value of each argument will not try to be separated by comma. Use a StringSlice for that.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions