Skip to content

Commit 4a42f1c

Browse files
committed
Fix CI Node 20/22 floors to match vite/rolldown's actual requirement
vitest 4 pulls in vite 8, which bundles rolldown and requires Node ^20.19.0 || >=22.12.0. The prior 20.15.1 test lane was below that floor, so npm skipped installing rolldown's native binding in CI (the underlying cause was the Node version, not a lockfile bug). Align engines and the CI matrix to the versions vitest actually needs.
1 parent a06ea3f commit 4a42f1c

4 files changed

Lines changed: 17 additions & 16 deletions

File tree

.github/workflows/ci.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
strategy:
1313
matrix:
1414
# Every Node version this plugin's engines field supports.
15-
node-version: [18.20.4, 20.15.1, 22, 24]
15+
node-version: [18.20.4, 20.19.0, 22.12.0, 24]
1616
steps:
1717
- uses: actions/checkout@v4
1818

@@ -29,9 +29,10 @@ jobs:
2929
runs-on: ubuntu-latest
3030
strategy:
3131
matrix:
32-
# vitest 4 requires Node >=20, so unit tests skip the Node 18 lane;
33-
# the build job above still verifies the plugin compiles there.
34-
node-version: [20.15.1, 22, 24]
32+
# vitest 4 (via vite/rolldown) requires Node >=20.19 / >=22.12, so
33+
# unit tests skip the Node 18 lane; the build job above still
34+
# verifies the plugin compiles there.
35+
node-version: [20.19.0, 22.12.0, 24]
3536
steps:
3637
- uses: actions/checkout@v4
3738

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ A [Homebridge](https://homebridge.io) plugin that brings [June](https://juneoven
2626
## Requirements
2727

2828
- Homebridge `>=1.8.0`
29-
- Node.js `18.20.4+`, `20.15.1+`, `22+`, or `24+`
29+
- Node.js `18.20.4+`, `20.19.0+`, `22.12.0+`, or `24+`
3030
- A June oven on the same June account you'll pair with
3131

3232
## Install

package-lock.json

Lines changed: 10 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
"homekit"
3232
],
3333
"engines": {
34-
"node": "^18.20.4 || ^20.15.1 || ^22 || ^24",
34+
"node": "^18.20.4 || ^20.19.0 || ^22.12.0 || ^24",
3535
"homebridge": ">=1.8.0"
3636
},
3737
"scripts": {

0 commit comments

Comments
 (0)