Skip to content

Commit 96eeb4d

Browse files
committed
fix shortcut key not working while viewing PDF
1 parent 2bd29a8 commit 96eeb4d

File tree

2 files changed

+24
-7
lines changed

2 files changed

+24
-7
lines changed

js/events.js

Lines changed: 24 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -278,9 +278,30 @@ function seek(n) {
278278

279279
function handleError(err) {
280280
if (err) {
281-
var code = /^{/.test(err.message) ? JSON.parse(err.message).code : err.message;
282-
if (code == "error_payment_required") clearSettings(["voiceName"]);
283-
reportError(err);
281+
if (/^{/.test(err.message)) {
282+
const errInfo = JSON.parse(err.message)
283+
switch (errInfo.code) {
284+
case "error_payment_required":
285+
clearSettings(["voiceName"])
286+
break
287+
case "error_upload_pdf":
288+
setTabUrl(errInfo.tabId, config.pdfViewerUrl)
289+
break
290+
case "error_file_access":
291+
case "error_add_permissions":
292+
case "error_page_unreadable":
293+
case "error_login_required":
294+
case "error_wavenet_auth_required":
295+
case "error_chatgpt":
296+
//dont report
297+
break
298+
default:
299+
reportError(err)
300+
}
301+
}
302+
else {
303+
reportError(err);
304+
}
284305
}
285306
}
286307

js/popup.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -145,10 +145,6 @@ function handleError(err) {
145145
break
146146
}
147147
})
148-
149-
if (errInfo.code == "error_upload_pdf") {
150-
setTabUrl(errInfo.tabId, config.pdfViewerUrl)
151-
}
152148
}
153149
else {
154150
$("#status").text(err.message).show();

0 commit comments

Comments
 (0)