test: keep fixture setup outside watch deadlines (#1287)

Windows CI could intermittently fail the push-watch lifecycle test before the local PostgreSQL watch owner began. The one-second coordination deadline also covered local SQLite creation and migrations, so runner load could be misclassified as a watch failure.

Prepare the local owner fixtures before launching the timed goroutines. This keeps the deadline strict for the coordination behavior under test while excluding unrelated fixture setup; production watch behavior is unchanged.

Co-authored-by: Wes McKinney <wesm@users.noreply.github.com>

Author: wesm

cmd/agentsview/archive_write_backend_test.go

@@ -333,6 +333,10 @@ type pushWatchOwnerCase struct {
 
 func pushWatchOwnerCases(t *testing.T) []pushWatchOwnerCase {
 	t.Helper()
+	// Keep SQLite setup outside the timed owner goroutines so channel deadlines
+	// measure watch coordination rather than fixture creation on slow runners.
+	localDuckDB := testLocalArchiveWriteBackend(t)
+	localPostgreSQL := testLocalArchiveWriteBackend(t)
 	return []pushWatchOwnerCase{
 		{
 			name: "daemon DuckDB",
@@ -355,9 +359,8 @@ func pushWatchOwnerCases(t *testing.T) []pushWatchOwnerCase {
 		{
 			name: "local DuckDB",
 			run: func(ctx context.Context, hooks *archivePushWatchHooks) error {
-				backend := testLocalArchiveWriteBackend(t)
-				backend.watchHooks = hooks
-				return backend.DuckDBPushWatch(
+				localDuckDB.watchHooks = hooks
+				return localDuckDB.DuckDBPushWatch(
 					ctx, config.DuckDBConfig{}, DuckDBPushConfig{}, nil, nil,
 					time.Hour, time.Hour,
 				)
@@ -366,9 +369,8 @@ func pushWatchOwnerCases(t *testing.T) []pushWatchOwnerCase {
 		{
 			name: "local PostgreSQL",
 			run: func(ctx context.Context, hooks *archivePushWatchHooks) error {
-				backend := testLocalArchiveWriteBackend(t)
-				backend.watchHooks = hooks
-				return backend.PGPushWatch(
+				localPostgreSQL.watchHooks = hooks
+				return localPostgreSQL.PGPushWatch(
 					ctx, pgTargetSelection{}, PGPushConfig{}, nil, nil,
 					time.Hour, time.Hour,
 				)