fix(parser): validate cowork deleted metadata candidates

Cowork metadata deletion recovery scans project directories after the metadata file is gone, so it cannot rely on the normal metadata-guided resolution path. It still needs the same transcript validity rules as normal discovery: regular files only, and symlink targets must stay inside the local session directory.

Apply that validation before selecting or counting fallback candidates so symlink escapes are ignored and broken symlinks do not create false ambiguity.

Validation: go test -tags "fts5" ./internal/parser -run 'TestCoworkProvider|TestResolveCoworkSessionRejectsSymlinkEscape|TestClassifyCoworkPath|TestParseCowork' -count=1; go test -tags "fts5" ./internal/parser ./internal/sync -count=1; go fmt ./...; go vet ./...; ./custom-gcl run --config .golangci.nilaway.yml ./internal/parser/... ./internal/sync/...; git diff --check

Author: mariusvniekerk

internal/parser/cowork_provider.go

@@ -353,6 +353,10 @@ func coworkTranscriptForMetadataPath(root, path string) (string, bool) {
 		return "", false
 	}
 	sessionDir := strings.TrimSuffix(path, ".json")
+	resolvedSessionDir, err := filepath.EvalSymlinks(sessionDir)
+	if err != nil {
+		return "", false
+	}
 	projectsDir := filepath.Join(sessionDir, ".claude", "projects")
 	entries, err := os.ReadDir(projectsDir)
 	if err != nil {
@@ -377,17 +381,33 @@ func coworkTranscriptForMetadataPath(root, path string) (string, bool) {
 				continue
 			}
 			stem := strings.TrimSuffix(name, ".jsonl")
-			if IsValidSessionID(stem) && !strings.HasPrefix(stem, "agent-") {
-				if found != "" {
-					return "", false
-				}
-				found = filepath.Join(projectDir, name)
+			if !IsValidSessionID(stem) || strings.HasPrefix(stem, "agent-") {
+				continue
+			}
+			candidate := filepath.Join(projectDir, name)
+			if !validCoworkMainTranscriptCandidate(resolvedSessionDir, candidate) {
+				continue
+			}
+			if found != "" {
+				return "", false
 			}
+			found = candidate
 		}
 	}
 	return found, found != ""
 }
 
+func validCoworkMainTranscriptCandidate(resolvedSessionDir, candidate string) bool {
+	if !IsRegularFile(candidate) {
+		return false
+	}
+	resolved, err := filepath.EvalSymlinks(candidate)
+	if err != nil {
+		return false
+	}
+	return isContainedIn(resolved, resolvedSessionDir)
+}
+
 func coworkProviderCapabilities() Capabilities {
 	return Capabilities{
 		Source: SourceCapabilities{

internal/parser/cowork_provider_test.go

@@ -273,6 +273,82 @@ func TestCoworkProviderMetadataRemovalRejectsAmbiguousMainTranscripts(t *testing
 	assert.Empty(t, changed)
 }
 
+func TestCoworkProviderMetadataRemovalIgnoresSymlinkEscape(t *testing.T) {
+	root := t.TempDir()
+	cli := "c0000000-0000-4000-8000-000000000106"
+	metaPath, _ := writeCoworkSession(t, root, coworkFixture{
+		org:             "org",
+		workspace:       "ws",
+		sessionUUID:     "50000000-0000-4000-8000-000000000106",
+		cliSessionID:    cli,
+		encodedProject:  "-sessions-demo",
+		transcriptLines: coworkTranscriptLines(cli),
+	})
+	sessionDir := strings.TrimSuffix(metaPath, ".json")
+	projectsDir := filepath.Join(sessionDir, ".claude", "projects")
+	outside := filepath.Join(root, "outside")
+	require.NoError(t, os.MkdirAll(outside, 0o755))
+	writeSourceFile(
+		t,
+		filepath.Join(outside, "c0000000-0000-4000-8000-000000000107.jsonl"),
+		strings.Join(coworkTranscriptLines("c0000000-0000-4000-8000-000000000107"), "\n")+"\n",
+	)
+	if err := os.Symlink(outside, filepath.Join(projectsDir, "-sessions-escape")); err != nil {
+		t.Skipf("symlink not supported: %v", err)
+	}
+
+	provider, ok := NewProvider(AgentCowork, ProviderConfig{
+		Roots: []string{root},
+	})
+	require.True(t, ok)
+
+	require.NoError(t, os.Remove(metaPath))
+	changed, err := provider.SourcesForChangedPath(
+		context.Background(),
+		ChangedPathRequest{Path: metaPath, EventKind: "remove", WatchRoot: root},
+	)
+	require.NoError(t, err)
+	require.Len(t, changed, 1)
+	assert.Equal(t, cli+".jsonl", filepath.Base(changed[0].DisplayPath))
+}
+
+func TestCoworkProviderMetadataRemovalIgnoresBrokenSymlinkAmbiguity(t *testing.T) {
+	root := t.TempDir()
+	cli := "c0000000-0000-4000-8000-000000000108"
+	metaPath, _ := writeCoworkSession(t, root, coworkFixture{
+		org:             "org",
+		workspace:       "ws",
+		sessionUUID:     "50000000-0000-4000-8000-000000000108",
+		cliSessionID:    cli,
+		encodedProject:  "-sessions-demo",
+		transcriptLines: coworkTranscriptLines(cli),
+	})
+	sessionDir := strings.TrimSuffix(metaPath, ".json")
+	projectsDir := filepath.Join(sessionDir, ".claude", "projects")
+	brokenDir := filepath.Join(projectsDir, "-sessions-broken")
+	require.NoError(t, os.MkdirAll(brokenDir, 0o755))
+	if err := os.Symlink(
+		filepath.Join(root, "missing.jsonl"),
+		filepath.Join(brokenDir, "c0000000-0000-4000-8000-000000000109.jsonl"),
+	); err != nil {
+		t.Skipf("symlink not supported: %v", err)
+	}
+
+	provider, ok := NewProvider(AgentCowork, ProviderConfig{
+		Roots: []string{root},
+	})
+	require.True(t, ok)
+
+	require.NoError(t, os.Remove(metaPath))
+	changed, err := provider.SourcesForChangedPath(
+		context.Background(),
+		ChangedPathRequest{Path: metaPath, EventKind: "remove", WatchRoot: root},
+	)
+	require.NoError(t, err)
+	require.Len(t, changed, 1)
+	assert.Equal(t, cli+".jsonl", filepath.Base(changed[0].DisplayPath))
+}
+
 func TestCoworkProviderFullSessionIDPrefixLookup(t *testing.T) {
 	root := t.TempDir()
 	cli := "c0000000-0000-4000-8000-000000000103"