fix: preserve provider auth env vars in cleanEnv allowlist

Add ANTHROPIC_API_KEY, OPENAI_API_KEY, GEMINI_API_KEY,
GOOGLE_API_KEY, GOOGLE_APPLICATION_CREDENTIALS, GITHUB_TOKEN,
GH_TOKEN, and COPILOT_ prefix to the env allowlist so users
who authenticate via environment variables (including desktop.env)
can generate insights without auth failures.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: wesm

internal/insight/generate.go

@@ -101,8 +101,10 @@ func GenerateStream(
 // safe to pass to agent CLI subprocesses. Matched
 // case-insensitively so Windows-style casing (Path, ComSpec)
 // is handled correctly. Using an allowlist prevents leaking
-// secrets to child processes.
+// arbitrary secrets to child processes while preserving
+// provider auth keys needed by the supported CLIs.
 var allowedKeyPrefixes = []string{
+	// System
 	"PATH",
 	"HOME", "USERPROFILE",
 	"USER", "USERNAME", "LOGNAME",
@@ -116,6 +118,16 @@ var allowedKeyPrefixes = []string{
 	"SYSTEMROOT", "COMSPEC", "PATHEXT", "WINDIR",
 	"HOMEDRIVE", "HOMEPATH",
 	"APPDATA", "LOCALAPPDATA", "PROGRAMDATA",
+
+	// Provider auth (needed by agent CLIs)
+	"ANTHROPIC_API_KEY",
+	"OPENAI_API_KEY",
+	"GEMINI_API_KEY",
+	"GOOGLE_API_KEY",
+	"GOOGLE_APPLICATION_CREDENTIALS",
+	"GITHUB_TOKEN",
+	"GH_TOKEN",
+	"COPILOT_",
 }
 
 // envKeyAllowed reports whether key (case-insensitive) is

internal/insight/generate_test.go

@@ -176,6 +176,12 @@ func TestCollectStreamLines_LargeLine(t *testing.T) {
 
 func TestCleanEnv(t *testing.T) {
 	t.Setenv("ANTHROPIC_API_KEY", "sk-secret")
+	t.Setenv("OPENAI_API_KEY", "sk-openai")
+	t.Setenv("GEMINI_API_KEY", "gemini-key")
+	t.Setenv("GOOGLE_API_KEY", "google-key")
+	t.Setenv("GITHUB_TOKEN", "ghp_token")
+	t.Setenv("GH_TOKEN", "gho_token")
+	t.Setenv("COPILOT_AUTH", "copilot-val")
 	t.Setenv("CLAUDECODE", "1")
 	t.Setenv("HOME", "/home/test")
 	t.Setenv("AWS_SECRET_ACCESS_KEY", "s3cret")
@@ -193,19 +199,22 @@ func TestCleanEnv(t *testing.T) {
 		envMap[strings.ToUpper(k)] = v
 	}
 
-	// Secrets and unknown vars must not pass through.
+	// Unrelated secrets and unknown vars must not pass through.
 	for _, blocked := range []string{
-		"ANTHROPIC_API_KEY", "CLAUDECODE",
+		"CLAUDECODE",
 		"AWS_SECRET_ACCESS_KEY", "UNKNOWN_VAR",
 	} {
 		if _, ok := envMap[blocked]; ok {
 			t.Errorf("%s should not be in env", blocked)
 		}
 	}
 
-	// Allowed system vars must pass through.
+	// System vars and provider auth keys must pass through.
 	for _, allowed := range []string{
 		"HOME", "PATH", "LANG",
+		"ANTHROPIC_API_KEY", "OPENAI_API_KEY",
+		"GEMINI_API_KEY", "GOOGLE_API_KEY",
+		"GITHUB_TOKEN", "GH_TOKEN", "COPILOT_AUTH",
 	} {
 		if _, ok := envMap[allowed]; !ok {
 			t.Errorf("%s should be preserved", allowed)
@@ -244,7 +253,14 @@ func TestEnvKeyAllowed(t *testing.T) {
 		{"WINDIR", true},
 		{"HOMEDRIVE", true},
 		{"HOMEPATH", true},
-		{"ANTHROPIC_API_KEY", false},
+		{"ANTHROPIC_API_KEY", true},
+		{"OPENAI_API_KEY", true},
+		{"GEMINI_API_KEY", true},
+		{"GOOGLE_API_KEY", true},
+		{"GOOGLE_APPLICATION_CREDENTIALS", true},
+		{"GITHUB_TOKEN", true},
+		{"GH_TOKEN", true},
+		{"COPILOT_TOKEN", true}, // prefix match
 		{"AWS_SECRET_ACCESS_KEY", false},
 		{"DATABASE_URL", false},
 		{"", false},