fix(parser): tighten sqlite sidecar classification

Deleted DB sidecar events need to remain classifiable, but basename-only matching is too broad once missing DB parses become complete force-replace outcomes. Unrelated files under the same provider root should not synthesize the canonical shared DB source.

Restrict Zed sidecars to the watched threads directory and Shelley sidecars to the provider root, with regression tests for unrelated matching basenames.

Author: mariusvniekerk

internal/parser/shelley_provider.go

@@ -390,7 +390,8 @@ func shelleyDBPathForEvent(root, path string) (string, bool) {
 		return "", false
 	}
 	if filepath.ToSlash(rel) == shelleyDBName ||
-		strings.HasPrefix(filepath.Base(rel), shelleyDBName+"-") {
+		(filepath.Dir(rel) == "." &&
+			strings.HasPrefix(filepath.Base(rel), shelleyDBName+"-")) {
 		return filepath.Join(root, shelleyDBName), true
 	}
 	return "", false

internal/parser/zed_provider.go

@@ -379,8 +379,10 @@ func zedDBPathForEvent(root, path string) (string, bool) {
 	if !ok {
 		return "", false
 	}
-	if filepath.ToSlash(rel) == "threads/threads.db" ||
-		strings.HasPrefix(filepath.Base(rel), "threads.db-") {
+	relSlash := filepath.ToSlash(rel)
+	if relSlash == "threads/threads.db" ||
+		(filepath.ToSlash(filepath.Dir(rel)) == "threads" &&
+			strings.HasPrefix(filepath.Base(rel), "threads.db-")) {
 		return filepath.Join(root, zedThreadsDBRelPath), true
 	}
 	return "", false

internal/parser/zed_shelley_provider_test.go

@@ -211,6 +211,23 @@ func TestZedProviderClassifiesDeletedPhysicalDB(t *testing.T) {
 	assert.Empty(t, outcome.Results)
 }
 
+func TestZedProviderIgnoresUnrelatedSidecarBasename(t *testing.T) {
+	root := t.TempDir()
+	provider, ok := NewProvider(AgentZed, ProviderConfig{Roots: []string{root}})
+	require.True(t, ok)
+
+	changed, err := provider.SourcesForChangedPath(
+		context.Background(),
+		ChangedPathRequest{
+			Path:      filepath.Join(root, "other", "threads.db-wal"),
+			EventKind: "remove",
+			WatchRoot: filepath.Join(root, "other"),
+		},
+	)
+	require.NoError(t, err)
+	assert.Empty(t, changed)
+}
+
 func TestShelleyProviderFactoryReplacesLegacyAdapter(t *testing.T) {
 	factory, ok := ProviderFactoryByType(AgentShelley)
 	require.True(t, ok)
@@ -419,3 +436,20 @@ func TestShelleyProviderClassifiesDeletedPhysicalDB(t *testing.T) {
 	assert.Equal(t, SkipNoSession, outcome.SkipReason)
 	assert.Empty(t, outcome.Results)
 }
+
+func TestShelleyProviderIgnoresUnrelatedSidecarBasename(t *testing.T) {
+	root := t.TempDir()
+	provider, ok := NewProvider(AgentShelley, ProviderConfig{Roots: []string{root}})
+	require.True(t, ok)
+
+	changed, err := provider.SourcesForChangedPath(
+		context.Background(),
+		ChangedPathRequest{
+			Path:      filepath.Join(root, "nested", shelleyDBName+"-wal"),
+			EventKind: "remove",
+			WatchRoot: filepath.Join(root, "nested"),
+		},
+	)
+	require.NoError(t, err)
+	assert.Empty(t, changed)
+}