|
| 1 | +import { expect, test, type Page, type Response } from "@playwright/test"; |
| 2 | + |
| 3 | +async function openSettledSettings(page: Page) { |
| 4 | + const responses: Response[] = []; |
| 5 | + const settingsLoaded = new Promise<void>((resolve) => { |
| 6 | + const onResponse = (response: Response) => { |
| 7 | + if (new URL(response.url()).pathname !== "/api/v1/settings") return; |
| 8 | + responses.push(response); |
| 9 | + if (responses.length < 2) return; |
| 10 | + page.off("response", onResponse); |
| 11 | + void Promise.all(responses.map((item) => item.finished())).then(() => { |
| 12 | + resolve(); |
| 13 | + }); |
| 14 | + }; |
| 15 | + page.on("response", onResponse); |
| 16 | + }); |
| 17 | + |
| 18 | + await page.goto("/settings"); |
| 19 | + await settingsLoaded; |
| 20 | + await page.evaluate( |
| 21 | + () => new Promise<void>((resolve) => { |
| 22 | + requestAnimationFrame(() => requestAnimationFrame(() => resolve())); |
| 23 | + }), |
| 24 | + ); |
| 25 | + await expect(page.locator(".settings-loading")).toHaveCount(0); |
| 26 | +} |
| 27 | + |
| 28 | +test.describe("Settings layout", () => { |
| 29 | + test("keeps navigation and actions fixed while panel content scrolls", async ({ page }) => { |
| 30 | + await page.setViewportSize({ width: 1280, height: 800 }); |
| 31 | + await page.goto("/settings"); |
| 32 | + |
| 33 | + const nav = page.getByRole("navigation", { name: "Settings" }); |
| 34 | + await expect(nav).toBeVisible(); |
| 35 | + |
| 36 | + const host = page.locator(".settings-page-host"); |
| 37 | + await expect |
| 38 | + .poll(() => host.evaluate((element) => getComputedStyle(element).overflow)) |
| 39 | + .toBe("hidden"); |
| 40 | + await expect |
| 41 | + .poll(() => host.evaluate((element) => element.scrollHeight)) |
| 42 | + .toBe(await host.evaluate((element) => element.clientHeight)); |
| 43 | + |
| 44 | + await nav.locator("button", { hasText: "Agent Directories" }).click(); |
| 45 | + await expect(page.getByRole("heading", { name: "Agent Directories" })).toBeVisible(); |
| 46 | + |
| 47 | + const scroller = page.locator(".kit-settings__scroll"); |
| 48 | + await expect |
| 49 | + .poll(() => scroller.evaluate((element) => element.scrollHeight > element.clientHeight)) |
| 50 | + .toBe(true); |
| 51 | + await scroller.evaluate((element) => { |
| 52 | + element.scrollTop = element.scrollHeight; |
| 53 | + }); |
| 54 | + await expect.poll(() => scroller.evaluate((element) => element.scrollTop)).toBeGreaterThan(0); |
| 55 | + await expect(page.getByRole("button", { name: "Full Resync" })).toBeVisible(); |
| 56 | + |
| 57 | + await nav.locator("button", { hasText: "Terminal" }).click(); |
| 58 | + await expect(page.getByRole("heading", { name: "Terminal" })).toBeVisible(); |
| 59 | + await expect.poll(() => scroller.evaluate((element) => element.scrollTop)).toBe(0); |
| 60 | + }); |
| 61 | + |
| 62 | + test("keeps settings operable at the narrow breakpoint", async ({ page }) => { |
| 63 | + await page.setViewportSize({ width: 700, height: 800 }); |
| 64 | + await page.goto("/settings"); |
| 65 | + |
| 66 | + const search = page.getByRole("searchbox", { name: "Search settings" }); |
| 67 | + await expect(search).toBeVisible(); |
| 68 | + |
| 69 | + const nav = page.getByRole("navigation", { name: "Settings" }); |
| 70 | + await nav.locator("button", { hasText: "Terminal" }).click(); |
| 71 | + await expect(page.getByRole("heading", { name: "Terminal" })).toBeVisible(); |
| 72 | + await expect(page.getByRole("button", { name: "Full Resync" })).toBeVisible(); |
| 73 | + await expect |
| 74 | + .poll(() => page.evaluate(() => document.documentElement.scrollWidth <= innerWidth)) |
| 75 | + .toBe(true); |
| 76 | + }); |
| 77 | + |
| 78 | + test("hides an unmatched panel without discarding its draft", async ({ page }) => { |
| 79 | + // App and SettingsPage both start an initial settings read. Wait for both |
| 80 | + // before editing so a late response cannot reset the unsaved draft. |
| 81 | + await openSettledSettings(page); |
| 82 | + |
| 83 | + const nav = page.getByRole("navigation", { name: "Settings" }); |
| 84 | + await nav.locator("button", { hasText: "Terminal" }).click(); |
| 85 | + await page.getByRole("radio", { name: "Custom", exact: true }).click(); |
| 86 | + |
| 87 | + const binary = page.getByLabel("Terminal binary"); |
| 88 | + await binary.fill("/usr/bin/kitty"); |
| 89 | + |
| 90 | + const search = page.getByRole("searchbox", { name: "Search settings" }); |
| 91 | + await search.fill("no such setting"); |
| 92 | + |
| 93 | + await expect(page.getByText("No matching settings", { exact: true })).toBeVisible(); |
| 94 | + await expect(page.getByRole("heading", { name: "Terminal" })).toHaveCount(0); |
| 95 | + await expect(page.locator("#terminal-bin")).toBeHidden(); |
| 96 | + |
| 97 | + await search.fill(""); |
| 98 | + |
| 99 | + await expect(page.getByRole("heading", { name: "Terminal" })).toBeVisible(); |
| 100 | + await expect(binary).toHaveValue("/usr/bin/kitty"); |
| 101 | + }); |
| 102 | +}); |
0 commit comments