Commit 3c951eb
committed
pg: address second review of --from-now
Daemon delegation sent --full and --from-now unchanged, so the precedence
resolved on the local path did not apply when the daemon owns the archive:
`pg push --full --from-now` could backfill locally but bound remotely. The
delegated request now carries the resolved value.
Freshness is judged on the state as first read, before the recovery paths can
clear the watermark and boundary state, so a target whose PG marker was lost no
longer looks brand new and cannot be re-bounded.
The incompatible vector configuration is refused before connecting rather than
after, so watch mode does not retry a combination that can never succeed having
already synced locally and opened a stream. The flag help now states the
requirement.
Known limitation, left for maintainer judgement: the boundary is per-push, so
phases that are archive-wide by nature (cursor usage events on later pushes,
project-identity publication) are only skipped on the bounded push itself.
Making that permanent needs the boundary persisted per target, and the right
treatment of identity publication is a product call: skipping it entirely
leaves a bounded target without project identities, while scoping observations
and snapshots to admitted sessions preserves them but is a larger change.1 parent 4723f89 commit 3c951eb
4 files changed
Lines changed: 18 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
333 | 333 | | |
334 | 334 | | |
335 | 335 | | |
336 | | - | |
| 336 | + | |
337 | 337 | | |
338 | 338 | | |
339 | 339 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
652 | 652 | | |
653 | 653 | | |
654 | 654 | | |
655 | | - | |
| 655 | + | |
656 | 656 | | |
657 | 657 | | |
658 | 658 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
99 | 99 | | |
100 | 100 | | |
101 | 101 | | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
102 | 112 | | |
103 | 113 | | |
104 | 114 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
178 | 178 | | |
179 | 179 | | |
180 | 180 | | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
181 | 185 | | |
182 | 186 | | |
183 | 187 | | |
| |||
301 | 305 | | |
302 | 306 | | |
303 | 307 | | |
304 | | - | |
| 308 | + | |
| 309 | + | |
305 | 310 | | |
306 | 311 | | |
307 | 312 | | |
| |||
0 commit comments