fix(parser): scope opencode exit failures to bash

Author: mjacobs

docs/internal/session-format-sources.md

@@ -244,8 +244,8 @@ Grok section and remove the explicit registry exception in the coverage test.
   failure signal. The tool's own output text carries no `exit status N`
   marker, and the shell is `COMSPEC`/`cmd.exe` on Windows, so text-pattern
   matching alone misses these failures on every platform. Agentsview treats a
-  non-zero `state.metadata.exit` on any tool part as a failure and attaches an
-  errored result event. Only `bash` parts record `exit`; other tools omit the
+  non-zero `state.metadata.exit` on a `bash` tool part as a failure and attaches
+  an errored result event. Only `bash` parts record `exit`; other tools omit the
   key. Verified 2026-07-24 against a live `opencode.db` where all 24 bash
   parts with `exit` in `{1, 127, 128}` had output text without an
   `exit status` marker, and the 81 successful parts recorded `exit=0`. Known

internal/parser/opencode.go

@@ -1013,7 +1013,7 @@ func extractOpenCodeToolCall(data, cwd string) ParsedToolCall {
 			// state metadata. On Windows the output text carries
 			// no "exit status N" marker, so metadata.exit is the
 			// only reliable failure signal.
-			if len(state.Metadata) > 0 {
+			if d.ToolName == "bash" && len(state.Metadata) > 0 {
 				var m openCodeToolMetadata
 				if err := json.Unmarshal(state.Metadata, &m); err == nil && m.Exit > 0 {
 					isFailure = true

internal/parser/opencode_test.go

@@ -936,34 +936,46 @@ func TestParseOpenCodeDB_InvalidToolCall(t *testing.T) {
 func TestParseOpenCodeDB_BashExitFailure(t *testing.T) {
 	tests := []struct {
 		name        string
+		tool        string
 		state       string
 		wantErrored bool
 	}{
 		{
 			name:        "non-zero exit without exit-status text",
+			tool:        "bash",
 			state:       `{"input":{"command":"build"},"output":"error: command failed","metadata":{"exit":1}}`,
 			wantErrored: true,
 		},
 		{
 			name:        "non-zero exit with empty output",
+			tool:        "bash",
 			state:       `{"input":{"command":"build"},"output":"","metadata":{"exit":127}}`,
 			wantErrored: true,
 		},
 		{
 			name:        "zero exit is not a failure",
+			tool:        "bash",
 			state:       `{"input":{"command":"build"},"output":"ok","metadata":{"exit":0}}`,
 			wantErrored: false,
 		},
 		{
 			name:        "metadata without an exit key is not a failure",
+			tool:        "bash",
 			state:       `{"input":{"command":"build"},"output":"ok","metadata":{"truncated":false}}`,
 			wantErrored: false,
 		},
 		{
 			name:        "no metadata is not a failure",
+			tool:        "bash",
 			state:       `{"input":{"command":"build"},"output":"ok"}`,
 			wantErrored: false,
 		},
+		{
+			name:        "non-bash metadata exit is not a failure",
+			tool:        "mcp_lookup",
+			state:       `{"input":{"query":"exit routes"},"output":"route 1","metadata":{"exit":1}}`,
+			wantErrored: false,
+		},
 	}
 
 	for _, tt := range tests {
@@ -979,7 +991,7 @@ func TestParseOpenCodeDB_BashExitFailure(t *testing.T) {
 
 			seeder.AddMessage("msg_a", "ses_bexit", 1700000010000, 1700000010000, `{"role":"assistant"}`)
 			seeder.AddPart("prt_t", "msg_a", "ses_bexit", 1700000010000, 1700000010000,
-				`{"type":"tool","tool":"bash","callID":"call_exit","state":`+tt.state+`}`)
+				`{"type":"tool","tool":"`+tt.tool+`","callID":"call_exit","state":`+tt.state+`}`)
 
 			sessions, err := parseOpenCodeAll(dbPath, "m")
 			require.NoError(t, err, "ParseOpenCodeDB")