Skip to content

Commit 5c0f0e7

Browse files
test: stabilize platform-sensitive CI checks (#1303)
The Linux race suite inherits Go’s ten-minute default package timeout even though the ordinary suite allows twenty minutes. On the failed main run, `internal/sync` reached that boundary without reporting a data race, turning an instrumentation-slow package into a false CI failure. Windows hit a similar timing assumption: vector serving stayed open correctly while the API build was blocked, but the test allowed only two seconds for index finalization after release. This keeps both lifecycle assertions while giving finalization a bounded allowance appropriate for loaded Windows runners. This is intentionally a reliability fix, not a suite-sharding change. `internal/sync` and `internal/artifact` are already near co-critical paths; the larger follow-up opportunity is to run the separate non-race DuckDB command in parallel with the race suite.
1 parent b0b0553 commit 5c0f0e7

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ jobs:
176176
if: runner.os == 'Linux'
177177
run: |
178178
go test -tags "fts5" ./internal/duckdb -count=1
179-
go test -tags "fts5" -race $(go list ./... | grep -v '/internal/duckdb$') -count=1
179+
go test -tags "fts5" -race $(go list ./... | grep -v '/internal/duckdb$') -count=1 -timeout=20m
180180
env:
181181
CGO_ENABLED: "1"
182182

cmd/agentsview/embed_scheduler_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1522,7 +1522,7 @@ func TestVectorServingCloseWaitsForAPIStartedRecallBuild(t *testing.T) {
15221522
select {
15231523
case closeErr := <-closeDone:
15241524
require.NoError(t, closeErr)
1525-
case <-time.After(2 * time.Second):
1525+
case <-time.After(10 * time.Second):
15261526
require.Fail(t, "vector serving did not close after the API build completed")
15271527
}
15281528
}

0 commit comments

Comments
 (0)