test(duckdb): fix rebase-ported mirror tests for schema v4

Make the probe schema-drift assertions relative to SchemaVersion so the
v4 bump keeps 'newer mirror' meaning newer than current, clear the
stored push fingerprint in the provenance re-push test so the
session-replace path actually runs, and drop the snapshot-count helper
orphaned by the removal of the pre-pareback tombstone test.

Author: wesm

internal/duckdb/probe_test.go

@@ -55,10 +55,10 @@ func TestProbeMirrorReadsMetadataAndFlagsShapeIssues(t *testing.T) {
 	assert.True(t, p.NeedsRebuild("", 69))
 	assert.True(t, p.NeedsRebuild(canonicalPushScope([]string{"p"}, nil), 68))
 	older := p
-	older.SchemaVersion = 2
+	older.SchemaVersion = SchemaVersion - 1
 	assert.True(t, older.NeedsRebuild("", 68))
 	newer := p
-	newer.SchemaVersion = 4
+	newer.SchemaVersion = SchemaVersion + 1
 	assert.True(t, newer.NeedsRebuild("", 68))
 }
 

internal/duckdb/sync_test.go

@@ -2186,23 +2186,6 @@ func assertDuckDBCountWhere(
 	assert.Equal(t, want, got, table)
 }
 
-func assertDuckDBSnapshotCount(
-	t *testing.T,
-	conn *sql.DB,
-	archiveID, generation, sessionID, project string,
-	want int,
-) {
-	t.Helper()
-	var got int
-	require.NoError(t, conn.QueryRow(`
-		SELECT COUNT(*) FROM source_session_project_identity_snapshots
-		WHERE source_archive_id = ? AND source_database_generation = ?
-		  AND source_session_id = ? AND project = ?`,
-		archiveID, generation, sessionID, project,
-	).Scan(&got))
-	assert.Equal(t, want, got, "source_session_project_identity_snapshots")
-}
-
 func TestSyncResultDurationIsSet(t *testing.T) {
 	ctx := context.Background()
 	local := newLocalDB(t)
@@ -2248,7 +2231,9 @@ func TestDuckPushWritesSessionProvenance(t *testing.T) {
 	conn, err := Open(path)
 	require.NoError(t, err)
 	_, err = conn.ExecContext(ctx,
-		`UPDATE sessions SET source_archive_id = '' WHERE id = ?`, "sess-1")
+		`UPDATE sessions
+		 SET source_archive_id = '', agentsview_push_fingerprint = NULL
+		 WHERE id = ?`, "sess-1")
 	require.NoError(t, err)
 	require.NoError(t, conn.Close())