fix: address code review findings across 2 reviews

- install.sh: gate SHA256SUMS download+verify behind
  AGENTSVIEW_SKIP_CHECKSUM so skip flag bypasses download failure
- codex.go: use structural emptiness checks (len(arg.Map())==0)
  instead of raw string comparison for empty args detection
- Add tests: empty-args fallback to input, write_stdin formatting,
  export legacy Codex markers (parallel, view_image, etc.)
- go fmt formatting fixes in config_test.go, analytics_test.go

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: wesm

internal/config/config_test.go

@@ -245,4 +245,3 @@ func TestResolveDataDir_DefaultAndEnvOverride(t *testing.T) {
 		t.Errorf("ResolveDataDir = %q, want %q", dir, custom)
 	}
 }
-

internal/db/analytics_test.go

@@ -1916,12 +1916,12 @@ func TestTimeFilter(t *testing.T) {
 		Message{
 			SessionID: "tf1", Ordinal: 0, Role: "user",
 			Timestamp: "2024-06-01T09:05:00Z",
-			Content: "hello", ContentLength: 5,
+			Content:   "hello", ContentLength: 5,
 		},
 		Message{
 			SessionID: "tf1", Ordinal: 1, Role: "assistant",
 			Timestamp: "2024-06-01T09:10:00Z",
-			Content: "hi", ContentLength: 2,
+			Content:   "hi", ContentLength: 2,
 		},
 	)
 
@@ -1934,7 +1934,7 @@ func TestTimeFilter(t *testing.T) {
 	insertMessages(t, d, Message{
 		SessionID: "tf2", Ordinal: 0, Role: "user",
 		Timestamp: "2024-06-01T14:05:00Z",
-		Content: "world", ContentLength: 5,
+		Content:   "world", ContentLength: 5,
 	})
 
 	insertSession(t, d, "tf3", "proj", func(s *Session) {
@@ -1946,7 +1946,7 @@ func TestTimeFilter(t *testing.T) {
 	insertMessages(t, d, Message{
 		SessionID: "tf3", Ordinal: 0, Role: "user",
 		Timestamp: "2024-06-03T09:30:00Z",
-		Content: "test", ContentLength: 4,
+		Content:   "test", ContentLength: 4,
 	})
 
 	f := AnalyticsFilter{

internal/parser/codex.go

@@ -210,9 +210,14 @@ func parseCodexFunctionArgs(
 			}
 			return gjson.Result{}, s
 		default:
-			if arg.IsObject() || arg.IsArray() {
-				trimmed := strings.TrimSpace(arg.Raw)
-				if trimmed == "{}" || trimmed == "[]" {
+			if arg.IsObject() {
+				if len(arg.Map()) == 0 {
+					continue
+				}
+				return arg, ""
+			}
+			if arg.IsArray() {
+				if len(arg.Array()) == 0 {
 					continue
 				}
 				return arg, ""

internal/parser/parser_test.go

@@ -1054,6 +1054,78 @@ func TestParseCodexSession(t *testing.T) {
 				}
 			},
 		},
+		{
+			name: "empty arguments falls through to input",
+			content: testjsonl.JoinJSONL(
+				testjsonl.CodexSessionMetaJSON(
+					"fc-empty-args", "/tmp", "user", tsEarly,
+				),
+				testjsonl.CodexMsgJSON(
+					"user", "run command", tsEarlyS1,
+				),
+				testjsonl.CodexFunctionCallFieldsJSON(
+					"exec_command",
+					map[string]any{},
+					`{"cmd":"ls -la"}`,
+					tsEarlyS5,
+				),
+			),
+			wantID:   "codex:fc-empty-args",
+			wantMsgs: 2,
+			check: func(
+				t *testing.T, _ *ParsedSession,
+				msgs []ParsedMessage,
+			) {
+				t.Helper()
+				want := "[Bash]\n$ ls -la"
+				if msgs[1].Content != want {
+					t.Errorf(
+						"content = %q, want %q",
+						msgs[1].Content, want,
+					)
+				}
+			},
+		},
+		{
+			name: "write_stdin formats with session and chars",
+			content: testjsonl.JoinJSONL(
+				testjsonl.CodexSessionMetaJSON(
+					"fc-stdin", "/tmp", "user", tsEarly,
+				),
+				testjsonl.CodexMsgJSON(
+					"user", "send input", tsEarlyS1,
+				),
+				testjsonl.CodexFunctionCallArgsJSON(
+					"write_stdin",
+					map[string]any{
+						"session_id": "sess-42",
+						"chars":      "yes\n",
+					},
+					tsEarlyS5,
+				),
+			),
+			wantID:   "codex:fc-stdin",
+			wantMsgs: 2,
+			check: func(
+				t *testing.T, _ *ParsedSession,
+				msgs []ParsedMessage,
+			) {
+				t.Helper()
+				want := "[Bash: stdin -> sess-42]\nyes\\n"
+				if msgs[1].Content != want {
+					t.Errorf(
+						"content = %q, want %q",
+						msgs[1].Content, want,
+					)
+				}
+				if msgs[1].ToolCalls[0].Category != "Bash" {
+					t.Errorf(
+						"category = %q, want Bash",
+						msgs[1].ToolCalls[0].Category,
+					)
+				}
+			},
+		},
 		{
 			name: "large message within scanner limit",
 			content: testjsonl.JoinJSONL(

internal/server/export_test.go

@@ -244,6 +244,30 @@ func TestFormatContentForExport_Escaping(t *testing.T) {
 			[]string{`class="tool-block"`},
 			nil,
 		},
+		{
+			"LegacyCodexExecCommand",
+			"[exec_command]\n$ ls -la",
+			[]string{`class="tool-block"`},
+			nil,
+		},
+		{
+			"LegacyCodexParallel",
+			"[parallel]\nrunning tasks",
+			[]string{`class="tool-block"`},
+			nil,
+		},
+		{
+			"LegacyCodexViewImage",
+			"[view_image]\nimage.png",
+			[]string{`class="tool-block"`},
+			nil,
+		},
+		{
+			"LegacyCodexUpdatePlan",
+			"[update_plan]\nnew plan",
+			[]string{`class="tool-block"`},
+			nil,
+		},
 		{
 			"EmptyInput",
 			"",

internal/testjsonl/testjsonl.go

@@ -154,6 +154,30 @@ func CodexFunctionCallArgsJSON(
 	return mustMarshal(m)
 }
 
+// CodexFunctionCallFieldsJSON returns a Codex function_call
+// response_item with explicit arguments and input fields.
+func CodexFunctionCallFieldsJSON(
+	name string, arguments, input any, timestamp string,
+) string {
+	payload := map[string]any{
+		"type":    "function_call",
+		"name":    name,
+		"call_id": "call_test",
+	}
+	if arguments != nil {
+		payload["arguments"] = arguments
+	}
+	if input != nil {
+		payload["input"] = input
+	}
+	m := map[string]any{
+		"type":      "response_item",
+		"timestamp": timestamp,
+		"payload":   payload,
+	}
+	return mustMarshal(m)
+}
+
 // JoinJSONL joins JSON lines with newlines and appends a
 // trailing newline.
 func JoinJSONL(lines ...string) string {

scripts/install.sh

@@ -126,10 +126,14 @@ install_from_release() {
         return 1
     fi
 
-    if ! download "${base_url}/SHA256SUMS" "$tmpdir/SHA256SUMS"; then
-        error "Failed to download SHA256SUMS. Cannot verify binary integrity."
+    if [ "${AGENTSVIEW_SKIP_CHECKSUM:-0}" != "1" ]; then
+        if ! download "${base_url}/SHA256SUMS" "$tmpdir/SHA256SUMS"; then
+            error "Failed to download SHA256SUMS. Cannot verify binary integrity."
+        fi
+        verify_checksum "$tmpdir/release.tar.gz" "$tmpdir/SHA256SUMS" "$filename"
+    else
+        warn "Checksum verification skipped (AGENTSVIEW_SKIP_CHECKSUM=1)"
     fi
-    verify_checksum "$tmpdir/release.tar.gz" "$tmpdir/SHA256SUMS" "$filename"
 
     info "Extracting..."
     tar -xzf "$tmpdir/release.tar.gz" -C "$tmpdir"