fix(cli): expand leading tilde in DuckDB mirror paths (#1274)

DuckDB config resolution currently leaves a leading `~` literal in
`[duckdb].path`, so daemon-backed pushes can canonicalize the server
mirror path against the daemon working directory instead of the user's
home directory.

This expands leading-home shorthand during DuckDB config resolution,
alongside the existing defaulting and env expansion, so the daemon and
in-process callers resolve the same mirror path from the same config
value. `${HOME}` expansion, default-path fallback, and non-leading
tildes keep their current behavior. The change stays in
`internal/config` with focused resolution regression coverage.

The config snippet and daemon-vs-in-process repro came from @halms's
issue report.

Closes #1264

---------

Co-authored-by: Marius van Niekerk <marius.v.niekerk@gmail.com>

Author: rodboev

cmd/agentsview/duckdb.go

@@ -18,6 +18,7 @@ import (
 	"github.com/spf13/cobra"
 	"go.kenn.io/agentsview/internal/config"
 	duckdbsync "go.kenn.io/agentsview/internal/duckdb"
+	"go.kenn.io/agentsview/internal/pathutil"
 	"go.kenn.io/agentsview/internal/server"
 )
 
@@ -515,7 +516,10 @@ func runDuckDBQuackServe(cfg DuckDBQuackServeConfig) {
 		fatal("duckdb quack serve: %v", err)
 	}
 	if cfg.Path != "" {
-		duckCfg.Path = cfg.Path
+		duckCfg.Path, err = pathutil.ExpandHome(cfg.Path)
+		if err != nil {
+			fatal("duckdb quack serve: expanding --path: %v", err)
+		}
 	}
 	if cfg.AllowInsecure {
 		duckCfg.AllowInsecure = true

cmd/agentsview/import.go

@@ -11,6 +11,7 @@ import (
 	"go.kenn.io/agentsview/internal/config"
 	"go.kenn.io/agentsview/internal/db"
 	"go.kenn.io/agentsview/internal/importer"
+	"go.kenn.io/agentsview/internal/pathutil"
 )
 
 type ImportConfig struct {
@@ -19,6 +20,12 @@ type ImportConfig struct {
 }
 
 func runImport(cfg ImportConfig) {
+	expandedPath, err := pathutil.ExpandHome(cfg.Path)
+	if err != nil {
+		log.Fatalf("expanding import path: %v", err)
+	}
+	cfg.Path = expandedPath
+
 	appCfg, err := config.LoadMinimal()
 	if err != nil {
 		log.Fatalf("loading config: %v", err)

cmd/agentsview/recall.go

@@ -15,6 +15,7 @@ import (
 
 	"go.kenn.io/agentsview/internal/config"
 	"go.kenn.io/agentsview/internal/db"
+	"go.kenn.io/agentsview/internal/pathutil"
 	corerecall "go.kenn.io/agentsview/internal/recall"
 	"go.kenn.io/agentsview/internal/service"
 )
@@ -912,7 +913,11 @@ func newRecallImportCommand() *cobra.Command {
 					return err
 				}
 			}
-			f, err := os.Open(args[0])
+			path, err := pathutil.ExpandHome(args[0])
+			if err != nil {
+				return fmt.Errorf("expanding recall import path: %w", err)
+			}
+			f, err := os.Open(path)
 			if err != nil {
 				return fmt.Errorf("opening recall import file: %w", err)
 			}
@@ -1050,7 +1055,7 @@ func addRecallFilterFlags(cmd *cobra.Command, f *service.RecallFilter) {
 	flags := cmd.Flags()
 	flags.StringVar(&f.Query, "query", "", "Filter by query text")
 	flags.StringVar(&f.Project, "project", "", "Filter by project")
-	flags.StringVar(&f.CWD, "cwd", "", "Filter by cwd")
+	flags.Var(&homePathValue{value: &f.CWD}, "cwd", "Filter by cwd")
 	flags.StringVar(&f.GitBranch, "git-branch", "", "Filter by git branch")
 	flags.StringVar(&f.Agent, "agent", "", "Filter by agent")
 	flags.StringVar(&f.Type, "type", "", "Filter by recall type")
@@ -1101,6 +1106,28 @@ func addRecallFilterFlags(cmd *cobra.Command, f *service.RecallFilter) {
 	flags.IntVar(&f.Limit, "limit", 0, "Maximum entries to return")
 }
 
+type homePathValue struct {
+	value *string
+}
+
+func (v *homePathValue) Set(path string) error {
+	expanded, err := pathutil.ExpandHome(path)
+	if err != nil {
+		return err
+	}
+	*v.value = expanded
+	return nil
+}
+
+func (v *homePathValue) String() string {
+	if v == nil || v.value == nil {
+		return ""
+	}
+	return *v.value
+}
+
+func (*homePathValue) Type() string { return "path" }
+
 func addRecallEntryCurrentCWDFlag(cmd *cobra.Command, currentCWD *bool) {
 	cmd.Flags().BoolVar(
 		currentCWD,
@@ -1238,7 +1265,7 @@ func addRecallQueryFlags(cmd *cobra.Command, req *service.RecallQuery) {
 		"Retrieval mode: lexical, vector, or hybrid",
 	)
 	flags.StringVar(&req.Project, "project", "", "Filter by project")
-	flags.StringVar(&req.CWD, "cwd", "", "Filter by cwd")
+	flags.Var(&homePathValue{value: &req.CWD}, "cwd", "Filter by cwd")
 	flags.StringVar(&req.GitBranch, "git-branch", "", "Filter by git branch")
 	flags.StringVar(&req.Agent, "agent", "", "Filter by agent")
 	flags.StringVar(&req.Type, "type", "", "Filter by recall type")

cmd/agentsview/recall_test.go

@@ -14,6 +14,7 @@ import (
 	"strings"
 	"testing"
 
+	"github.com/spf13/cobra"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 
@@ -22,6 +23,18 @@ import (
 	"go.kenn.io/agentsview/internal/service"
 )
 
+func TestRecallCWDFlagExpandsHome(t *testing.T) {
+	home := t.TempDir()
+	t.Setenv("HOME", home)
+	t.Setenv("USERPROFILE", home)
+	var filter service.RecallFilter
+	cmd := &cobra.Command{Use: "test"}
+	addRecallFilterFlags(cmd, &filter)
+
+	require.NoError(t, cmd.Flags().Parse([]string{"--cwd", "~/work"}))
+	assert.Equal(t, filepath.Join(home, "work"), filter.CWD)
+}
+
 func TestPrintRecallEntryReviewLineDefaultsReviewStateToUnreviewedAuto(
 	t *testing.T,
 ) {

cmd/agentsview/session.go

@@ -12,6 +12,7 @@ import (
 	"github.com/spf13/cobra"
 	"github.com/spf13/pflag"
 	"go.kenn.io/agentsview/internal/config"
+	"go.kenn.io/agentsview/internal/pathutil"
 	"go.kenn.io/agentsview/internal/service"
 	"go.kenn.io/agentsview/internal/timeutil"
 )
@@ -219,6 +220,10 @@ func explicitServerToken(cmd *cobra.Command) (string, error) {
 	}
 	path, err := cmd.Flags().GetString("server-token-file")
 	if err == nil && strings.TrimSpace(path) != "" {
+		path, err = pathutil.ExpandHome(path)
+		if err != nil {
+			return "", fmt.Errorf("expanding --server-token-file: %w", err)
+		}
 		b, err := os.ReadFile(path)
 		if err != nil {
 			return "", fmt.Errorf("reading --server-token-file: %w", err)

cmd/agentsview/session_test.go

@@ -1518,6 +1518,31 @@ func TestSessionUsage_ServerTokenSendsBearer(t *testing.T) {
 	require.NotNil(t, out)
 }
 
+func TestSessionUsage_ServerTokenFileExpandsHome(t *testing.T) {
+	home := t.TempDir()
+	t.Setenv("HOME", home)
+	t.Setenv("USERPROFILE", home)
+	tokenFile := filepath.Join(home, "remote-token")
+	require.NoError(t, os.WriteFile(
+		tokenFile, []byte("remote-secret\n"), 0o600,
+	))
+
+	ts, _ := newRemoteUsageServer(t, remoteUsageSpec{
+		canonicalID:   "remote-session",
+		bearer:        "remote-secret",
+		serverRunning: true,
+	})
+
+	cmd := sessionUsageCommand(t,
+		"session", "usage", "remote-session",
+		"--server", ts.URL,
+		"--server-token-file", "~/remote-token")
+
+	out, _, err := sessionUsageDataForCommand(cmd, "remote-session")
+	require.NoError(t, err)
+	require.NotNil(t, out)
+}
+
 func TestSessionUsage_ServerHTTPClientHasTimeout(t *testing.T) {
 	oldClient := sessionUsageHTTPClient
 	sessionUsageHTTPClient = &http.Client{Timeout: 20 * time.Millisecond}

cmd/agentsview/sync_profile.go

@@ -9,6 +9,8 @@ import (
 	"runtime/pprof"
 	"runtime/trace"
 	"slices"
+
+	"go.kenn.io/agentsview/internal/pathutil"
 )
 
 // startSyncProfile starts whichever of the hidden --cpuprofile,
@@ -19,6 +21,9 @@ import (
 // profiling typo never aborts a real sync.
 func startSyncProfile(cfg SyncConfig) func() {
 	var stoppers []func()
+	cfg.CPUProfile = expandSyncProfilePath("cpuprofile", cfg.CPUProfile)
+	cfg.MemProfile = expandSyncProfilePath("memprofile", cfg.MemProfile)
+	cfg.Trace = expandSyncProfilePath("trace", cfg.Trace)
 
 	if cfg.CPUProfile != "" {
 		f, err := os.Create(cfg.CPUProfile)
@@ -81,3 +86,12 @@ func startSyncProfile(cfg SyncConfig) func() {
 		}
 	}
 }
+
+func expandSyncProfilePath(name, path string) string {
+	expanded, err := pathutil.ExpandHome(path)
+	if err != nil {
+		log.Printf("%s: expand path: %v", name, err)
+		return ""
+	}
+	return expanded
+}

internal/config/config.go

@@ -26,6 +26,7 @@ import (
 	"github.com/gofrs/flock"
 	"github.com/spf13/pflag"
 	"go.kenn.io/agentsview/internal/parser"
+	"go.kenn.io/agentsview/internal/pathutil"
 )
 
 // TerminalConfig holds terminal launch preferences.
@@ -873,6 +874,9 @@ func loadPGServeBase() (Config, error) {
 		return cfg, err
 	}
 	cfg.loadEnv()
+	if err := expandDataDir(&cfg); err != nil {
+		return cfg, err
+	}
 	if err := cfg.loadFile(); err != nil {
 		return cfg, fmt.Errorf("loading config file: %w", err)
 	}
@@ -905,6 +909,9 @@ func LoadMinimal() (Config, error) {
 		return cfg, err
 	}
 	cfg.loadEnv()
+	if err := expandDataDir(&cfg); err != nil {
+		return cfg, err
+	}
 
 	if err := cfg.loadFile(); err != nil {
 		return cfg, fmt.Errorf("loading config file: %w", err)
@@ -928,6 +935,9 @@ func LoadReadOnly() (Config, error) {
 		return cfg, err
 	}
 	cfg.loadEnv()
+	if err := expandDataDir(&cfg); err != nil {
+		return cfg, err
+	}
 
 	if err := cfg.loadFileReadOnly(); err != nil {
 		return cfg, fmt.Errorf("loading config file: %w", err)
@@ -1755,6 +1765,9 @@ func splitFlagList(value string) []string {
 
 func finalize(cfg *Config) error {
 	var err error
+	if err := expandLocalPaths(cfg); err != nil {
+		return err
+	}
 	if strings.TrimSpace(cfg.LocalMachineName) == "" {
 		return fmt.Errorf("identify local sync machine: hostname is empty")
 	}
@@ -2137,6 +2150,9 @@ func ResolveDataDir() (string, error) {
 	if v := dataDirFromEnv(); v != "" {
 		cfg.DataDir = v
 	}
+	if err := expandDataDir(&cfg); err != nil {
+		return "", err
+	}
 	return cfg.DataDir, nil
 }
 
@@ -2402,6 +2418,10 @@ func (c *Config) ResolveDuckDB() (DuckDBConfig, error) {
 		if err != nil {
 			return duck, fmt.Errorf("expanding path: %w", err)
 		}
+		expanded, err = pathutil.ExpandHome(expanded)
+		if err != nil {
+			return duck, fmt.Errorf("expanding path: %w", err)
+		}
 		duck.Path = expanded
 	}
 	if duck.URL != "" {
@@ -2504,6 +2524,13 @@ func expandBracedEnv(s string) (string, error) {
 
 // SaveTerminalConfig persists terminal settings to the config file.
 func (c *Config) SaveTerminalConfig(tc TerminalConfig) error {
+	live := tc
+	expanded, err := pathutil.ExpandHome(live.CustomBin)
+	if err != nil {
+		return fmt.Errorf("expanding terminal custom binary: %w", err)
+	}
+	live.CustomBin = expanded
+
 	return c.withConfigLock(func() error {
 		existing, err := c.readConfigMap()
 		if err != nil {
@@ -2514,7 +2541,7 @@ func (c *Config) SaveTerminalConfig(tc TerminalConfig) error {
 		if err := c.writeConfigMap(existing); err != nil {
 			return err
 		}
-		c.Terminal = tc
+		c.Terminal = live
 		return nil
 	})
 }

internal/config/config_duckdb_tilde_test.go

@@ -0,0 +1,37 @@
+package config
+
+import (
+	"os"
+	"path/filepath"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func TestResolveDuckDB_ExpandsLeadingTildePath(t *testing.T) {
+	home, err := os.UserHomeDir()
+	require.NoError(t, err)
+
+	cfg := Config{
+		DuckDB: DuckDBConfig{
+			Path: "~/mirror.duckdb",
+		},
+	}
+
+	resolved, err := cfg.ResolveDuckDB()
+	require.NoError(t, err)
+	assert.Equal(t, filepath.Join(home, "mirror.duckdb"), resolved.Path)
+}
+
+func TestResolveDuckDB_DoesNotExpandMidStringTilde(t *testing.T) {
+	cfg := Config{
+		DuckDB: DuckDBConfig{
+			Path: "path/with~marker.duckdb",
+		},
+	}
+
+	resolved, err := cfg.ResolveDuckDB()
+	require.NoError(t, err)
+	assert.Equal(t, "path/with~marker.duckdb", resolved.Path)
+}