fix(parser): preserve positron composite metadata

Roborev job 2737 caught that the Positron shadow parity test compared against raw parser metadata instead of the legacy sync path, which includes workspace.json in source size, mtime, and hash.

Carry provider fingerprint size and mtime into parsed Positron sessions alongside the composite hash, and update the shadow test to compute the same workspace-aware metadata as processPositron.

Validation: go test -tags "fts5" ./internal/parser ./internal/sync -run 'Test(PositronProvider|ObserveProviderSourceMatchesPositronLegacyParser)' -count=1; go fmt ./...; go vet ./...; git diff --check

Author: mariusvniekerk

internal/parser/positron_provider.go

@@ -98,6 +98,12 @@ func (p *positronProvider) Parse(
 			SkipReason:        SkipNoSession,
 		}, nil
 	}
+	if req.Fingerprint.Size > 0 {
+		sess.File.Size = req.Fingerprint.Size
+	}
+	if req.Fingerprint.MTimeNS > 0 {
+		sess.File.Mtime = req.Fingerprint.MTimeNS
+	}
 	if req.Fingerprint.Hash != "" {
 		sess.File.Hash = req.Fingerprint.Hash
 	}

internal/sync/provider_shadow_positron_test.go

@@ -2,7 +2,9 @@ package sync
 
 import (
 	"context"
+	"os"
 	"path/filepath"
+	"strings"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
@@ -17,9 +19,10 @@ func TestObserveProviderSourceMatchesPositronLegacyParser(t *testing.T) {
 	hashDir := filepath.Join(root, "workspaceStorage", "workspace-hash")
 	chatDir := filepath.Join(hashDir, "chatSessions")
 	sourcePath := filepath.Join(chatDir, sessionID+".jsonl")
+	workspacePath := filepath.Join(hashDir, "workspace.json")
 	writeProviderShadowSourceFile(
 		t,
-		filepath.Join(hashDir, "workspace.json"),
+		workspacePath,
 		`{"folder":"file:///Users/alice/code/positron-app"}`,
 	)
 	writeProviderShadowSourceFile(t, sourcePath, vscodeCopilotShadowFixture(sessionID))
@@ -45,10 +48,30 @@ func TestObserveProviderSourceMatchesPositronLegacyParser(t *testing.T) {
 	})
 	require.NoError(t, err)
 	require.Len(t, observation.Results, 1)
-	legacySession.File.Hash = observation.Fingerprint.Hash
+	info, err := os.Stat(sourcePath)
+	require.NoError(t, err)
+	effectiveInfo := positronEffectiveInfo(sourcePath, info)
+	legacySession.File.Size = effectiveInfo.Size()
+	legacySession.File.Mtime = effectiveInfo.ModTime().UnixNano()
+	expectedHash := positronShadowCompositeHash(t, sourcePath, workspacePath)
+	assert.Equal(t, expectedHash, observation.Fingerprint.Hash)
+	legacySession.File.Hash = expectedHash
 
 	assert.Equal(t, *legacySession, observation.Results[0].Session)
 	assert.Equal(t, legacyMessages, observation.Results[0].Messages)
 	assert.Equal(t, []string{legacySession.ID}, observation.Planned.DataVersionSessionIDs())
 	assert.Empty(t, observation.Planned.Diagnostics)
 }
+
+func positronShadowCompositeHash(t *testing.T, sourcePath, workspacePath string) string {
+	t.Helper()
+	chatHash, err := ComputeFileHash(sourcePath)
+	require.NoError(t, err)
+	workspaceHash, err := ComputeFileHash(workspacePath)
+	require.NoError(t, err)
+	hash, err := ComputeHash(strings.NewReader(
+		"chat\x00" + chatHash + "\x00workspace\x00" + workspaceHash,
+	))
+	require.NoError(t, err)
+	return hash
+}