fix(sync): remove stale provider helpers

This lower DB-backed migration branch no longer calls the earlier cached-provider skip and source-error adapter helpers, but the full lint hook checks the branch in isolation. Leaving them here prevents any later provider cleanup commit from passing hooks.

Remove the unused helpers before the branch grows more provider stored-hint coverage; later upstack commits can reintroduce equivalent code only where it is actually wired.

Validation: go test -tags "fts5" ./internal/sync -run 'TestObserveProviderSourceMatchesDBBackedLegacyParsers' -count=1; go vet ./...

Author: mariusvniekerk

internal/sync/engine.go

@@ -4807,19 +4807,6 @@ func processFileUsesProvider(agent parser.AgentType) bool {
 	}
 }
 
-func (e *Engine) shouldSkipCachedProviderFile(
-	file parser.DiscoveredFile,
-	fingerprint parser.SourceFingerprint,
-) bool {
-	if e.forceParse || file.ForceParse || fingerprint.MTimeNS == 0 {
-		return false
-	}
-	e.skipMu.RLock()
-	cachedMtime, cached := e.skipCache[file.Path]
-	e.skipMu.RUnlock()
-	return cached && cachedMtime == fingerprint.MTimeNS
-}
-
 func (e *Engine) shouldSkipProviderSource(
 	file parser.DiscoveredFile,
 	source parser.SourceRef,
@@ -4880,27 +4867,6 @@ func providerSkipLookupPath(
 	return file.Path
 }
 
-func sourceErrorsToSessionParseErrors(
-	sourceErrs []parser.SourceError,
-) []sessionParseError {
-	if len(sourceErrs) == 0 {
-		return nil
-	}
-	errs := make([]sessionParseError, 0, len(sourceErrs))
-	for _, sourceErr := range sourceErrs {
-		virtualPath := sourceErr.DisplayPath
-		if virtualPath == "" {
-			virtualPath = sourceErr.SourceKey
-		}
-		errs = append(errs, sessionParseError{
-			sessionID:   sourceErr.SessionID,
-			virtualPath: virtualPath,
-			err:         sourceErr.Err,
-		})
-	}
-	return errs
-}
-
 func (e *Engine) shouldCacheSkip(
 	file parser.DiscoveredFile,
 ) bool {