fix: restore CLAUDE_NO_SOUND=1 for claude subprocess, update review guidelines

Set CLAUDE_NO_SOUND=1 on the claude command directly (appended to
inherited env) to suppress audible notifications during automated
insight generation.

Add review guideline #8: subprocess env inheritance is intentional
and env sanitization is the user's responsibility.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: wesm

.roborev.toml

@@ -38,6 +38,12 @@ Key assumptions reviewers MUST account for:
    ORDER BY id or references to tool_calls.id as missing-column
    errors without verifying the actual schema.
 
+8. SUBPROCESS ENVIRONMENT: Agent CLI subprocesses (claude, codex,
+   gemini) intentionally inherit the parent process environment.
+   Environment sanitization is the user's responsibility when
+   launching agentsview. Do not flag env var inheritance to agent
+   CLIs as a security issue.
+
 Do NOT flag issues that only apply to public-facing, multi-tenant,
 or network-exposed services. Focus on bugs, logic errors, data
 corruption risks, and code quality issues.

internal/insight/generate.go

@@ -123,6 +123,7 @@ func generateClaude(
 		ctx, path,
 		"-p", "--output-format", "json",
 	)
+	cmd.Env = append(os.Environ(), "CLAUDE_NO_SOUND=1")
 	cmd.Stdin = bytes.NewReader([]byte(prompt))
 
 	var stdout, stderr bytes.Buffer