fix: expose quality signal API schemas

Runtime session responses already include grouped quality signal data, but the OpenAPI schema hid that field from generated clients. That left frontend callers without the typed quality_signals object even though the server returned it.

Signal evidence sessions also need to remain a non-null typed array in the schema so client generation keeps DbSignalSessionExample instead of collapsing the field to any[].

Author: wesm

frontend/src/lib/api/generated/index.ts

@@ -2992,7 +2992,7 @@ type SignalCalibration struct {
 // an aggregate signal, including the best available message excerpt.
 type SignalSessionsResponse struct {
 	Signal   string                 `json:"signal"`
-	Sessions []SignalSessionExample `json:"sessions"`
+	Sessions []SignalSessionExample `json:"sessions" nullable:"false"`
 }
 
 type SignalSessionExample struct {

frontend/src/lib/api/generated/models/DbQualitySignals.ts

@@ -183,6 +183,9 @@ type QualitySignals struct {
 // deterministic quality-signal columns. Version 0 means the row has
 // not gone through the Phase 3 signal write/backfill path yet.
 func (s Session) StoredQualitySignals() *QualitySignals {
+	if s.QualitySignals != nil {
+		return s.QualitySignals
+	}
 	if s.QualitySignalVersion <= 0 {
 		return nil
 	}
@@ -201,6 +204,7 @@ func (s Session) StoredQualitySignals() *QualitySignals {
 // ApplyQualitySignals maps the grouped API representation back to the
 // scalar persistence fields used internally.
 func (s *Session) ApplyQualitySignals(qs *QualitySignals) {
+	s.QualitySignals = qs
 	if qs == nil {
 		s.QualitySignalVersion = 0
 		s.ShortPromptCount = 0
@@ -273,39 +277,42 @@ type Session struct {
 	IsAutomated          bool    `json:"is_automated"`
 
 	// Session signals (computed from messages/tool_calls).
-	ToolFailureSignalCount      int      `json:"tool_failure_signal_count"`
-	ToolRetryCount              int      `json:"tool_retry_count"`
-	EditChurnCount              int      `json:"edit_churn_count"`
-	ConsecutiveFailureMax       int      `json:"consecutive_failure_max"`
-	Outcome                     string   `json:"outcome"`
-	OutcomeConfidence           string   `json:"outcome_confidence"`
-	EndedWithRole               string   `json:"ended_with_role"`
-	FinalFailureStreak          int      `json:"final_failure_streak"`
-	SignalsPendingSince         *string  `json:"signals_pending_since,omitempty"`
-	CompactionCount             int      `json:"compaction_count"`
-	MidTaskCompactionCount      int      `json:"mid_task_compaction_count"`
-	ContextPressureMax          *float64 `json:"context_pressure_max,omitempty"`
-	HealthScore                 *int     `json:"health_score,omitempty"`
-	HealthGrade                 *string  `json:"health_grade,omitempty"`
-	HasToolCalls                bool     `json:"-"`
-	HasContextData              bool     `json:"-"`
-	SecretLeakCount             int      `json:"secret_leak_count"`
-	SecretsRulesVersion         string   `json:"-"`
-	QualitySignalVersion        int      `json:"-"`
-	ShortPromptCount            int      `json:"-"`
-	UnstructuredStart           bool     `json:"-"`
-	MissingSuccessCriteriaCount int      `json:"-"`
-	MissingVerificationCount    int      `json:"-"`
-	DuplicatePromptCount        int      `json:"-"`
-	NoCodeContextCount          int      `json:"-"`
-	RunawayToolLoopCount        int      `json:"-"`
-	DataVersion                 int      `json:"-"`
-	Cwd                         string   `json:"cwd,omitempty"`
-	GitBranch                   string   `json:"git_branch,omitempty"`
-	SourceSessionID             string   `json:"source_session_id,omitempty"`
-	SourceVersion               string   `json:"source_version,omitempty"`
-	ParserMalformedLines        int      `json:"parser_malformed_lines,omitempty"`
-	IsTruncated                 bool     `json:"is_truncated,omitempty"`
+	ToolFailureSignalCount int      `json:"tool_failure_signal_count"`
+	ToolRetryCount         int      `json:"tool_retry_count"`
+	EditChurnCount         int      `json:"edit_churn_count"`
+	ConsecutiveFailureMax  int      `json:"consecutive_failure_max"`
+	Outcome                string   `json:"outcome"`
+	OutcomeConfidence      string   `json:"outcome_confidence"`
+	EndedWithRole          string   `json:"ended_with_role"`
+	FinalFailureStreak     int      `json:"final_failure_streak"`
+	SignalsPendingSince    *string  `json:"signals_pending_since,omitempty"`
+	CompactionCount        int      `json:"compaction_count"`
+	MidTaskCompactionCount int      `json:"mid_task_compaction_count"`
+	ContextPressureMax     *float64 `json:"context_pressure_max,omitempty"`
+	HealthScore            *int     `json:"health_score,omitempty"`
+	HealthGrade            *string  `json:"health_grade,omitempty"`
+	// QualitySignals mirrors the scalar persistence fields below for API
+	// schema and JSON transport.
+	QualitySignals              *QualitySignals `json:"quality_signals,omitempty"`
+	HasToolCalls                bool            `json:"-"`
+	HasContextData              bool            `json:"-"`
+	SecretLeakCount             int             `json:"secret_leak_count"`
+	SecretsRulesVersion         string          `json:"-"`
+	QualitySignalVersion        int             `json:"-"`
+	ShortPromptCount            int             `json:"-"`
+	UnstructuredStart           bool            `json:"-"`
+	MissingSuccessCriteriaCount int             `json:"-"`
+	MissingVerificationCount    int             `json:"-"`
+	DuplicatePromptCount        int             `json:"-"`
+	NoCodeContextCount          int             `json:"-"`
+	RunawayToolLoopCount        int             `json:"-"`
+	DataVersion                 int             `json:"-"`
+	Cwd                         string          `json:"cwd,omitempty"`
+	GitBranch                   string          `json:"git_branch,omitempty"`
+	SourceSessionID             string          `json:"source_session_id,omitempty"`
+	SourceVersion               string          `json:"source_version,omitempty"`
+	ParserMalformedLines        int             `json:"parser_malformed_lines,omitempty"`
+	IsTruncated                 bool            `json:"is_truncated,omitempty"`
 
 	DeletedAt         *string `json:"deleted_at,omitempty"`
 	TerminationStatus *string `json:"termination_status,omitempty"`

frontend/src/lib/api/generated/models/DbSession.ts

@@ -632,6 +632,49 @@ func TestOpenAPIEndpointDocumentsEnumsAndRequestBodies(t *testing.T) {
 	assert.Equal(t, []string{"auto", "custom", "clipboard"}, mode.Enum)
 }
 
+func TestOpenAPIEndpointDocumentsQualitySignalResponses(t *testing.T) {
+	te := setup(t)
+
+	w := te.get(t, "/api/openapi.json")
+
+	require.Equal(t, http.StatusOK, w.Code, "body: %s", w.Body.String())
+	type openAPISchema struct {
+		Ref        string                   `json:"$ref"`
+		Type       any                      `json:"type"`
+		Items      *openAPISchema           `json:"items"`
+		Properties map[string]openAPISchema `json:"properties"`
+	}
+	var spec struct {
+		Components struct {
+			Schemas map[string]openAPISchema `json:"schemas"`
+		} `json:"components"`
+	}
+	require.NoError(t, json.Unmarshal(w.Body.Bytes(), &spec))
+
+	for _, schemaName := range []string{"DbSession", "ServiceSessionDetail"} {
+		schema, ok := spec.Components.Schemas[schemaName]
+		require.True(t, ok, "schema %s missing", schemaName)
+		require.Contains(t, schema.Properties, "quality_signals",
+			"schema %s should expose runtime quality_signals", schemaName)
+		assert.Equal(t,
+			"#/components/schemas/DbQualitySignals",
+			schema.Properties["quality_signals"].Ref,
+			"schema %s quality_signals ref", schemaName)
+	}
+
+	response, ok := spec.Components.Schemas["DbSignalSessionsResponse"]
+	require.True(t, ok, "schema DbSignalSessionsResponse missing")
+	sessions, ok := response.Properties["sessions"]
+	require.True(t, ok, "DbSignalSessionsResponse.sessions missing")
+	assert.Equal(t, "array", sessions.Type,
+		"sessions should be a non-null array so the generated client keeps item type")
+	require.NotNil(t, sessions.Items, "sessions.items missing")
+	assert.Equal(t,
+		"#/components/schemas/DbSignalSessionExample",
+		sessions.Items.Ref,
+		"sessions item schema")
+}
+
 func TestOpenAPIEndpointDocumentsImportResponseContentTypes(t *testing.T) {
 	te := setup(t)