fix: provide hosted zone id for dns records (#54)

* fix: provide hosted zone id for dns records

* fix: manage dns records without module

* fix: restore route53 records module

* review

* speed up e2e

* fix

* fix

* fix

* next cache

* fix flaky test

* fix flaky test

* fix flaky test

* Revert "fix flaky test"

This reverts commit 8cbdeaf.

* Revert "fix flaky test"

This reverts commit abf8358.

* fix flaky test

* fix flaky test

Author: kennethaasan

.github/workflows/ci-cd-pipeline.yml

@@ -145,13 +145,24 @@ jobs:
       - *node-checkout
       - *node-setup
       - *node-install-dependencies
+      - &next-cache
+        name: Cache Next.js build artifacts
+        uses: actions/cache@v4
+        with:
+          path: .next/cache
+          key: ${{ runner.os }}-next-cache-${{ hashFiles('package-lock.json') }}
+          restore-keys: |
+            ${{ runner.os }}-next-cache-
       - &copy-example-env
         name: Copy .env.example to .env
         run: cp .env.example .env
 
       - name: Seed database
         run: npm run seed
 
+      - name: Build application
+        run: npm run build
+
       - name: Run Playwright tests
         run: npm run test:e2e
 
@@ -174,6 +185,7 @@ jobs:
       - *node-checkout
       - *node-setup
       - *node-install-dependencies
+      - *next-cache
       - *copy-example-env
       - name: Build and package Lambda function
         run: npm run build:lambda

iac/main.tf

@@ -188,17 +188,20 @@ module "dns_records" {
   source  = "terraform-aws-modules/route53/aws"
   version = "6.1.0"
 
-  create_zone = false
-  name        = var.parent_domain
+  create       = true
+  create_zone  = false
+  name         = data.aws_route53_zone.zone.name
+  private_zone = false
 
   records = {
     app_a = {
       full_name       = var.app_domain
       type            = "A"
       allow_overwrite = true
       alias = {
-        name    = module.cdn.cloudfront_distribution_domain_name
-        zone_id = module.cdn.cloudfront_distribution_hosted_zone_id
+        name                   = module.cdn.cloudfront_distribution_domain_name
+        zone_id                = module.cdn.cloudfront_distribution_hosted_zone_id
+        evaluate_target_health = false
       }
     }
 
@@ -207,8 +210,9 @@ module "dns_records" {
       type            = "AAAA"
       allow_overwrite = true
       alias = {
-        name    = module.cdn.cloudfront_distribution_domain_name
-        zone_id = module.cdn.cloudfront_distribution_hosted_zone_id
+        name                   = module.cdn.cloudfront_distribution_domain_name
+        zone_id                = module.cdn.cloudfront_distribution_hosted_zone_id
+        evaluate_target_health = false
       }
     }
   }

playwright.config.ts

@@ -1,9 +1,7 @@
 import "dotenv/config";
 import { defineConfig, devices } from "@playwright/test";
 
-const PORT = process.env.PORT ?? "3000";
-const HOST = process.env.HOST ?? "127.0.0.1";
-const baseURL = process.env.PLAYWRIGHT_BASE_URL ?? `http://${HOST}:${PORT}`;
+const BASE_URL = "http://localhost:3000";
 
 export default defineConfig({
   testDir: "./tests/e2e",
@@ -26,7 +24,7 @@ export default defineConfig({
     ],
   ],
   use: {
-    baseURL,
+    baseURL: BASE_URL,
     trace: "retain-on-failure",
     screenshot: "only-on-failure",
     video: "retain-on-failure",
@@ -38,9 +36,9 @@ export default defineConfig({
     },
   ],
   webServer: {
-    command: `npm run dev -- --hostname ${HOST} --port ${PORT}`,
-    url: baseURL,
+    command: "npm run start",
+    url: BASE_URL,
     reuseExistingServer: !process.env.CI,
-    timeout: 120_000,
+    timeout: 10_000,
   },
 });