Beta theme feature#10
Open
x34-dzt wants to merge 2 commits into
Open
Conversation
added 2 commits
August 9, 2024 19:31
Hello I tried to add the theme feature, this is just a beta version, I will later add the search option, and more themes, just wanted to see if my code is ok with you :)
Owner
|
thank you so much for the PR, this will be pushed to v2 alongside with #11 |
Contributor
Author
|
Hey thanks, but can I also add all those functionalities that I mentioned such as searching theme, applying the theme, and then storing it in localstorage? |
Owner
|
sure, go for it :) |
Contributor
Author
Okie~ but I will do it after or few days, I am extremely busy atm T--T |
Contributor
|
Please remove console.log from js/bg.js line 7 |
Owner
|
@DMZTdhruv sorry for the late reply, will have a look later today :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added comments to explain them better, kindly check them >v<