fix: pass cwd to node-resolve (#68)

* fix: correct issue with cwd that was not letting relative imports work. see #66

* fix: remove absRoot plugin and change node-resolve config.

Author: Arcath

README.md

@@ -206,7 +206,7 @@ This module is distributed via [npm][npm] which is bundled with [node][node] and
 should be installed as one of your project's `dependencies`:
 
 ```
-npm install --save mdx-bundler
+npm install --save mdx-bundler esbuild
 ```
 
 One of mdx-bundler's dependancies requires a working [node-gyp][node-gyp] setup

package.json

@@ -42,20 +42,20 @@
   "dependencies": {
     "@babel/runtime": "^7.14.6",
     "@esbuild-plugins/node-resolve": "^0.1.4",
-    "@fal-works/esbuild-plugin-global-externals": "^2.1.1",
+    "@fal-works/esbuild-plugin-global-externals": "^2.1.2",
     "gray-matter": "^4.0.3",
     "remark-frontmatter": "^3.0.0",
     "remark-mdx-frontmatter": "^1.0.1",
-    "xdm": "^1.11.1"
+    "xdm": "^1.12.1"
   },
   "peerDependencies": {
     "esbuild": "0.11.x || 0.12.x"
   },
   "devDependencies": {
     "@testing-library/react": "^12.0.0",
-    "@types/jsdom": "^16.2.12",
-    "@types/react": "^17.0.13",
-    "@types/react-dom": "^17.0.8",
+    "@types/jsdom": "^16.2.13",
+    "@types/react": "^17.0.14",
+    "@types/react-dom": "^17.0.9",
     "cross-env": "^7.0.3",
     "esbuild": "^0.12.15",
     "jsdom": "^16.6.0",
@@ -64,7 +64,7 @@
     "mdx-test-data": "^1.0.1",
     "react": "^17.0.2",
     "react-dom": "^17.0.2",
-    "remark-mdx-images": "^1.0.2",
+    "remark-mdx-images": "^1.0.3",
     "typescript": "^4.3.5",
     "uvu": "^0.5.1"
   },

src/__tests__/index.js

@@ -152,7 +152,7 @@ import Demo from './demo'
   assert.equal(
     error.message,
     `Build failed with 1 error:
-__mdx_bundler_fake_dir__/_mdx_bundler_entry_point.mdx:3:17: error: Could not resolve "./demo"`,
+_mdx_bundler_entry_point.mdx:3:17: error: Could not resolve "./demo"`,
   )
 })
 
@@ -174,7 +174,7 @@ import Demo from './demo'
   assert.equal(
     error.message,
     `Build failed with 1 error:
-__mdx_bundler_fake_dir__/demo.tsx:1:7: error: Could not resolve "./blah-blah"`,
+demo.tsx:1:7: error: Could not resolve "./blah-blah"`,
   )
 })
 
@@ -196,7 +196,7 @@ import Demo from './demo.blah'
   assert.equal(
     error.message,
     `Build failed with 1 error:
-__mdx_bundler_fake_dir__/_mdx_bundler_entry_point.mdx:3:17: error: [plugin: inMemory] Invalid loader: "blah" (valid: js, jsx, ts, tsx, css, json, text, base64, dataurl, file, binary)`,
+_mdx_bundler_entry_point.mdx:3:17: error: [plugin: inMemory] Invalid loader: "blah" (valid: js, jsx, ts, tsx, css, json, text, base64, dataurl, file, binary)`,
   )
 })
 
@@ -301,15 +301,15 @@ test('require from current directory', async () => {
   const mdxSource = `
 # Title
 
-import {Sample} from './other/sample-component'
+import {Sample} from './sample-component'
 
 <Sample />
 
-![A Sample Image](./other/150.png)
+![A Sample Image](./150.png)
 `.trim()
 
   const {code} = await bundleMDX(mdxSource, {
-    cwd: process.cwd(),
+    cwd: path.join(process.cwd(), 'other'),
     xdmOptions: options => {
       options.remarkPlugins = [remarkMdxImages]
 
@@ -343,11 +343,11 @@ test('should output assets', async () => {
   const mdxSource = `
 # Sample Post
 
-![Sample Image](./other/150.png)
+![Sample Image](./150.png)
   `.trim()
 
   const {code} = await bundleMDX(mdxSource, {
-    cwd: process.cwd(),
+    cwd: path.join(process.cwd(), 'other'),
     xdmOptions: options => {
       options.remarkPlugins = [remarkMdxImages]
 
@@ -374,7 +374,7 @@ test('should output assets', async () => {
 
   const error = /** @type Error */ (
     await bundleMDX(mdxSource, {
-      cwd: process.cwd(),
+      cwd: path.join(process.cwd(), 'other'),
       xdmOptions: options => {
         options.remarkPlugins = [remarkMdxImages]
 
@@ -452,7 +452,7 @@ import Demo from './demo'
 
 <Demo />
   `.trim()
-  
+
   const result = await bundleMDX(mdxSource, {
     files: {
       './demo.tsx': `
@@ -466,13 +466,15 @@ function Demo() {
 }
 
 export default Demo
-`.trim()
-    }
+`.trim(),
+    },
   })
 
   const Component = getMDXComponent(result.code)
 
-  const {container} = render(React.createElement(Component), { container: document.body })
+  const {container} = render(React.createElement(Component), {
+    container: document.body,
+  })
 
   assert.match(container.innerHTML, 'Portal!')
 })

src/index.js

@@ -123,6 +123,7 @@ async function bundleMDX(
   const buildOptions = esbuildOptions({
     entryPoints: [entryPath],
     write: false,
+    absWorkingDir: cwd,
     define: {
       'process.env.NODE_ENV': JSON.stringify(process.env.NODE_ENV),
     },
@@ -143,7 +144,10 @@ async function bundleMDX(
         },
       }),
       // eslint-disable-next-line @babel/new-cap
-      NodeResolvePlugin({extensions: ['.js', '.ts', '.jsx', '.tsx']}),
+      NodeResolvePlugin({
+        extensions: ['.js', '.ts', '.jsx', '.tsx'],
+        resolveOptions: {basedir: cwd},
+      }),
       inMemoryPlugin,
       xdmESBuild(
         xdmOptions({
@@ -170,6 +174,7 @@ async function bundleMDX(
     return {
       code: `${code};return Component.default;`,
       frontmatter,
+      errors: bundled.errors,
     }
   }
 
@@ -187,6 +192,7 @@ async function bundleMDX(
     return {
       code: `${code};return Component.default;`,
       frontmatter,
+      errors: bundled.errors,
     }
   }