map sa name to nsg key

Author: jksprattler

cloud_Azure/terraform/module/storage_account.tf

@@ -1,14 +1,10 @@
 # Prepare names that meet Azure Storage Account naming restrictions (only alphanum letters, max 24 length, Azure-wide unique)
 # Each output name is concatenation of Resource Group name and Subscription ID, adjusted to naming restrictions
-# Maps each storage account name to a key-value pair indexed by sa0, sa1, etc
 locals {
-  _names                    = [for name in var.resource_group_names : "${name}${var.subscription_id}"]
-  _lowercase_names          = [for name in local._names : lower(name)]
-  _alphanum_lowercase_names = [for name in local._lowercase_names : join("", regexall("[[:alnum:]]+", name))]
-  generated_storage_account_names = {
-    for i, name in local._alphanum_lowercase_names :
-    "sa${i}" => substr(name, 0, 24) # Use the index as a key for sa creation
-  }
+  _names                          = [for name in var.resource_group_names : "${name}${var.subscription_id}"]
+  _lowercase_names                = [for name in local._names : lower(name)]
+  _alphanum_lowercase_names       = [for name in local._lowercase_names : join("", regexall("[[:alnum:]]+", name))]
+  generated_storage_account_names = [for i, name in local._alphanum_lowercase_names : substr(name, 0, 24)]
 }
 
 # Creates one storage account per nsg per resource group to store flow logs
@@ -18,7 +14,7 @@ resource "azurerm_storage_account" "logs_storage_account" {
   for_each = { for nsg in local.flat_nsgs : nsg.key => nsg.value }
 
   # generate storage account per nsg(s) in each rg
-  name                     = local.generated_storage_account_names["sa${each.key}"]
+  name                     = local.generated_storage_account_names[lookup(local.flat_nsgs, each.key, 0)]
   resource_group_name      = each.value.rg
   location                 = var.location
   account_tier             = "Standard"