Remove name normalization (let the API handle it and avoid implicit changes)

Author: aaronfuj

api/client.go

@@ -89,7 +89,7 @@ func (c *Client) GetDeviceByID(did int) (*Device, error) {
 }
 
 func (c *Client) GetDeviceByName(name string) (*Device, error) {
-	return c.getdevice(fmt.Sprintf(c.deviceURL, NormalizeName(name)))
+	return c.getdevice(fmt.Sprintf(c.deviceURL, name))
 }
 
 func (c *Client) GetDeviceByIP(ip net.IP) (*Device, error) {
@@ -208,9 +208,6 @@ func (c *Client) CreateDeviceAndSite(siteDevCreate *SiteAndDeviceCreate) (*Devic
 
 	createUrl := c.API.String() + "/deviceAndSite"
 
-	// Remove chars which result in 500
-	siteDevCreate.Device.NormalizeName()
-
 	body, err := json.Marshal(siteDevCreate)
 	if err != nil {
 		return nil, err
@@ -244,9 +241,6 @@ func (c *Client) CreateDevice(create *DeviceCreate) (*Device, error) {
 		return nil, fmt.Errorf("Missing IP for device")
 	}
 
-	// Remove chars which result in 500
-	create.NormalizeName()
-
 	body, err := json.Marshal(map[string]*DeviceCreate{
 		"device": create,
 	})

api/funcs.go

@@ -3,15 +3,8 @@ package api
 import (
 	"fmt"
 	"net"
-	"strings"
 )
 
-// NormalizeName is a helper for normalization of the devices name into an acceptable format for the Kentik API device
-// endpoints.
-func NormalizeName(name string) string {
-	return strings.Replace(name, ".", "_", -1)
-}
-
 func GetInterfaceUpdates(nif *net.Interface) (map[string]InterfaceUpdate, error) {
 	addrs, err := interfaceAddrs(nif)
 	if err != nil {

api/types.go

@@ -159,7 +159,3 @@ func (c Column) MarshalFlag() (string, error) {
 	b, err := json.Marshal(c)
 	return string(b), err
 }
-
-func (c *DeviceCreate) NormalizeName() {
-	c.Name = NormalizeName(c.Name)
-}

cmd/server/main.go

@@ -6,6 +6,7 @@ import (
 	"os"
 
 	"github.com/jessevdk/go-flags"
+
 	"github.com/kentik/libkflow/api"
 	"github.com/kentik/libkflow/api/test"
 )
@@ -36,7 +37,7 @@ func main() {
 		Token:      "token",
 		CompanyID:  1,
 		DeviceID:   1,
-		DeviceName: api.NormalizeName("dev1"),
+		DeviceName: "dev1",
 		DeviceIP:   "127.0.0.1",
 		Sample:     1,
 		MaxFPS:     4000,