+ better error messages

Author: q3769

pom.xml

@@ -30,7 +30,7 @@
 
     <groupId>io.github.q3769</groupId>
     <artifactId>semver-maven-plugin</artifactId>
-    <version>20240116.0.202408091532</version>
+    <version>20240116.0.202408091618</version>
     <packaging>maven-plugin</packaging>
 
     <name>semver-maven-plugin</name>
@@ -229,7 +229,7 @@
             <plugin>
                 <groupId>io.github.q3769</groupId>
                 <artifactId>semver-maven-plugin</artifactId>
-                <version>20240116.0.202408091532</version>
+                <version>20240116.0.202408091618</version>
             </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>

src/main/java/q3769/maven/plugins/semver/SemverMojo.java

@@ -113,6 +113,14 @@ protected String originalPomVersion() {
     return project.getOriginalModel().getVersion();
   }
 
+  protected void logError(String message, Object... args) {
+    getLog().error(String.format(message, args));
+  }
+
+  protected void logError(Throwable t, String message, Object... args) {
+    getLog().error(String.format(message, args), t);
+  }
+
   protected void logWarn(String message, Object... args) {
     getLog().warn(String.format(message, args));
   }

src/main/java/q3769/maven/plugins/semver/Updater.java

@@ -40,12 +40,14 @@
  */
 public abstract class Updater extends SemverMojo {
   private static final String SNAPSHOT = "SNAPSHOT";
+
   /**
    * Flag to append SNAPSHOT as the prerelease label in the target version. Expected to be passed in
    * as a -D parameter from CLI.
    */
   @Parameter(property = "snapshot", defaultValue = "false")
   protected boolean addingSnapshotLabel;
+
   /** */
   @Component
   protected BuildPluginManager pluginManager;
@@ -67,14 +69,17 @@ protected void doExecute() throws MojoExecutionException, MojoFailureException {
    * @throws MojoFailureException if original version in POM is malformed
    */
   private Version getUpdatedVersion() throws MojoFailureException {
-    Version updatedVersion = update(requireValidSemVer(project.getVersion()));
+    Version original = requireValidSemVer(project.getVersion());
+    Version updatedVersion = update(original);
     if (!addingSnapshotLabel) {
       return updatedVersion;
     }
     if (hasPreReleaseVersionOrBuildMetadata(updatedVersion)) {
-      throw new MojoFailureException(String.format(
-          "snapshot labeling requested for updated semver %s but not honored, because snapshot flag only supports normal version number increments with no labels",
-          updatedVersion));
+      logError(
+          "SNAPSHOT labeling requested for POM version %s but not honored, because SNAPSHOT may collide with other labels in the updated version %s",
+          original, updatedVersion);
+      throw new MojoFailureException(
+          String.format("SNAPSHOT may collide with other labels in %s", updatedVersion));
     }
     logInfo("labeling version %s as a SNAPSHOT...", updatedVersion);
     return addSnapshotLabel(updatedVersion);

src/main/java/q3769/maven/plugins/semver/mojos/CalendarMajor.java

@@ -51,11 +51,12 @@ protected Version update(Version original) throws MojoFailureException {
     try {
       return CalendarVersionFormatter.calendarIncrement(original, SemverNormalVersion.MAJOR);
     } catch (Exception e) {
-      throw new MojoFailureException(
-          String.format(
-              "Failed to increment the %s version of semver %s",
-              SemverNormalVersion.MAJOR, original),
-          e);
+      logError(
+          e,
+          "Failed to calendar-increment the %s version of semver %s",
+          SemverNormalVersion.MAJOR,
+          original);
+      throw new MojoFailureException(e);
     }
   }
 }

src/main/java/q3769/maven/plugins/semver/mojos/CalendarMinor.java

@@ -44,11 +44,12 @@ protected Version update(Version original) throws MojoFailureException {
     try {
       return CalendarVersionFormatter.calendarIncrement(original, SemverNormalVersion.MINOR);
     } catch (Exception e) {
-      throw new MojoFailureException(
-          String.format(
-              "Failed to increment the %s version of semver %s",
-              SemverNormalVersion.MINOR, original),
-          e);
+      logError(
+          e,
+          "Failed to calendar-increment the %s version of semver %s",
+          SemverNormalVersion.MINOR,
+          original);
+      throw new MojoFailureException(e);
     }
   }
 }

src/main/java/q3769/maven/plugins/semver/mojos/CalendarPatch.java

@@ -44,11 +44,12 @@ protected Version update(Version original) throws MojoFailureException {
     try {
       return CalendarVersionFormatter.calendarIncrement(original, SemverNormalVersion.PATCH);
     } catch (Exception e) {
-      throw new MojoFailureException(
-          String.format(
-              "Failed to increment the %s version of semver %s",
-              SemverNormalVersion.PATCH, original),
-          e);
+      logError(
+          e,
+          "Failed to calendar-increment the %s version of semver %s",
+          SemverNormalVersion.PATCH,
+          original);
+      throw new MojoFailureException(e);
     }
   }
 }

src/main/java/q3769/maven/plugins/semver/mojos/IncrementMajor.java

@@ -43,8 +43,8 @@ protected Version update(@NonNull Version original) throws MojoFailureException
     try {
       return original.nextMajorVersion();
     } catch (Exception e) {
-      throw new MojoFailureException(
-          "Failed to increment the major version of semver " + original, e);
+      logError(e, "Failed to increment the major version of semver %s", original);
+      throw new MojoFailureException(e);
     }
   }
 }

src/main/java/q3769/maven/plugins/semver/mojos/IncrementMinor.java

@@ -43,8 +43,8 @@ protected Version update(@NonNull Version original) throws MojoFailureException
     try {
       return original.nextMinorVersion();
     } catch (Exception e) {
-      throw new MojoFailureException(
-          "Failed to increment the minor version of semver " + original, e);
+      logError(e, "Failed to increment the minor version of semver %s", original);
+      throw new MojoFailureException(e);
     }
   }
 }

src/main/java/q3769/maven/plugins/semver/mojos/IncrementPatch.java

@@ -43,8 +43,8 @@ protected Version update(@NonNull Version original) throws MojoFailureException
     try {
       return original.nextPatchVersion();
     } catch (Exception e) {
-      throw new MojoFailureException(
-          "Failed to increment the patch version of semver " + original, e);
+      logError(e, "Failed to increment the patch version of semver %s", original);
+      throw new MojoFailureException(e);
     }
   }
 }

src/main/java/q3769/maven/plugins/semver/mojos/Merge.java

@@ -67,10 +67,9 @@ protected Version update(final Version original) throws MojoFailureException {
     try {
       incrementedVersion = increment(other, pomIncrementedNormalVersion);
     } catch (Exception e) {
-      throw new MojoFailureException(
-          String.format(
-              "Failed to merge the provided version %s with the POM version %s", other, original),
-          e);
+      logError(
+          e, "Failed to merge the provided version %s with the POM version %s", other, original);
+      throw new MojoFailureException(e);
     }
     logDebug(
         "Incrementing provided version %s on POM semver incremented normal version %s, provisional merge version: %s",