Update keras-io to include KerasHub #1940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divyashreepathihalli
requested review from
MarkDaoust,
fchollet and
pcoet
as code owners
fchollet
reviewed
Sep 30, 2024
Contributor
fchollet
left a comment
fchollet
left a comment
There was a problem hiding this comment.
Thanks for the PR! Can you look into the test failure?
3.709 FileNotFoundError: [Errno 2] No such file or directory: '/templates/guides/keras_nlp/upload.md'
| "colab": { | ||
| "collapsed_sections": [], | ||
| "name": "gpt2_text_generation_with_kerasnlp", | ||
| "name": "gpt2_text_generation_with_kerashub", |
Contributor
There was a problem hiding this comment.
If any URLs are getting switched from kerasnlp to kerashub, we need to add redirects for them. Please add entries in the redirects/ directory.
Collaborator
Author
There was a problem hiding this comment.
The updates have been made to files in the redirects folder.
Collaborator
Author
The test failure has been has been fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR contains the following changes