Skip to content

Conversation

@pksX01
Copy link
Contributor

@pksX01 pksX01 commented Oct 3, 2024

This PR caters the upgradation of Cycelgan example to Keras 3 (with Tensorflow backend) from Keras 2.

Changes

  • Since weight load format is changes in Keras 3, pre-trained weight could not be loaded. Hence, changed the epochs to 90 (as equivalent to original training).
  • Replaced Tensorflow specific operations with Keras backend-agnostic equivalents wherever possible.

@google-cla
Copy link

google-cla bot commented Oct 3, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@pksX01
Copy link
Contributor Author

pksX01 commented Oct 3, 2024

@sachinprasadhs could you please review this PR

Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conversion looks good! Please add the autogenerated .md and .ipynb files.

Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Please add the generated files.

@pksX01
Copy link
Contributor Author

pksX01 commented Oct 28, 2024

@fchollet added ipynb and md files

Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! It seems the training logs are very large and are taking up a lot of space in the .md, can you erase them by hand? They don't need to be rendered.

@pksX01
Copy link
Contributor Author

pksX01 commented Oct 28, 2024

Thank you! It seems the training logs are very large and are taking up a lot of space in the .md, can you erase them by hand? They don't need to be rendered.

@fchollet Removed training logs.

Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@fchollet fchollet merged commit 71c53a6 into keras-team:master Oct 28, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants