Example for STFTSpectrogram layer
#1947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fchollet
reviewed
Oct 12, 2024
Contributor
fchollet
left a comment
fchollet
left a comment
There was a problem hiding this comment.
Thanks for the PR! The code generally looks good!
Contributor
Author
|
@fchollet I resolved all the comments. |
fchollet
approved these changes
Oct 15, 2024
Contributor
fchollet
left a comment
fchollet
left a comment
There was a problem hiding this comment.
Very nice! My only comment is very minor, so we can merge now.
| from keras import layers | ||
| from scipy.signal import resample | ||
|
|
||
| np.random.seed(41) |
Contributor
There was a problem hiding this comment.
The numpy seeding is already included as part of set_random_seed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussion on the contribution of the
STFTSpectrogramlayer (PR: 20313), I added a code example of using this layer in various modes.