Skip to content

Conversation

@james77777778
Copy link
Contributor

@divyashreepathihalli

This guide covers all the APIs for SD3 in KerasHub. Please let me know if any changes are required.

Copy link
Collaborator

@divyashreepathihalli divyashreepathihalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this super cool guide @james77777778!! I have left a few comments.

float16.

It is also worth noting that the preset "stable_diffusion_3_medium" excludes the
T5XXL text encoder, as it requires significantly more GPU memory. The performace
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe also add content on if users wanted to try it with T5XXL text encoder, how can they do that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added this line:

The weights, including T5XXL, will be available on KerasHub soon.

display_image = concate_images([np.array(image), generated_image])
plt.axis("off")
plt.imshow(display_image)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explain the output that is seen here with 1 or 2 lines

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added:

As you can see, a new image is generated based on the reference image and the
prompt.

)
plt.axis("off")
plt.imshow(display_image)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add few lines here explaining the output.

Copy link
Contributor Author

@james77777778 james77777778 Oct 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added:

Fantastic! The dog is replaced by a cute black cat, but unlike image-to-image,
the background is preserved.

Note that inpainting task also includes `strength` parameter to control the
image generation, with the default value of `0.6` in Stable Diffusion 3.

@james77777778
Copy link
Contributor Author

james77777778 commented Oct 13, 2024

@divyashreepathihalli
Thank you for the detailed review. The comments should now be addressed.

EDITED:
I've added the description of the strength parameter in the guide as well.

Copy link
Collaborator

@divyashreepathihalli divyashreepathihalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Hongyu! LGTM

@fchollet fchollet merged commit 12ad7e9 into keras-team:master Oct 15, 2024
1 check passed
@james77777778 james77777778 deleted the add-sd3-guide branch October 16, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants