-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Fix nnx guide error #2183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nnx guide error #2183
Conversation
Summary of ChangesHello @divyashreepathihalli, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses a TypeError in the Keras NNX guide caused by a deprecated wrt argument in nnx.grad. The fix correctly updates the API usage to argnums with nnx.DiffState across the notebook, Python script, and markdown files. The changes are correct and resolve the issue. I've added a few suggestions to inline the nnx.DiffState creation for better code conciseness in the guide examples.
| " diff_state = nnx.DiffState(0, trainable_var)\n", | ||
| " grads = nnx.grad(loss_fn, argnums=diff_state)(model)\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For conciseness, you can inline the creation of nnx.DiffState directly into the nnx.grad call. This removes the need for a temporary variable and makes the code a single, expressive line.
| " diff_state = nnx.DiffState(0, trainable_var)\n", | |
| " grads = nnx.grad(loss_fn, argnums=diff_state)(model)\n", | |
| " grads = nnx.grad(loss_fn, argnums=nnx.DiffState(0, trainable_var))(model)\n", |
| diff_state = nnx.DiffState(0, trainable_var) | ||
| grads = nnx.grad(loss_fn, argnums=diff_state)(model) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For conciseness, you can inline the creation of nnx.DiffState directly into the nnx.grad call. This removes the need for a temporary variable and makes the code a single, expressive line.
| diff_state = nnx.DiffState(0, trainable_var) | |
| grads = nnx.grad(loss_fn, argnums=diff_state)(model) | |
| grads = nnx.grad(loss_fn, argnums=nnx.DiffState(0, trainable_var))(model) |
| diff_state = nnx.DiffState(0, trainable_var) | ||
| grads = nnx.grad(loss_fn, argnums=diff_state)(model) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For conciseness, you can inline the creation of nnx.DiffState directly into the nnx.grad call. This removes the need for a temporary variable and makes the code a single, expressive line. This can help keep code examples in the guide clean and focused.
| diff_state = nnx.DiffState(0, trainable_var) | |
| grads = nnx.grad(loss_fn, argnums=diff_state)(model) | |
| grads = nnx.grad(loss_fn, argnums=nnx.DiffState(0, trainable_var))(model) |
fixes this error in the guide : TypeError: got an unexpected keyword argument 'wrt'