Skip to content

add survey to nav bar #2184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2025
Merged

add survey to nav bar #2184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions theme/base.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@
'/keras_tuner/': 'Keras Tuner',
'/keras_rs/': 'Keras RS',
'/keras_hub/': 'Keras Hub',
'https://google.qualtrics.com/jfe/form/SV_5psTvNYQKv2mAwC': '2025 Survey',
} %}
<ul class="nav__item--container">
{% for key, value in main_nav_items.items() %}
Expand Down
2 changes: 2 additions & 0 deletions theme/keras_3.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@
<a class="nav-link" href="/2.18/api/" role="tab" aria-selected="">Keras 2 API documentation</a>
<a class="nav-link" href="/keras_tuner/" role="tab" aria-selected="">KerasTuner: Hyperparam Tuning</a>
<a class="nav-link" href="/keras_hub/" role="tab" aria-selected="">KerasHub: Pretrained Models</a>
<a class="nav-link" href="https://google.qualtrics.com/jfe/form/SV_5psTvNYQKv2mAwC" role="tab" aria-selected="" style="color:blue;">2025 Survey</a>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This line has two areas for improvement:

  1. Hardcoded URL: The survey URL is hardcoded. Since this URL is used in multiple files, it's best to define it as a Jinja variable (e.g., survey_url) and reuse it. This will make future updates much easier.

  2. Inline CSS: Using style="color:blue;" is not ideal for maintainability. It's better practice to move this styling to a CSS file. You could create a new class, for example .nav__link--highlight, in your CSS and apply it to the link.

Here's a suggested change that addresses the inline style. Please also address the hardcoded URL by defining and using a variable.

          <a class="nav-link nav__link--highlight" href="https://google.qualtrics.com/jfe/form/SV_5psTvNYQKv2mAwC" role="tab" aria-selected="">2025 Survey</a>

</div>
</div>
<a href="/">
Expand All @@ -121,6 +122,7 @@
<li class="nav__item"><a class="nav__link" href="/keras_tuner/">KERAS TUNER</a></li>
<li class="nav__item"><a class="nav__link" href="/keras_rs/">KERAS RS</a></li>
<li class="nav__item"><a class="nav__link" href="/keras_hub/">KERAS HUB</a></li>
<li class="nav__item"><a class="nav__link" href="https://google.qualtrics.com/jfe/form/SV_5psTvNYQKv2mAwC" style="color:blue;">2025 SURVEY</a></li>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Similar to the previous comment, this line has a hardcoded URL and an inline style.

  1. Hardcoded URL: Please replace the hardcoded URL with a variable for better maintainability.

  2. Inline CSS: The style="color:blue;" should be replaced with a CSS class. You can reuse the class suggested previously (e.g., nav__link--highlight).

          <li class="nav__item"><a class="nav__link nav__link--highlight" href="https://google.qualtrics.com/jfe/form/SV_5psTvNYQKv2mAwC">2025 SURVEY</a></li>

</ul>

<form class="nav__search">
Expand Down
6 changes: 4 additions & 2 deletions theme/landing.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@
<a class="nav-link" href="/2.18/api/" role="tab" aria-selected="">Keras 2 API documentation</a>
<a class="nav-link" href="/keras_tuner/" role="tab" aria-selected="">KerasTuner: Hyperparam Tuning</a>
<a class="nav-link" href="/keras_hub/" role="tab" aria-selected="">KerasHub: Pretrained Models</a>
<a class="nav-link" href="https://google.qualtrics.com/jfe/form/SV_5psTvNYQKv2mAwC" role="tab" aria-selected="">Take Our Survey!</a>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The survey URL is hardcoded here. To improve maintainability, please define this URL as a Jinja variable at the top of the file (e.g., {% set survey_url = '...' %}) and reference the variable here. This will make it easier to update the URL in the future, as it's used in multiple places.

</div>
</div>
<a href="/">
Expand All @@ -149,6 +150,7 @@
<li class="nav__item"><a class="nav__link" href="/keras_tuner/">KERAS TUNER</a></li>
<li class="nav__item"><a class="nav__link" href="/keras_rs/">KERAS RS</a></li>
<li class="nav__item"><a class="nav__link" href="/keras_hub/">KERAS HUB</a></li>
<li class="nav__item"><a class="nav__link" href="https://google.qualtrics.com/jfe/form/SV_5psTvNYQKv2mAwC" style="color:blue;">2025 SURVEY</a></li>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This line contains a hardcoded URL and an inline style, which should be addressed.

  1. Hardcoded URL: Please use a variable for the URL, as mentioned in previous comments.

  2. Inline CSS: The style="color:blue;" should be replaced by a CSS class (e.g., nav__link--highlight) for better separation of concerns and maintainability.

Suggested change
<li class="nav__item"><a class="nav__link" href="https://google.qualtrics.com/jfe/form/SV_5psTvNYQKv2mAwC" style="color:blue;">2025 SURVEY</a></li>
<li class="nav__item"><a class="nav__link nav__link--highlight" href="https://google.qualtrics.com/jfe/form/SV_5psTvNYQKv2mAwC">2025 SURVEY</a></li>

</ul>

<form class="nav__search">
Expand All @@ -170,7 +172,7 @@
<div class="hero">
<div class="hero__content--wrapper">
<div class="hero__content">
<a class="button__round" href="/keras_3/">KERAS 3.0 RELEASED</a>
<a class="button__round" href="https://google.qualtrics.com/jfe/form/SV_5psTvNYQKv2mAwC">TAKE OUR SURVEY!</a>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The survey URL is hardcoded here as well. Please replace it with a reusable Jinja variable to improve maintainability.


<h1 class="hero__title text--white">A superpower for ML developers</h1>

Expand Down Expand Up @@ -698,4 +700,4 @@ <h2 class="contacts__title text--white">Contributions welcome!</h2>
<script src="./js/prism.min.js"></script>
<script src="./js/prism-python.min.js"></script>
</body>
</html>
</html>