-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Adds 4-bit Integer Quantization Documentation #2194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @JyotinderSingh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces comprehensive documentation for 4-bit integer quantization (INT4) within the Keras framework. The new guide explains the principles, benefits, and practical application of INT4 quantization, including code examples for both custom and KerasHub models. It also provides detailed performance benchmarks across various model types and offers guidance on its appropriate use and limitations, thereby enhancing Keras's capabilities for efficient model deployment. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds excellent and thorough documentation for INT4 quantization in Keras. The guide is well-written, covering the topic from theory to practice with useful code examples and performance benchmarks. This is a great contribution to the Keras documentation. I have only one minor suggestion for a grammatical correction to enhance clarity.
|
|
||
| ### Text Classification (DistilBERT Base on SST-2) | ||
|
|
||
| <img class="k-inline-icon" src="https://colab.research.google.com/img/colab_favicon.ico"/> [**View in Colab**](https://colab.research.google.com/gist/JyotinderSingh/77e874187d6da3f8280c053192f78c06/int4-quantization-micro-benchmark-distilbert.ipynb) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these links going stay in the long run?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll keep them live, but I'm going to replace the links with a permanent version as soon as I figure out the best long-term solution.
|
@JyotinderSingh Can you rebase? I don't know which guide you want first in the menu, the int8 one or the int4 one? |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
a527eaa to
fa935b2
Compare
Resolved the conflicts |
No description provided.