Fix typos in Getting Started With KerasHub#2235
Fix typos in Getting Started With KerasHub#2235darmendariz wants to merge 1 commit intokeras-team:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @darmendariz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the 'Getting Started With KerasHub' guide by addressing various textual and formatting inconsistencies across its Jupyter Notebook, Python script, and Markdown versions. The changes aim to enhance the clarity, accuracy, and overall professional presentation of the documentation, providing a more polished and error-free learning resource for users. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request fixes several typos across the KerasHub getting started guide in the notebook, Python, and Markdown files. The changes are correct and improve the readability of the documentation. I've found one additional minor issue in the description of AudioConverter that seems to be a copy-paste error, which I've commented on. Overall, great work on catching these typos and ensuring consistency across the different file formats!
| " preprocessing.\n", | ||
| " * **Inherits from**: `keras.layers.Layer`.\n", | ||
| "* **AudioConveter**: `keras_hub.layers.AudioConveter`.\n", | ||
| "* **AudioConverter**: `keras_hub.layers.AudioConverter`.\n", |
There was a problem hiding this comment.
Thanks for correcting the AudioConverter typo. While reviewing, I noticed a small copy-paste error in the description for this class on line 176. It says it 'encapsulates the image specific preprocessing', which seems incorrect for an audio converter. It should likely be 'audio specific preprocessing'. Would you mind fixing that as well?
| preprocessing. | ||
| * **Inherits from**: `keras.layers.Layer`. | ||
| * **AudioConveter**: `keras_hub.layers.AudioConveter`. | ||
| * **AudioConverter**: `keras_hub.layers.AudioConverter`. |
There was a problem hiding this comment.
Thanks for correcting the AudioConverter typo. While reviewing, I noticed a small copy-paste error in the description for this class on line 123. It says it 'encapsulates the image specific preprocessing', which seems incorrect for an audio converter. It should likely be 'audio specific preprocessing'. Would you mind fixing that as well?
| preprocessing. | ||
| * **Inherits from**: `keras.layers.Layer`. | ||
| * **AudioConveter**: `keras_hub.layers.AudioConveter`. | ||
| * **AudioConverter**: `keras_hub.layers.AudioConverter`. |
There was a problem hiding this comment.
Thanks for correcting the AudioConverter typo. While reviewing, I noticed a small copy-paste error in the description for this class on line 121. It says it 'encapsulates the image specific preprocessing', which seems incorrect for an audio converter. It should likely be 'audio specific preprocessing'. Would you mind fixing that as well?
amend commit #
darmendariz
force-pushed
the
fix-typos-in-keras_hub-getting-started
branch
from
d03b888 to
4ef6574
Compare
2 participants
Noticed a few minor typos while reading the KerasHub Getting Started Guide. Per the keras-io ReadMe (Fixing Typos), I made the same edits in the corresponding
.py,.ipynb, and.mdfiles.