Always use run_tpu_tests label to run the TPU tests.

Problem: the current approach creates two entries for TPU tests: one for `pull_request` and one for `pull_request_review`. But we only want one entry and one run of the tests.

Solution: we are reusing the current labeler workflow to label the PR on approval, which in turn triggers the TPU tests.

Also fix indentation in `labeler.js` and rename `welcome`.

Author: hertschuh

.github/workflows/labeler.yaml

@@ -24,15 +24,23 @@ on:
     types: [edited,opened]
   pull_request_target:
     types: [opened, edited]
+  pull_request_review:
+    types: [submitted]
 
 permissions:
   contents: read
   issues: write
   pull-requests: write
 
 jobs:
-  welcome:
+  add_labels:
     runs-on: ubuntu-latest
+    # Only run on "approved" reviews for the "pull_request_review" event.
+    # We test here because the script does not get the review information.
+    if: |
+      github.event_name != 'pull_request_review' ||
+      github.event.review.state == 'approved'
+
     steps:
       - uses: actions/checkout@v5
       - uses: actions/github-script@v8

.github/workflows/scripts/labeler.js

@@ -22,28 +22,34 @@ You may obtain a copy of the License at
  */
 
 module.exports = async ({ github, context }) => {
+  const labelsToAdd = []
+  if (context.eventName == 'pull_request_review') {
+    const issue_number = context.payload.pull_request.number
+    labelsToAdd.push('run_tpu_tests')
+    console.log(`Pull request review event. Pushing label 'run_tpu_tests' to row.`)
+  } else {
     const issue_title = context.payload.issue ?  context.payload.issue.title : context.payload.pull_request.title
     const issue_description = context.payload.issue ? context.payload.issue.body : context.payload.pull_request.body
     const issue_number = context.payload.issue ? context.payload.issue.number : context.payload.pull_request.number
     const keyword_label =  {
-         gemma:'Gemma'
+      gemma:'Gemma'
     }
-    const labelsToAdd = []
     console.log(issue_title,issue_description,issue_number)
 
     for(const [keyword, label] of Object.entries(keyword_label)){
-     if(issue_title.toLowerCase().indexOf(keyword) !=-1 || issue_description.toLowerCase().indexOf(keyword) !=-1 ){
+      if(issue_title.toLowerCase().indexOf(keyword) !=-1 || issue_description.toLowerCase().indexOf(keyword) !=-1 ){
         console.log(`'${keyword}'keyword is present inside the title or description. Pushing label '${label}' to row.`)
         labelsToAdd.push(label)
+      }
     }
-   }
-   if(labelsToAdd.length > 0){
+  }
+  if (labelsToAdd.length > 0) {
     console.log(`Adding labels ${labelsToAdd} to the issue '#${issue_number}'.`)
-     github.rest.issues.addLabels({
-        owner: context.repo.owner,
-        repo: context.repo.repo,
-        issue_number: context.issue.number,
-        labels: labelsToAdd
-     })
-   }
-};
+    github.rest.issues.addLabels({
+      owner: context.repo.owner,
+      repo: context.repo.repo,
+      issue_number: issue_number,
+      labels: labelsToAdd
+    })
+  }
+};

.github/workflows/tpu_tests.yml

@@ -8,8 +8,6 @@ on:
     branches: [ master ]
   pull_request:
     types: [labeled]
-  pull_request_review:
-    types: [submitted]
   release:
     types: [created]
 
@@ -25,8 +23,7 @@ jobs:
     if: |
       github.event_name == 'push' ||
       github.event_name == 'release' ||
-      (github.event_name == 'pull_request' && github.event.action == 'labeled' && github.event.label.name == 'run_tpu_tests') ||
-      (github.event_name == 'pull_request_review' && github.event.review.state == 'approved')
+      (github.event_name == 'pull_request' && github.event.action == 'labeled' && github.event.label.name == 'run_tpu_tests')
 
     strategy:
       fail-fast: false