Skip to content

Commit e501d62

Browse files
authored
Merge branch 'keras-team:master' into master
2 parents c826753 + 7598c3e commit e501d62

File tree

3 files changed

+28
-0
lines changed

3 files changed

+28
-0
lines changed

.gemini/config.yaml

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
have_fun: false
2+
memory_config:
3+
disabled: false
4+
code_review:
5+
disable: false
6+
comment_severity_threshold: MEDIUM
7+
max_review_comments: -1
8+
pull_request_opened:
9+
help: true
10+
summary: true
11+
code_review: true
12+
include_drafts: true
13+
ignore_patterns: []

.gemini/styleguide.md

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -203,3 +203,17 @@ y_binary = to_categorical(y_int)
203203
204204
Alternatively, you can use the loss function `sparse_categorical_crossentropy` instead, which does expect integer targets.
205205
```
206+
207+
---
208+
209+
When performing code reviews on pull requests, you must strictly adhere to the following principles in addition to the API design guidelines above:
210+
211+
1. **Question the Necessity of Changes**: Do not assume that the pull request changes are strictly necessary. Critically review the proposed changes to ensure they add real value. Point out any code that is solving a non-existent problem or adding unnecessary complexity.
212+
213+
2. **Call out "AI Slop"**: Actively look for and identify "AI slop"—generic, overly verbose, or hallucinated code that lacks context or violates best practices. If you suspect the code is AI slop, explicitly call it out.
214+
215+
3. **Poke Holes in the Implementation**: Your goal is to critically test the logic. Actively search for and point out failing edge cases, race conditions, or unhandled exceptions in the implementation.
216+
217+
4. **Demand Robustness**: Do not accept fragile code. If the proposed code is not robust enough or lacks proper error handling, explicitly tell the author why the current approach is brittle and what must be done to reinforce it.
218+
219+
5. **Respect Existing Repo Patterns**: Before suggesting review comments (like asking users to add boilerplate or specific patterns), actively check for existing design patterns across the repository. Do not suggest adding useless code or structures that contradict or fall outside the established Keras repo coding style.

requirements-common.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ requests
1212
h5py
1313
ml-dtypes
1414
protobuf
15+
tensorboard
1516
tensorboard-plugin-profile
1617
rich
1718
build

0 commit comments

Comments
 (0)