Migrate decorator, runner, and CLI tests from pytest to absl testing

Author: JyotinderSingh

keras_remote/cli/test_prerequisites_check.py

@@ -1,7 +1,9 @@
 """Tests for keras_remote.cli.prerequisites_check — tool availability checks."""
 
+from unittest import mock
+
 import click
-import pytest
+from absl.testing import absltest, parameterized
 
 from keras_remote.cli.prerequisites_check import (
   check_docker,
@@ -12,56 +14,94 @@
 )
 
 
-@pytest.mark.parametrize(
-  ("check_fn", "error_match"),
-  [
-    (check_gcloud, "gcloud CLI not found"),
-    (check_pulumi, "Pulumi CLI not found"),
-    (check_kubectl, "kubectl not found"),
-    (check_docker, "Docker not found"),
-  ],
-  ids=["gcloud", "pulumi", "kubectl", "docker"],
-)
-class TestToolChecks:
-  def test_present(self, mocker, check_fn, error_match):
-    mocker.patch("shutil.which", return_value="/usr/bin/tool")
-    check_fn()
+class TestToolChecks(parameterized.TestCase):
+  @parameterized.named_parameters(
+    dict(
+      testcase_name="gcloud",
+      check_fn=check_gcloud,
+      error_match="gcloud CLI not found",
+    ),
+    dict(
+      testcase_name="pulumi",
+      check_fn=check_pulumi,
+      error_match="Pulumi CLI not found",
+    ),
+    dict(
+      testcase_name="kubectl",
+      check_fn=check_kubectl,
+      error_match="kubectl not found",
+    ),
+    dict(
+      testcase_name="docker",
+      check_fn=check_docker,
+      error_match="Docker not found",
+    ),
+  )
+  def test_present(self, check_fn, error_match):
+    with mock.patch("shutil.which", return_value="/usr/bin/tool"):
+      check_fn()
 
-  def test_missing(self, mocker, check_fn, error_match):
-    mocker.patch("shutil.which", return_value=None)
-    with pytest.raises(click.ClickException, match=error_match):
+  @parameterized.named_parameters(
+    dict(
+      testcase_name="gcloud",
+      check_fn=check_gcloud,
+      error_match="gcloud CLI not found",
+    ),
+    dict(
+      testcase_name="pulumi",
+      check_fn=check_pulumi,
+      error_match="Pulumi CLI not found",
+    ),
+    dict(
+      testcase_name="kubectl",
+      check_fn=check_kubectl,
+      error_match="kubectl not found",
+    ),
+    dict(
+      testcase_name="docker",
+      check_fn=check_docker,
+      error_match="Docker not found",
+    ),
+  )
+  def test_missing(self, check_fn, error_match):
+    with (
+      mock.patch("shutil.which", return_value=None),
+      self.assertRaisesRegex(click.ClickException, error_match),
+    ):
       check_fn()
 
 
-class TestCheckGcloudAuth:
-  def test_token_success(self, mocker):
+class TestCheckGcloudAuth(absltest.TestCase):
+  def test_token_success(self):
     """When print-access-token succeeds, no login is triggered."""
-    mock_run = mocker.patch(
+    with mock.patch(
       "keras_remote.cli.prerequisites_check.subprocess.run",
-    )
-    mock_run.return_value.returncode = 0
-
-    check_gcloud_auth()
+    ) as mock_run:
+      mock_run.return_value.returncode = 0
+      check_gcloud_auth()
+      # Only called once (the token check), not a second time for login
+      self.assertEqual(mock_run.call_count, 1)
 
-    # Only called once (the token check), not a second time for login
-    assert mock_run.call_count == 1
-
-  def test_token_failure_triggers_login(self, mocker):
+  def test_token_failure_triggers_login(self):
     """When print-access-token fails, gcloud auth login is run."""
-    mock_run = mocker.patch(
-      "keras_remote.cli.prerequisites_check.subprocess.run",
-    )
-    # First call = token check (fails), second call = login (succeeds)
-    token_result = mocker.MagicMock()
-    token_result.returncode = 1
-    mock_run.return_value = token_result
+    with (
+      mock.patch(
+        "keras_remote.cli.prerequisites_check.subprocess.run",
+      ) as mock_run,
+      mock.patch("keras_remote.cli.prerequisites_check.warning"),
+      mock.patch("click.echo"),
+    ):
+      token_result = mock.MagicMock()
+      token_result.returncode = 1
+      mock_run.return_value = token_result
+
+      check_gcloud_auth()
 
-    mocker.patch("keras_remote.cli.prerequisites_check.warning")
-    mocker.patch("click.echo")
+      self.assertEqual(mock_run.call_count, 2)
+      # Second call should be the login command
+      login_call = mock_run.call_args_list[1]
+      self.assertIn("login", login_call[0][0])
 
-    check_gcloud_auth()
 
-    assert mock_run.call_count == 2
-    # Second call should be the login command
-    login_call = mock_run.call_args_list[1]
-    assert "login" in login_call[0][0]
+if __name__ == "__main__":
+  absltest.main()