Add pyproject.toml support for container dependency installs#84
Add pyproject.toml support for container dependency installs#84JyotinderSingh merged 2 commits intomainfrom
pyproject.toml support for container dependency installs#84Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances Keras Remote's dependency management by introducing support for Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for pyproject.toml as an alternative to requirements.txt for specifying container dependencies, which is a valuable enhancement. The implementation is well-structured, with clear logic and comprehensive unit and end-to-end tests. The documentation and user-facing messages have also been updated accordingly. I have one suggestion to improve type consistency in the new parsing function. Overall, this is a high-quality contribution.
| def _parse_pyproject_dependencies(pyproject_path: str) -> str | None: | ||
| """Extract ``[project.dependencies]`` from a pyproject.toml file. | ||
|
|
||
| Reads only the core dependency list defined under the ``[project]`` table. | ||
| Optional dependency groups (``[project.optional-dependencies]``) are ignored; | ||
| users who need those should use a ``requirements.txt`` instead. | ||
|
|
||
| Args: | ||
| pyproject_path: Absolute path to a ``pyproject.toml`` file. | ||
|
|
||
| Returns: | ||
| Newline-separated dependency strings in PEP 508 format suitable for | ||
| ``pip install``, or ``None`` if the file declares no dependencies. | ||
| """ | ||
| with open(pyproject_path, "rb") as f: | ||
| data = tomllib.load(f) | ||
|
|
||
| deps = data.get("project", {}).get("dependencies", []) | ||
| if not deps: | ||
| return None | ||
| return "\n".join(deps) + "\n" |
There was a problem hiding this comment.
This is a well-implemented function. For better type consistency and to align with how empty requirements.txt files are handled (which are read as an empty string), consider changing the return type from str | None to just str. The function can return an empty string "" when no dependencies are found.
This would involve changing the function signature, implementation, and docstring. The corresponding unit tests would also need to be updated to check for "" instead of None on failure cases.
def _parse_pyproject_dependencies(pyproject_path: str) -> str:
"""Extract ``[project.dependencies]`` from a pyproject.toml file.
Reads only the core dependency list defined under the ``[project]`` table.
Optional dependency groups (``[project.optional-dependencies]``) are ignored;
users who need those should use a ``requirements.txt`` instead.
Args:
pyproject_path: Absolute path to a ``pyproject.toml`` file.
Returns:
Newline-separated dependency strings in PEP 508 format suitable for
``pip install``, or an empty string if the file declares no dependencies.
"""
with open(pyproject_path, "rb") as f:
data = tomllib.load(f)
deps = data.get("project", {}).get("dependencies", [])
return "\n".join(deps) + "\n" if deps else ""
2 participants
Summary
Fixes #81
pyproject.tomlas an alternative torequirements.txtfor specifying container dependencies.[project.dependencies]are extracted and installed viapiprequirements.txtfirst, thenpyproject.tomlat each level;requirements.txtalways takes precedence